The Trunk: Morphic-kfr.1480.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-kfr.1480.mcz

commits-2
Karl Ramberg uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-kfr.1480.mcz

==================== Summary ====================

Name: Morphic-kfr.1480
Author: kfr
Time: 28 February 2019, 4:40:24.875838 pm
UUID: 9fdf2251-873b-9b42-a287-d85231cd70d3
Ancestors: Morphic-kfr.1479

Force update of TheWorldMainDockingBar

=============== Diff against Morphic-kfr.1479 ===============

Item was changed:
  ----- Method: TheWorldMainDockingBar>>newProjectMenuItemOn: (in category 'submenu - projects') -----
  newProjectMenuItemOn: menu
 
  Project allSubclasses do: [ :each |
  menu addItem: [ :item |
  item
  contents: ('New ', each name) translated;
  help: ('Start a new ', each name) translated;
  target: self;
  selector: #newProject:;
+ arguments: { each } ] ] !
- arguments: { each } ] ]!

Item was changed:
  (PackageInfo named: 'Morphic') postscript: '"Migrate all open resizers."
  AbstractResizerMorph allSubInstancesDo: [:ea |
  ea handleColor isColor ifFalse: [ea handleColor: nil].
  ea removeAllMorphs].
 
  "Re-enable deprecation warnings in Trunk."
+ Deprecation showDeprecationWarnings: true.
+
+ TheWorldMainDockingBar updateInstances'!
- Deprecation showDeprecationWarnings: true.'!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.1480.mcz

Levente Uzonyi
Hi Karl,

You changed both the preamble and the postscript of the package, which
means that both scripts will be evaluated on update. You also left the
previous preamble and postscript in place (which were not very user
friendly, because they mangled with preferences), which means that those
preference changes will be applied again when your version or Morphic is
loaded.
So, if I update my image which has deprecation warnings disabled, my
setting will be erased and the deprecation warnings will be enabled by
the postscript. In an unfortunate scenario such change could render my
image unresponsive.

When you update any of these scripts, please make sure that only things
that need to be evaluated for the current .mcm stay there. Delete
everything else from the scripts.

Levente

On Thu, 28 Feb 2019, [hidden email] wrote:

> Karl Ramberg uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-kfr.1480.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-kfr.1480
> Author: kfr
> Time: 28 February 2019, 4:40:24.875838 pm
> UUID: 9fdf2251-873b-9b42-a287-d85231cd70d3
> Ancestors: Morphic-kfr.1479
>
> Force update of TheWorldMainDockingBar
>
> =============== Diff against Morphic-kfr.1479 ===============
>
> Item was changed:
>  ----- Method: TheWorldMainDockingBar>>newProjectMenuItemOn: (in category 'submenu - projects') -----
>  newProjectMenuItemOn: menu
>
>   Project allSubclasses do: [ :each |
>   menu addItem: [ :item |
>   item
>   contents: ('New ', each name) translated;
>   help: ('Start a new ', each name) translated;
>   target: self;
>   selector: #newProject:;
> + arguments: { each } ] ] !
> - arguments: { each } ] ]!
>
> Item was changed:
>  (PackageInfo named: 'Morphic') postscript: '"Migrate all open resizers."
>  AbstractResizerMorph allSubInstancesDo: [:ea |
>   ea handleColor isColor ifFalse: [ea handleColor: nil].
>   ea removeAllMorphs].
>
>  "Re-enable deprecation warnings in Trunk."
> + Deprecation showDeprecationWarnings: true.
> +
> + TheWorldMainDockingBar updateInstances'!
> - Deprecation showDeprecationWarnings: true.'!

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-kfr.1480.mcz

Karl Ramberg
I'm sorry about that. I did not know I had to delete the other stuff from the preamble and the postscript.
This change was meant for the inbox and I miss-clicked, and had to do some fixup when the menu bar didn't update.

Sorry, again.

Best, 
Karl

On Thu, Feb 28, 2019 at 11:47 PM Levente Uzonyi <[hidden email]> wrote:
Hi Karl,

You changed both the preamble and the postscript of the package, which
means that both scripts will be evaluated on update. You also left the
previous preamble and postscript in place (which were not very user
friendly, because they mangled with preferences), which means that those
preference changes will be applied again when your version or Morphic is
loaded.
So, if I update my image which has deprecation warnings disabled, my
setting will be erased and the deprecation warnings will be enabled by
the postscript. In an unfortunate scenario such change could render my
image unresponsive.

When you update any of these scripts, please make sure that only things
that need to be evaluated for the current .mcm stay there. Delete
everything else from the scripts.

Levente

On Thu, 28 Feb 2019, [hidden email] wrote:

> Karl Ramberg uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-kfr.1480.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-kfr.1480
> Author: kfr
> Time: 28 February 2019, 4:40:24.875838 pm
> UUID: 9fdf2251-873b-9b42-a287-d85231cd70d3
> Ancestors: Morphic-kfr.1479
>
> Force update of TheWorldMainDockingBar
>
> =============== Diff against Morphic-kfr.1479 ===============
>
> Item was changed:
>  ----- Method: TheWorldMainDockingBar>>newProjectMenuItemOn: (in category 'submenu - projects') -----
>  newProjectMenuItemOn: menu
>
>       Project allSubclasses do: [ :each |
>               menu addItem: [ :item |
>                       item
>                               contents: ('New ', each name) translated;
>                               help: ('Start a new ', each name) translated;
>                               target: self;
>                               selector: #newProject:;
> +                             arguments: { each } ] ] !
> -                             arguments: { each } ] ]!
>
> Item was changed:
>  (PackageInfo named: 'Morphic') postscript: '"Migrate all open resizers."
>  AbstractResizerMorph allSubInstancesDo: [:ea |
>       ea handleColor isColor ifFalse: [ea handleColor: nil].
>       ea removeAllMorphs].
>
>  "Re-enable deprecation warnings in Trunk."
> + Deprecation showDeprecationWarnings: true.
> +
> + TheWorldMainDockingBar updateInstances'!
> - Deprecation showDeprecationWarnings: true.'!