The Trunk: Morphic-mtf.491.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: Morphic-mtf.491.mcz

commits-2
Matthew Fulmer uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mtf.491.mcz

==================== Summary ====================

Name: Morphic-mtf.491
Author: mtf
Time: 10 December 2010, 12:23:08.546 pm
UUID: 54f2e960-5208-4eba-b121-abaca6f89c05
Ancestors: Morphic-ul.490

Allow the right-click menus on Tweak fields in the Tweak Browser to work

=============== Diff against Morphic-ul.490 ===============

Item was changed:
  ----- Method: TextMorphForEditView>>mouseDown: (in category 'event handling') -----
  mouseDown: event
 
+ event yellowButtonPressed ifTrue: [
+ (editor yellowButtonDown: event) ifTrue:[^self].
+ ^ editView yellowButtonActivity: event shiftPressed].
- event yellowButtonPressed ifTrue: [^ editView yellowButtonActivity: event shiftPressed].
  ^ super mouseDown: event
  !


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mtf.491.mcz

Nicolas Cellier
Err...
There is no implementor of #yellowButtonDown: in my trunk image...
The yellow menu is now out of service...

Nicolas

2010/12/13  <[hidden email]>:

> Matthew Fulmer uploaded a new version of Morphic to project The Trunk:
> http://source.squeak.org/trunk/Morphic-mtf.491.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-mtf.491
> Author: mtf
> Time: 10 December 2010, 12:23:08.546 pm
> UUID: 54f2e960-5208-4eba-b121-abaca6f89c05
> Ancestors: Morphic-ul.490
>
> Allow the right-click menus on Tweak fields in the Tweak Browser to work
>
> =============== Diff against Morphic-ul.490 ===============
>
> Item was changed:
>  ----- Method: TextMorphForEditView>>mouseDown: (in category 'event handling') -----
>  mouseDown: event
>
> +       event yellowButtonPressed ifTrue: [
> +               (editor yellowButtonDown: event) ifTrue:[^self].
> +               ^ editView yellowButtonActivity: event shiftPressed].
> -       event yellowButtonPressed ifTrue: [^ editView yellowButtonActivity: event shiftPressed].
>        ^ super mouseDown: event
>  !
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mtf.491.mcz

Tapple Gao
On Mon, Dec 13, 2010 at 10:47:16PM -0500, Matthew Fulmer wrote:
> yellowButtonDown: is an extention to ParagraphEditor in Tweak,
> and ultimately allows text attributes to specify their own
> context menu, which is used in the tweak code browser.

A common application that would use this feature is a spell
checker. A spell checking syntax highlighter gives misspelled
words the text attribute "misspelled". the text attribute would
render its text with a red wavy underline, and give a context
menu with spelling suggestions when the text is right-clicked

--
Matthew Fulmer (a.k.a. Tapple)

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mtf.491.mcz

Bert Freudenberg

On 13.12.2010, at 20:02, Matthew Fulmer wrote:

> On Mon, Dec 13, 2010 at 10:47:16PM -0500, Matthew Fulmer wrote:
>> yellowButtonDown: is an extention to ParagraphEditor in Tweak,
>> and ultimately allows text attributes to specify their own
>> context menu, which is used in the tweak code browser.
>
> A common application that would use this feature is a spell
> checker. A spell checking syntax highlighter gives misspelled
> words the text attribute "misspelled". the text attribute would
> render its text with a red wavy underline, and give a context
> menu with spelling suggestions when the text is right-clicked
>
> --
> Matthew Fulmer (a.k.a. Tapple)

Sounds useful. If it's really just 4 methods, I'd say commit the whole bunch. Way better than having to maintain overrides in any case.

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mtf.491.mcz

Levente Uzonyi-2
In reply to this post by Nicolas Cellier

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: Morphic-mtf.491.mcz

Tapple Gao
In reply to this post by Bert Freudenberg
On Mon, Dec 13, 2010 at 08:07:14PM -0800, Bert Freudenberg wrote:

>
> On 13.12.2010, at 20:02, Matthew Fulmer wrote:
>
> > On Mon, Dec 13, 2010 at 10:47:16PM -0500, Matthew Fulmer wrote:
> >> yellowButtonDown: is an extention to ParagraphEditor in Tweak,
> >> and ultimately allows text attributes to specify their own
> >> context menu, which is used in the tweak code browser.
> >
> > A common application that would use this feature is a spell
> > checker. A spell checking syntax highlighter gives misspelled
> > words the text attribute "misspelled". the text attribute would
> > render its text with a red wavy underline, and give a context
> > menu with spelling suggestions when the text is right-clicked
> >
> > --
> > Matthew Fulmer (a.k.a. Tapple)
>
> Sounds useful. If it's really just 4 methods, I'd say commit the whole bunch. Way better than having to maintain overrides in any case.

k. committed the remainder of this change. Collections-mtf.417
and Morphic-mtf.496

--
Matthew Fulmer (a.k.a. Tapple)