Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk:
http://source.squeak.org/trunk/ReleaseBuilder-mt.125.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.125 Author: mt Time: 1 July 2015, 10:15:47.361 am UUID: 3338b57a-ab20-ac44-b37b-d4e09f23e453 Ancestors: ReleaseBuilder-cmm.124 Restore setting the background in release builder's #setPreferences46 so that our build server produces trunk images with correct preferences again. #prepareNewBuild: is agnostic to the current release version. Note: We should find out why #prepareNewBuild: requires another try to set the background and where that background gets overridden. It is not good to put version-specific code into a version-agnostic method. =============== Diff against ReleaseBuilder-cmm.124 =============== Item was changed: ----- Method: ReleaseBuilder class>>setPreferences46 (in category 'preferences') ----- setPreferences46 "Preferences class defaultValueTableForCurrentRelease" + self setProjectBackground: Color darkGray. + "General User interaction" Preferences enable: #swapMouseButtons; disable: #mouseOverForKeyboardFocus. Morph indicateKeyboardFocus: true. "Text input." TextEditor autoEnclose: true ; autoIndent: true ; destructiveBackWord: false ; blinkingCursor: true ; dumbbellCursor: false. Preferences insertionPointColor: Color red. PluggableTextMorph simpleFrameAdornments: false. "Windows" Preferences installUniformWindowColors. SystemWindow reuseWindows: false. Model windowActiveOnFirstClick: false. "Not good for 800x600" Preferences disable: #showSplitterHandles; enable: #fastDragWindowForMorphic. CornerGripMorph drawCornerResizeHandles: false. ProportionalSplitterMorph smartHorizontalSplitters: false ; smartVerticalSplitters: false. "Scroll bars." Preferences enable: #scrollBarsNarrow; enable: #scrollBarsOnRight; disable: #alwaysHideHScrollbar; disable: #alwaysShowHScrollbar; disable: #alwaysShowVScrollbar. ScrollBar scrollBarsWithoutArrowButtons: true; scrollBarsWithoutMenuButton: true. ScrollPane useRetractableScrollBars: false. "Rounded corners." Morph preferredCornerRadius: 6. Preferences disable: #roundedWindowCorners. PluggableButtonMorph roundedButtonCorners: false. FillInTheBlankMorph roundedDialogCorners: false. MenuMorph roundedMenuCorners: false. ScrollBar roundedScrollBarLook: false. "Gradients." Preferences disable: #gradientScrollBars. SystemWindow gradientWindow: false. MenuMorph gradientMenu: false. PluggableButtonMorph gradientButton: false. "Shadows" Preferences enable: #menuAppearance3d. MenuMorph menuBorderWidth: 1; menuBorderColor: Color lightGray; menuLineColor: Color lightGray. Morph useSoftDropShadow: true.. "Lists and Trees" PluggableListMorph filterableLists: true; clearFilterAutomatically: false; highlightHoveredRow: true; menuRequestUpdatesSelection: true. PluggableTreeMorph filterByLabelsOnly: false; maximumSearchDepth: 1. LazyListMorph listSelectionTextColor: Color black; listSelectionColor: (Color r: 0.72 g: 0.72 b: 0.9). "Standard Tools" BalloonMorph setBalloonColorTo: (TranslucentColor r: 0.92 g: 0.92 b: 0.706 alpha: 0.75). Workspace shouldStyle: false. Browser listClassesHierarchically: true; showClassIcons: true; showMessageIcons: true; sortMessageCategoriesAlphabetically: true. Preferences enable: #annotationPanes; enable: #optionalButtons; enable: #diffsWithPrettyPrint; enable: #traceMessages; enable: #alternativeBrowseIt; enable: #menuWithIcons; enable: #visualExplorer. SystemNavigation thoroughSenders: true. "Halo" Preferences enable: #showBoundsInHalo ; disable: #alternateHandlesLook. "System" NetNameResolver enableIPv6: false. Scanner allowUnderscoreAsAssignment: true; prefAllowUnderscoreSelectors: true. "that's all, folks"! |
Hi, Could the color be set wrong in PasteUpMorph>>#initForProject: ?There project color is set to Preferences defaultWorldColor. Karl On Wed, Jul 1, 2015 at 10:15 AM, <[hidden email]> wrote: Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: |
On Wed, Jul 1, 2015 at 7:36 AM, karl ramberg <[hidden email]> wrote:
> Hi, > Could the color be set wrong in PasteUpMorph>>#initForProject: ? > > There project color is set to Preferences defaultWorldColor. That was my thought too. So I'll bet we're back to the background color not working at all. Plus, setPreferences46 is called indirectly from prepareNewBuild:, so it is not release-agnostic in the first place. But why is release-agnostic desirable anyway? We have a historical record of every version of every method, and also every release from which Preferences can be exported. I think we should get rid of setPreference46 entirely... |
Free forum by Nabble | Edit this page |