The Trunk: Services-Base-eem.56.mcz

Eliot Miranda uploaded a new version of Services-Base to project The Trunk:
http://source.squeak.org/trunk/Services-Base-eem.56.mcz

==================== Summary ====================

Name: Services-Base-eem.56
Author: eem
Time: 30 June 2015, 3:34:50.838 pm
UUID: 2e8b9c56-6312-4a69-b65c-164ab583f617
Ancestors: Services-Base-mt.55

ServicePreferences as per System-eem.747.  Move preferences dictionary from class var to inst var.

=============== Diff against Services-Base-mt.55 ===============

Item was added:
+ (PackageInfo named: 'Services-Base') preamble: '(Smalltalk classNamed: #ServicePreferences) ifNotNil:
+ [:sp|
+ (sp instVarNamed: ''preferencesDictionary'') ifNil:
+ [(sp classPool at: #ServiceDictionaryOfPreferences) ifNotNil:
+ [:dictionary|
+ sp
+ instVarNamed: ''preferencesDictionary''
+ put: dictionary]]]'!

Item was changed:
  Preferences subclass: #ServicePreferences
  instanceVariableNames: ''
+ classVariableNames: ''
- classVariableNames: 'ServiceDictionaryOfPreferences'
  poolDictionaries: ''
  category: 'Services-Base-GUI'!
 
  !ServicePreferences commentStamp: 'rr 7/10/2006 15:36' prior: 0!
  I store the preferences related to the servicse framework. The preferences are editable via the Services Browser, based on Hernan Tylim's Preference Browser.
 
  The main preference categories for services are:
 
  -- keyboard shortcuts -- : several text preferences, one per keyboard shortcuts. To edit them,  enter a service identifier (equal to the method name under which it is defined in its ServiceProvider), and accept with alt-s or enter
 
  -- menu contents -- : All the service categories in the image have a text preference under here. To edit it, enter the services identifiers you wish to put in this category, separating them with a single space character. The order is important: it defines the order of the items in menus.
 
  -- settings -- : general boolean preferences.
 
  Then there is a preference category for each provider in the image. Under each, you will find:
  A boolean preference for each service in the image. If it is false, the service will not appear in menus.
  The text preference for each service category defined by the service provider. This is the same as the one appearing in the menu contents preference category.!

Item was removed:
- ----- Method: ServicePreferences class>>dictionaryOfPreferences (in category 'accessing') -----
- dictionaryOfPreferences
- ServiceDictionaryOfPreferences
- ifNil: [ServiceDictionaryOfPreferences := IdentityDictionary new].
- ^ ServiceDictionaryOfPreferences !

Item was removed:
- ----- Method: ServicePreferences class>>dictionaryOfPreferences: (in category 'accessing') -----
- dictionaryOfPreferences: aDictionary
- ServiceDictionaryOfPreferences := aDictionary!

Item was changed:
  ----- Method: ServicePreferences class>>wipe (in category 'accessing') -----
  wipe
+ preferencesDictionary := nil!
- self dictionaryOfPreferences: nil!

On 01-07-2015, at 7:57 PM, [hidden email] wrote:

The preamble breaks in a spur (15046) image; there is no such instvar. Unsurprisingly this is the same from both ‘update Squeak’ and manually loading the mcz.

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Make it right before you make it faster.

Hi Tim,

Services-Base-eem.56 depends on System-eem.746 (or later). This dependency
is ensured by the last few non-spur update maps. But those maps, along
with the last few versions of the System package, haven't been "ported" to
spur yet.
So the spur update process doesn't work at the moment. It'll be fixed when
Eliot runs his script to create the missing non-spur version.

Levente

On Wed, 1 Jul 2015, tim Rowledge wrote: