The Trunk: System-cwp.661.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: System-cwp.661.mcz

commits-2
Colin Putney uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-cwp.661.mcz

==================== Summary ====================

Name: System-cwp.661
Author: cwp
Time: 9 January 2014, 6:56:09.652 pm
UUID: d6fdfa88-0d1f-45b0-898a-dd1298e6da72
Ancestors: System-cwp.660

Fix the bug I introduced to SystemNavigation>>allObjectsDo:.

=============== Diff against System-cwp.660 ===============

Item was changed:
  ----- Method: SystemNavigation>>allObjectsDo: (in category 'query') -----
  allObjectsDo: aBlock
  "Evaluate the argument, aBlock, for each object in the system
  excluding SmallIntegers. With closures, this needs to use an end
  marker (lastObject) since activation of the block will create new
  contexts and cause an infinite loop."
  | object lastObject |
  object := self someObject.
  lastObject := Object new.
+ [lastObject == object or: [0 == object]]
- [lastObject == object | object == 0]
  whileFalse: [aBlock value: object.
  object := object nextObject]!

Item was added:
+ ----- Method: TextSqkProjectLink>>writeScanOn: (in category 'as yet unclassified') -----
+ writeScanOn: strm
+
+ strm nextPut: $p; nextPutAll: url; nextPut: $;!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.661.mcz

Frank Shearar-3
On 9 January 2014 23:57,  <[hidden email]> wrote:

> Colin Putney uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-cwp.661.mcz
>
> ==================== Summary ====================
>
> Name: System-cwp.661
> Author: cwp
> Time: 9 January 2014, 6:56:09.652 pm
> UUID: d6fdfa88-0d1f-45b0-898a-dd1298e6da72
> Ancestors: System-cwp.660
>
> Fix the bug I introduced to SystemNavigation>>allObjectsDo:.
>
> =============== Diff against System-cwp.660 ===============
>
> Item was changed:
>   ----- Method: SystemNavigation>>allObjectsDo: (in category 'query') -----
>   allObjectsDo: aBlock
>         "Evaluate the argument, aBlock, for each object in the system
>         excluding SmallIntegers. With closures, this needs to use an end
>         marker (lastObject) since activation of the block will create new
>         contexts and cause an infinite loop."
>         | object lastObject |
>         object := self someObject.
>         lastObject := Object new.
> +       [lastObject == object or: [0 == object]]
> -       [lastObject == object | object == 0]
>                 whileFalse: [aBlock value: object.
>                         object := object nextObject]!
>
> Item was added:
> + ----- Method: TextSqkProjectLink>>writeScanOn: (in category 'as yet unclassified') -----
> + writeScanOn: strm
> +
> +       strm nextPut: $p; nextPutAll: url; nextPut: $;!

I don't think you meant to commit this chunk. I've seen it crop up a
few times, and have actually figured out why it happens twice... and
forgotten again. The method is supposed to be in System, though.

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: System-cwp.661.mcz

Colin Putney-3



On Fri, Jan 10, 2014 at 3:21 AM, Frank Shearar <[hidden email]> wrote:
 
> Item was added:
> + ----- Method: TextSqkProjectLink>>writeScanOn: (in category 'as yet unclassified') -----
> + writeScanOn: strm
> +
> +       strm nextPut: $p; nextPutAll: url; nextPut: $;!

I don't think you meant to commit this chunk. I've seen it crop up a
few times, and have actually figured out why it happens twice... and
forgotten again. The method is supposed to be in System, though.

Could this be another case of the package being dirty in the base image, but marked clean? 

Colin