Smalltalk › Squeak › Squeak - Dev

The Trunk: System-mt.762.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-2

The Trunk: System-mt.762.mcz

Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.762.mcz

==================== Summary ====================

Name: System-mt.762
Author: mt
Time: 27 August 2015, 11:00:03.719 am
UUID: cf2a7eb1-d084-c442-a275-582d975bb994
Ancestors: System-mt.761

Restores #togglePreference: for backwards compatibility.

=============== Diff against System-mt.761 ===============

Item was added:
+ ----- Method: Preferences class>>togglePreference: (in category 'get/set - flags') -----
+ togglePreference: flagName
+
+ self flag: #deprecated.
+ ^ self toggle: flagName.!

Nicolas Cellier

Re: The Trunk: System-mt.762.mcz

2015-08-27 11:00 GMT+02:00 <[hidden email]>:

Marcel Taeumel uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-mt.762.mcz

==================== Summary ====================

Name: System-mt.762
Author: mt
Time: 27 August 2015, 11:00:03.719 am
UUID: cf2a7eb1-d084-c442-a275-582d975bb994
Ancestors: System-mt.761

Restores #togglePreference: for backwards compatibility.

=============== Diff against System-mt.761 ===============

Item was added:
+ ----- Method: Preferences class>>togglePreference: (in category 'get/set - flags') -----
+ togglePreference: flagName
+
+ self flag: #deprecated.
+ ^ self toggle: flagName.!

One thing I wonder, though being redundant, doesn't togglePreference: help reducing false polymorphism?

marcel.taeumel

Re: The Trunk: System-mt.762.mcz

Hmm... you write: "Preferences toggle: #foo". Isn't this enough?

Best,
Marcel

marcel.taeumel

Re: The Trunk: System-mt.762.mcz

...we might want to add a 'flag' suffix to all enable, disable, toggle messages? I thought that those refer inherently to boolean preferences (aka. flags).

Best,
Marcel