The Trunk: Tests-pre.349.mcz

On Mon, 15 Aug 2016, [hidden email] wrote:

Patrick Rein uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-pre.349.mcz

==================== Summary ====================

Name: Tests-pre.349
Author: pre
Time: 15 August 2016, 11:23:47.344656 pm
UUID: ab567e83-59da-9049-af1a-aa3c78112c85
Ancestors: Tests-pre.348

Updates decompiler expected failures to the new state of the source code.

=============== Diff against Tests-pre.348 ===============

Item was changed:
 ----- Method: DecompilerTests>>decompilerFailures (in category 'utilities') -----
 decompilerFailures
        "Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly.
         Collected via
                DecompilerTestFailuresCollector new computeFailures."

        "class name, selector, error class name or nil"
+       ^ #(#(#Behavior #toolIconSelector: #TestFailure) #(#BrowserCommentTextMorph #showPane #SyntaxErrorNotification) #(#ClassDescription #replaceSilently:to: #SyntaxErrorNotification) #(#CodeHolder #getSelectorAndSendQuery:to:with: #SyntaxErrorNotification) #(#Date #printOn: #TestFailure) #(#DecompilerTests #testDecompileUnreachableParameter #Error) #(#FontImporterTool #fontFromFamily: #SyntaxErrorNotification) #(#HttpUrl #checkAuthorization:retry: #TestFailure) #(#LargeNegativeIntegerTest #testReplaceFromToWithStartingAt #SyntaxErrorNotification) #(#LargePositiveIntegerTest #testReplaceFromToWithStartingAt #SyntaxErrorNotification) #(#MailComposition #breakLinesInMessage: #SyntaxErrorNotification) #(#MCConfigurationBrowser #post #SyntaxErrorNotification) #(#MVCToolBuilder #setLayout:in: #SyntaxErrorNotification) #(#ParagraphEditor #inOutdent:delta: #SyntaxErrorNotification) #(#PNGReadWriter #copyPixelsGray: #SyntaxErrorNotification) #(#ProtoObjectTest #testIfNilIfNotNil #SyntaxErrorNotification) #(#ProtoObjectTest #testIfNotNil #SyntaxErrorNotification) #(#ProtoObjectTest #testIfNotNilIfNil #SyntaxErrorNotification) #(#RxsCharSet #enumerablePartPredicateIgnoringCase: #SyntaxErrorNotification) #(#ScaledDecimalTest #testConvertFromFraction #SyntaxErrorNotification) #(#SHMCClassDefinition #withAllSuperclassesDo: #SyntaxErrorNotification) #(#StandardScriptingSystem #holderWithAlphabet #SyntaxErrorNotification) #(#SyntaxMorph #mouseEnterDragging: #SyntaxErrorNotification) #(#SystemWindow #convertAlignment #SyntaxErrorNotification) #(#TextEditor #inOutdent:delta: #SyntaxErrorNotification) #(#TextURL #actOnClickFor: #TestFailure) #(#WeakSet #scanForLoadedSymbol: #TestFailure))!

Please keep the indentation.

Levente

-       ^#(     (Behavior toolIconSelector: TestFailure)
-               (BrowserCommentTextMorph showPane SyntaxErrorNotification)
-               (ClassDescription replaceSilently:to: SyntaxErrorNotification)
-               (CodeHolder getSelectorAndSendQuery:to:with: SyntaxErrorNotification)
-               (Date printOn: TestFailure)
-               (DecompilerTests testDecompileUnreachableParameter Error)
-               (FontImporterTool fontFromFamily: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
-               (HttpUrl checkAuthorization:retry: TestFailure)
-               (LargeNegativeIntegerTest testReplaceFromToWithStartingAt SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
-               (LargePositiveIntegerTest testReplaceFromToWithStartingAt SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
-               (MailComposition breakLinesInMessage: SyntaxErrorNotification)
-               (MCConfigurationBrowser post SyntaxErrorNotification)
-               (MVCToolBuilder setLayout:in: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
-               (ParagraphEditor inOutdent:delta: SyntaxErrorNotification)
-               (PNGReadWriter copyPixelsGray: SyntaxErrorNotification)
-               (ScaledDecimalTest testConvertFromFraction SyntaxErrorNotification) "local/non-local temps"
-               (SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
-               (StandardScriptingSystem holderWithAlphabet SyntaxErrorNotification) "same-name block-local temps in optimized blocks"
-               (SystemWindow convertAlignment SyntaxErrorNotification)
-               (TextEditor inOutdent:delta: SyntaxErrorNotification)
-               (TextURL actOnClickFor: TestFailure)
-               (TTContourConstruction segmentsDo: SyntaxErrorNotification) "Worth fixing; these two are mistaken conversion from a whileTrue: to a to:do: but the index is used outside the whileTrue:"
-               (TTFontReader processHorizontalMetricsTable:length: SyntaxErrorNotification))!

Fortunately, the server doesn't diffsWithPrettyPrint ;)

That's definitely one Preferences to be set to false by default IMO.