The Trunk: ToolBuilder-Kernel-dtl.69.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

The Trunk: ToolBuilder-Kernel-dtl.69.mcz

commits-2
David T. Lewis uploaded a new version of ToolBuilder-Kernel to project The Trunk:
http://source.squeak.org/trunk/ToolBuilder-Kernel-dtl.69.mcz

==================== Summary ====================

Name: ToolBuilder-Kernel-dtl.69
Author: dtl
Time: 28 March 2015, 8:42:26.128 pm
UUID: 37be26fe-92e2-4f05-9298-ad1b771b3b8b
Ancestors: ToolBuilder-Kernel-dtl.68

UIManager>>confirm:label: is unimplemented and unreferenced since 2009. Remove it.

=============== Diff against ToolBuilder-Kernel-dtl.68 ===============

Item was removed:
- ----- Method: UIManager>>confirm:label: (in category 'ui requests') -----
- confirm: queryString label: titleString
-
- ^self subclassResponsibility!


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

Tobias Pape

On 29.03.2015, at 00:42, [hidden email] wrote:

> David T. Lewis uploaded a new version of ToolBuilder-Kernel to project The Trunk:
> http://source.squeak.org/trunk/ToolBuilder-Kernel-dtl.69.mcz
>
> ==================== Summary ====================
>
> Name: ToolBuilder-Kernel-dtl.69
> Author: dtl
> Time: 28 March 2015, 8:42:26.128 pm
> UUID: 37be26fe-92e2-4f05-9298-ad1b771b3b8b
> Ancestors: ToolBuilder-Kernel-dtl.68
>
> UIManager>>confirm:label: is unimplemented and unreferenced since 2009. Remove it.
>

Regarding the whole UIManager api, don't you think implementing it would be a better
move than removing?
Best
        -Tobias

> =============== Diff against ToolBuilder-Kernel-dtl.68 ===============
>
> Item was removed:




Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

David T. Lewis
On Sun, Mar 29, 2015 at 12:52:16PM +0200, Tobias Pape wrote:

>
> On 29.03.2015, at 00:42, [hidden email] wrote:
>
> > David T. Lewis uploaded a new version of ToolBuilder-Kernel to project The Trunk:
> > http://source.squeak.org/trunk/ToolBuilder-Kernel-dtl.69.mcz
> >
> > ==================== Summary ====================
> >
> > Name: ToolBuilder-Kernel-dtl.69
> > Author: dtl
> > Time: 28 March 2015, 8:42:26.128 pm
> > UUID: 37be26fe-92e2-4f05-9298-ad1b771b3b8b
> > Ancestors: ToolBuilder-Kernel-dtl.68
> >
> > UIManager>>confirm:label: is unimplemented and unreferenced since 2009. Remove it.
> >
>
> Regarding the whole UIManager api, don't you think implementing it would be a better
> move than removing?
> Best
> -Tobias


Possibly yes. It looked like leftover cruft from the early days when
ToolBuilder was first brought into the image (there were a few loose ends
at that time). But I can see how it might be useful in some cases.

Try this in an MVC project:

  UIManager default confirm: 'Does this need a label?'

Dave


Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

marcel.taeumel (old)
In reply to this post by Tobias Pape
The correct interface seems to be #confirm:title:. ;-) And this is already implemented.

Best,
Marcel
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

David T. Lewis
On Sun, Mar 29, 2015 at 09:09:27AM -0700, Marcel Taeumel wrote:
> The correct interface seems to be #confirm:title:. ;-) And this is already
> implemented.
>

You are right, #confirm:title: would be better than #confirm:label: and it
is already implemented in UserDialogBoxMorph for Morphic.

UIManager currently supports these three methods:

  UIManager default confirm: 'Do you like chocolate?'
  UIManager default confirm: 'Do you like chocolate?' orCancel: [self halt].
  UIManager default confirm: 'Do you like chocolate?' trueChoice: 'trueButtonLabel' falseChoice: 'falseButtonLabel'.

If we add #confirm:title: to UIManager, then we should probably do it for
all three methods.

Dave
 

Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

Tobias Pape

On 29.03.2015, at 20:26, David T. Lewis <[hidden email]> wrote:

> On Sun, Mar 29, 2015 at 09:09:27AM -0700, Marcel Taeumel wrote:
>> The correct interface seems to be #confirm:title:. ;-) And this is already
>> implemented.
>>
>
> You are right, #confirm:title: would be better than #confirm:label: and it
> is already implemented in UserDialogBoxMorph for Morphic.
>
> UIManager currently supports these three methods:
>
>  UIManager default confirm: 'Do you like chocolate?'
>  UIManager default confirm: 'Do you like chocolate?' orCancel: [self halt].
>  UIManager default confirm: 'Do you like chocolate?' trueChoice: 'trueButtonLabel' falseChoice: 'falseButtonLabel'.
>
> If we add #confirm:title: to UIManager, then we should probably do it for
> all three methods.

Ack :)

Best
        -Tobias
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

David T. Lewis
On Sun, Mar 29, 2015 at 09:02:48PM +0200, Tobias Pape wrote:

>
> On 29.03.2015, at 20:26, David T. Lewis <[hidden email]> wrote:
>
> > On Sun, Mar 29, 2015 at 09:09:27AM -0700, Marcel Taeumel wrote:
> >> The correct interface seems to be #confirm:title:. ;-) And this is already
> >> implemented.
> >>
> >
> > You are right, #confirm:title: would be better than #confirm:label: and it
> > is already implemented in UserDialogBoxMorph for Morphic.
> >
> > UIManager currently supports these three methods:
> >
> >  UIManager default confirm: 'Do you like chocolate?'
> >  UIManager default confirm: 'Do you like chocolate?' orCancel: [self halt].
> >  UIManager default confirm: 'Do you like chocolate?' trueChoice: 'trueButtonLabel' falseChoice: 'falseButtonLabel'.
> >
> > If we add #confirm:title: to UIManager, then we should probably do it for
> > all three methods.
>
> Ack :)
>
Done.

Pictures of the corresponding Morphic and MVC dialog boxes attached.

Dave




MVC.png (11K) Download Attachment
Morphic.png (11K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: The Trunk: ToolBuilder-Kernel-dtl.69.mcz

Tobias Pape
Hey

On 29.03.2015, at 23:13, David T. Lewis <[hidden email]> wrote:

> On Sun, Mar 29, 2015 at 09:02:48PM +0200, Tobias Pape wrote:
>>
>> On 29.03.2015, at 20:26, David T. Lewis <[hidden email]> wrote:
>>
>>> On Sun, Mar 29, 2015 at 09:09:27AM -0700, Marcel Taeumel wrote:
>>>> The correct interface seems to be #confirm:title:. ;-) And this is already
>>>> implemented.
>>>>
>>>
>>> You are right, #confirm:title: would be better than #confirm:label: and it
>>> is already implemented in UserDialogBoxMorph for Morphic.
>>>
>>> UIManager currently supports these three methods:
>>>
>>> UIManager default confirm: 'Do you like chocolate?'
>>> UIManager default confirm: 'Do you like chocolate?' orCancel: [self halt].
>>> UIManager default confirm: 'Do you like chocolate?' trueChoice: 'trueButtonLabel' falseChoice: 'falseButtonLabel'.
>>>
>>> If we add #confirm:title: to UIManager, then we should probably do it for
>>> all three methods.
>>
>> Ack :)
>>
>
> Done.
>
> Pictures of the corresponding Morphic and MVC dialog boxes attached.

Cool! Thank you.

Best
        -Tobias