The Trunk: Tools-mt.871.mcz

Previous Topic Next Topic
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

The Trunk: Tools-mt.871.mcz

Marcel Taeumel uploaded a new version of Tools to project The Trunk:

==================== Summary ====================

Name: Tools-mt.871
Author: mt
Time: 13 August 2019, 9:56:07.524167 am
UUID: 3f9f47f2-37d6-8c42-98f5-1fc175c5a91f
Ancestors: Tools-mt.870

All messages in deprecated classes are also deprecated.

Note that we do not find deprecated messages in non-deprecated classes, even if those or in deprecation packages such as '*60Deprecated', *if* those messages omit to send #deprecated or #deprecated:. This is on purpose to carefully prepare those deprecations: (1) no senders, (2) add #deprecated, and (3) change implementation to the current way of getting the same effect - if possible.

=============== Diff against Tools-mt.870 ===============

Item was changed:
  ----- Method: CodeHolder>>formattedLabel: (in category 'message list') -----
  formattedLabel: aString
+ "Usually, the label is the same as the selector. Override this if the external representation of a message is different from its internal one."
  ^ self
  formattedLabel: aString
  forSelector: aString
  inClass: self selectedClassOrMetaClass!

Item was changed:
  ----- Method: CodeHolder>>formattedLabel:forSelector:inClass: (in category 'message list') -----
  formattedLabel: aString forSelector: aSymbol inClass: aClass
  "Show deprecated messages differently so that users recognize them quickly to avoid them."
  | formattedLabel |
  aSymbol = #Definition
+ ifTrue: [aClass isDeprecated
+ ifFalse: [^ aString]]
+ ifFalse: [(aClass isDeprecated or: [(aClass compiledMethodAt: aSymbol ifAbsent: [^ aString]) isDeprecated])
+ ifFalse: [^ aString]].
- ifTrue: [aClass isDeprecated not
- ifTrue: [^ aString]]
- ifFalse: [(aClass compiledMethodAt: aSymbol) isDeprecated not
- ifTrue: [^ aString]].
  formattedLabel := aString asText.
  (self userInterfaceTheme deprecatedMessageAttributes ifNil: [{TextColor gray. TextEmphasis struckOut}]) do: [:textAttribute |
  formattedLabel addAttribute: textAttribute].
  ^ formattedLabel.!