The menu bar in question

Hi,

I made a Dr. Geo build with today P7.

There are several issues:

- The menu bar items are not translated (see screenshot1)

- The menu items does not respond, nothing happens

- When a DrGeo window is open maximized, it is wrongly placed at 0@0,
its size is right but misplaced
(see screenshot2)

- There are ugly frame around DrGeo menu and buttons, I don't know if it
is related to menu bar morph related modification but it's unice (see
screenshot2)

The build can be tested at:
https://www.dropbox.com/s/a4wb7c6od4fdl9k/DrGeo.app-18.06a.zip?dl=0

Thanks

Hilaire

--
Dr. Geo
http://drgeo.eu

On 07/06/2018 10:36, Hilaire wrote:
> Hi,
>

Hi Hilaire,

> I made a Dr. Geo build with today P7.
>
> There are several issues:
>
> - The menu bar items are not translated (see screenshot1)
>

I'll take a look:
https://pharo.fogbugz.com/f/cases/22083/Menubar-is-not-translated

> - The menu items does not respond, nothing happens
>

This is normal for now. The Dockerbar menu items are only used to open
other menu. Not to open a windows by itself.

I opened an entry to let the menu items of the Dockerbar open a window:

https://pharo.fogbugz.com/f/cases/22084/Menubar-root-items-without-children-should-be-clickable

I don't know when I'll have the time to implement it.

> - When a DrGeo window is open maximized, it is wrongly placed at 0@0,
> its size is right but misplaced
> (see screenshot2)

This one is weird because when I maximize a window it works fine. I need
to check what happen.
>
> - There are ugly frame around DrGeo menu and buttons, I don't know if it
> is related to menu bar morph related modification but it's unice (see
> screenshot2)

Same, I'll need to take a look. Do you have a screen of the previous
look please?

>
> The build can be tested at:
> https://www.dropbox.com/s/a4wb7c6od4fdl9k/DrGeo.app-18.06a.zip?dl=0
>

Thank you.

> Thanks
>
> Hilaire
>


--
Cyril Ferlicot
https://ferlicot.fr

Le 07/06/2018 à 11:28, Cyril Ferlicot D. a écrit :
>> - There are ugly frame around DrGeo menu and buttons, I don't know if it
>> is related to menu bar morph related modification but it's unice (see
>> screenshot2)
> Same, I'll need to take a look. Do you have a screen of the previous
> look please?
>
https://twitter.com/GNUDrGeo/status/1004436514154180608

The additional frame seems to be on the pane only, not the iconic button
as I wrote in my previous email.

Thanks

Hilaire

--
Dr. Geo
http://drgeo.eu

On 07/06/2018 10:36, Hilaire wrote:
> Hi,
>
> I made a Dr. Geo build with today P7.
>
> There are several issues:
>
> - The menu bar items are not translated (see screenshot1)
>

I'm looking at this one and I would like to have more informations.

The problem is that the menu is created before the current language is
set. So it translate in the wrong language. (It works if you do
"MenubarMorph reset").

I'm looking at a way to reset the menubar when the language change.

Can you explain to me how you do to enable the translation? I never used
this feature and I don't really knows how to enable it.


--
Cyril Ferlicot
https://ferlicot.fr

On 07/06/2018 13:53, Cyril Ferlicot D. wrote:
There is something bad here...

I see in your image that it's managed via Gettext, but get text totaly
replace some classes of Pharo such as NaturalLanguageTranslator.

Since the code is not in Pharo I can't add a system to update the
menubar when the language changes... :(

Also I see that the package "Gettext" is not in the configuration of
gettext. In the configuration it's Gettext-Core that is loaded in the
stable version. And this one does not replace Pharo classes.

I wanted to check the version of Gettext defined in the configuration to
see if there is the same problem but I crashed my Pharo 7 image.

I can't really help more now :( I don't have the time to fix gettext.

--
Cyril Ferlicot
https://ferlicot.fr

Activate Locale:

Locale activated: true.

Then look at its startUp: message.

It seems there is na announcement for locale change.

Hilaire


Le 07/06/2018 à 13:53, Cyril Ferlicot D. a écrit :
--
Dr. Geo
http://drgeo.eu

You should not worry about Gettext or even need it. I think Locale gets
what is needed.

Could you add settings to activate/unactivate the MenuBar?

Hilaire

Le 07/06/2018 à 14:23, Cyril Ferlicot D. a écrit :
--
Dr. Geo
http://drgeo.eu

On 07/06/2018 14:56, Hilaire wrote:
> You should not worry about Gettext or even need it. I think Locale gets
> what is needed.
>

The LocaleChanged event is not send when we change of translator.

> Could you add settings to activate/unactivate the MenuBar?

Should get in the image soon:
https://github.com/pharo-project/pharo/pull/1499


--
Cyril Ferlicot
https://ferlicot.fr