These beautiful tooltips

Hi,

So in Pharo5 we have these 'beautiful' unreadable tooltips: tiny black
font on light gray (ie. take a look to its squeak counter part, it looks
so much more pro)

Is there a way to programmatically change the backround color?

Thanks

Hilaire

--
Dr. Geo
http://drgeo.eu

Hi Hilaire,

Can you provide a screenshot comparison of these?

cheers -ben

On Mon, Jan 30, 2017 at 10:22 PM, Hilaire <[hidden email]> wrote:

Hi Ben,

Here are Squeak and Pharo5 tooltips view.

In regard First impression count, it is a big loose for Pharo5. Well
this whole theme is horrible anyway, contrast is too low in too many part.

In the past I remember to have fix it (not sure) but really I'm fed up
of such negligence. I think something is not working properly in the
Pharo process release.

Another complain, why do we have now for Morph #setBallonText: and
#helpText: to set tooltips?

With my little resource, I am just itching the surface, I wonder how it
is deep underneath.

Thanks

Hilaire

Le 30/01/2017 à 15:56, Ben Coman a écrit :
> Hi Hilaire,
>
> Can you provide a screenshot comparison of these?

--
Dr. Geo
http://drgeo.eu

On Mon, Jan 30, 2017 at 4:16 PM, Hilaire <[hidden email]> wrote:
This is FOSS, you can always provide bug reports, enhancement commits
and propositions to ensure process quality.

--
Serge Stinckwich
UCBN & UMI UMMISCO 209 (IRD/UPMC)
Every DSL ends up being Smalltalk
http://www.doesnotunderstand.org/

I don't buy this argument at all: tooltips were modified to become
unreadable, there are responsibility behind to be taken by someone.
FOSS is not an excuse for mere quality.

In the past I have to fix the WaterTheme because a merge was poorly done
at some point without obviously no visual testing of the consequences.

This is a poor way to do things, and it seems to occur too often in Pharo.

The only proposal I can do is that a careful review is needed before
release. Don't ask me how or who, I can't help much, but it is not a
reason to shut up.

Le 30/01/2017 à 17:08, Serge Stinckwich a écrit :
> This is FOSS, you can always provide bug reports, enhancement commits
> and propositions to ensure process quality.

--
Dr. Geo
http://drgeo.eu

Does it make a difference? I guess you are wearing your glass when at
computer.

Le 30/01/2017 à 17:15, Dimitris Chloupis a écrit :
> I am able to read the Pharo tooltips and I have a 6 degree myopia.
>

--
Dr. Geo
http://drgeo.eu

> Le 30/01/2017 à 15:56, Ben Coman a écrit :
>> Hi Hilaire,
>>
>> Can you provide a screenshot comparison of these?

On Mon, Jan 30, 2017 at 11:16 PM, Hilaire <[hidden email]> wrote: Your Tooltip.png the text appears to be more dark grey than black.   I
can understand that being harder to read. But why is it dark grey?
On my system the text is blacker and I find that clear to read on on a
light grey background.

cheers -ben

On Tue, Jan 31, 2017 at 1:37 AM, Ben Coman <[hidden email]> wrote:
Actually mine also looks fuzzy in the web browser.  Opening both
snapshots with a native tool and comparing them, you font looks
different and slightly smaller.  I'm using default fonts.  Under
System > Settings > Standard Fonts > Balloon-help I have Source Sans
Pro Regular 9.  What is your setting?

cheers -ben

Indeed font is different, but this one can be changed programmatically,
so can be fixed.
I am not sure the same can be done for the background, it is more
important to improve the contrast (for example yellow or even blue as it
was some release ago).

The Squeak tooltip is nice.

Hilaire

Le 30/01/2017 à 18:37, Ben Coman a écrit :
> Your Tooltip.png the text appears to be more dark grey than black.   I
> can understand that being harder to read. But why is it dark grey?
> On my system the text is blacker and I find that clear to read on on a
> light grey background.

--
Dr. Geo
http://drgeo.eu

Well it can't.
So here is the fix for pharo6
https://pharo.fogbugz.com/f/cases/edit/19627/

Le 30/01/2017 à 18:53, Hilaire a écrit :
> I am not sure the same can be done for the background, it is more
> important to improve the contrast (for example yellow or even blue as it
> was some release ago).

--
Dr. Geo
http://drgeo.eu

On Tue, Jan 31, 2017 at 1:30 AM, Hilaire <[hidden email]> wrote:
> I don't buy this argument at all: tooltips were modified to become
> unreadable, there are responsibility behind to be taken by someone.
> FOSS is not an excuse for mere quality.

The point is that people do FOSS to scratch their own itch, not
someone else's.  If you have an itch that you don't want to scratch
yourself, you need to pay someone to scratch it for you.

Now I have no problem with the tooltips.  I'm quite happy with them.
I know *nothing* about themes. They are not my itch.   However I do
value your work in the community with Dr Geo etc, so I've taken the
past hour to discover a hack to help you. Thats all it took to learn
how.  After all this is Pharo.
Try...

BalloonMorph setBalloonColorTo: Color yellow.

Or...

Pharo3Theme subclass: #Pharo3aTheme
   instanceVariableNames: ''
   classVariableNames: ''
   package: 'AAATheme'

Pharo3aTheme>>themeName
   ^ 'Pharo3a'

Pharo3aTheme>>newBalloonHelpIn: aThemedMorph contents:
aTextStringOrMorph for: aMorph corner: cornerSymbol
"Answer a new balloon help morph with the given text
and positioning for aMorph."
    ^ (super
            newBalloonHelpIn: aThemedMorph
            contents: aTextStringOrMorph
            for: aMorph
            corner: cornerSymbol)
        color: Color yellow muchLighter..

And then System > Settings > Appearance > User interface theme
  = Pharo3a

Does that work for you?

btw, I just saw your proposed fix to change UITheme>>balloonBackgroundColor.
It didn't work for me in 50761 or 60262.


cheers -ben

Thanks Ben.

Le 30/01/2017 à 19:22, Ben Coman a écrit :
> BalloonMorph setBalloonColorTo: Color yellow.

I did not know this one. Btw this method name is awful, #ballonColor:
would have made it just fine

>
> Or...
>
> Pharo3Theme subclass: #Pharo3aTheme

I know this one, and I want to avoid it. But thanks again.

> Does that work for you?

Sure the former one will do it for Phratch.

>
> btw, I just saw your proposed fix to change UITheme>>balloonBackgroundColor.
> It didn't work for me in 50761 or 60262.

I have to switch theme back and forth.


--
Dr. Geo
http://drgeo.eu

Le 30/01/2017 à 19:46, Dimitris Chloupis a écrit :
> Of course it does, glasses greatly improve the problem, they do not make
> it go away.

[..]

Ok, I was just bugging you on this one.


> "I don't buy this argument at all: tooltips were modified to become
> unreadable, there are responsibility behind to be taken by someone.
> FOSS is not an excuse for mere quality."
>
> This implies that commercial software does not have crappy GUI, to my
> experience 90% of it does. Mainly because the GUI is for some weird

This is your say not mine. Free software to get success really need to
have strong argument.


> Also being a FOSS is an excuse for mere quality.

No, free software is like Darwinism, evolve and adapt to your ecosystem
or disappear, same for proprietary software but...

...free software contrary to proprietary software may evolve more easily
because of the source code at the disposal of everyone, so evolution and
adaptation is easier, quicker. This is exactly what happen to Squeak,
then the Pharo fork was the promise for a better software with a
different management and more software evolution. In the long term
Squeak may just be better, nothing is written in stone as in evolution.
Pharo to attract more users in its community has no choice but to
improve its overall quality; and as well the first impression count,
little details can make some important different to retain users.

For example in DrGeo, without affordable tooltips, people will just run
it then go away, no obvious way to figure out this mess.

> FOSS is about working for free

Again no :) There is paid people like in proprietary software and the
bonus of unpaid talented or less talented people. Don't think the unpaid
people are the looser, they may gain other important things like
learning and improving own knowledge, experimenting/implementing new
idea (got several case like that in DrGeo history), improving
self-confidence, improving the part you need for your onw
stuff/business, etc.

So all in all, in the long term I think free software should be superior
in quality and affordability to proprietary software.


> The last time I fixed a bug in Pharo , there was so much complaining
> about the way I fixed it that I decided that it would be the very last

But I bet you learn things, especially when people were complaining: its
was feedbacks, as the tooltips in the GUI provide it ;)

Hilaire

--
Dr. Geo
http://drgeo.eu

One way to address this going forward is for theme developers to check their color selections against the e.g. Web Content Accessibility Guidelines (https://www.w3.org/TR/WCAG20/)

Using a readily available tool:

https://leaverou.github.io/contrast-ratio/


And/or one that makes suggestions of contrasting colors for a palette:

http://colorsafe.co


And all themes could be subject to passing at a minimum contrast grade (AA seems not too hard?) before being added to the core. And in that way we have a standard of 'good enough' that is more widely accepted than 'works on my machine, for my eyes, in this physical space, with this ambient lighting'


Paul

HilaireFernandes wrote

Hi,

So in Pharo5 we have these 'beautiful' unreadable tooltips: tiny black
font on light gray (ie. take a look to its squeak counter part, it looks
so much more pro)

Is there a way to programmatically change the backround color?

Thanks

Hilaire

--
Dr. Geo
http://drgeo.eu

I would like to help in both accessibility and implementation detail of
the theme. In the other hand I fell we are in such flux with the future
UI in Pharo. What are the grounds we can stand on regarding UI?

Hilaire

Le 31/01/2017 à 11:21, [hidden email] a
écrit :
> Well there is no subclass of GLMBrickColorThemer so dark themes get
> hardcoded light colors in places for example.
>

--
Dr. Geo
http://drgeo.eu

On Tue, Jan 31, 2017 at 3:15 AM, Hilaire <[hidden email]> wrote:
>
> Le 30/01/2017 à 19:22, Ben Coman a écrit :
>> BalloonMorph setBalloonColorTo: Color yellow.
>
> I did not know this one. Btw this method name is awful, #ballonColor:
> would have made it just fine

I think it is meant to be used very rarely.  It sets class variable
holding the default colour.

>> btw, I just saw your proposed fix to change UITheme>>balloonBackgroundColor.
>> It didn't work for me in 50761 or 60262.

That worked.

Now personally I don't really like yellow there for the tooltip.  I
think it clashes with the blue-ness of the rest of the theme.

To keep in harmony with the blue of the theme? how would you consider
the tooltip matching the selection colour...
  Pharo3Theme>>balloonBackgroundColor
      ^self selectionColor.

or slightly lighter like this...
    Pharo3Theme>>balloonBackgroundColor
      ^Color cyan muchlighter.

Any opinions from the rest of the community on making one of those two default?

cheers -ben