This week (49/2020) on the Issue Tracker

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

This week (49/2020) on the Issue Tracker

Marcus Denker-4

Spec v0.5
==========

New Inspector is now default in Pharo!

- Inspector Introduces concept of "inspection concept" which allows to configure how the presentation will be show (and if it will be shown). For now it does not do much, but potential is huge.
- Inspector uses SpMillerPaginatorPresenter.
- Inspector uses popover to allow command expansion in the toolbar (otherwise is too big).
- Inspector panes are closeable now.
- Inspector, Playground now understand <meta+g> command
- Playground pages now can "open in new page".
- Activation in single click (which triggers column expansion) is now default for inspections (it was double click, but it felt weird).
- Added several inspections (extensions to objects) to match what we had before.
- Most commands now delegate its behavior to their contexts to allow better handling of them.
- Introduce "icon providers" to handle how icons are provided in applications.
- Refactor the way icons are used in StPharoApplication to allow switching of icon sets and the gradual transition from current naming to a better, semantic way of name icons.
- Fixes #128
- Fixes pharo-project/pharo#7700
- Fixes #123
- Several bugfixes.


Small Speed Improvements
========
Some tiny improvements, but the morph related code (like #hasDropShadow) is called in the main rendering loop.

- optimize-hasDropShadow #7917
        https://github.com/pharo-project/pharo/pull/7917
       
- Cleanup code for Morph properties #7903
        https://github.com/pharo-project/pharo/pull/7903
       
- Do not allocate a block when executing #isInstalled #7936
        https://github.com/pharo-project/pharo/pull/7936
       

Fixes
=====

- Fix #7898 #7918
        https://github.com/pharo-project/pharo/pull/7918
               
- Fix infinite recursion upon send of not-understood message to nil #7902
        https://github.com/pharo-project/pharo/pull/7902

- [fix] fixes selector extraction when asking for it at the first chara… #7881
        https://github.com/pharo-project/pharo/pull/7881
               

Improvements / New Features
===========================

- Improve-isHaltNode #7919
        It was detecting all sends to Halt, now it filters for selectors in the right category there.
        https://github.com/pharo-project/pharo/pull/7919
       
- Implementing hasProperty in Behavior and RPackage. #7875
        https://github.com/pharo-project/pharo/pull/7875
       
- Add ExternalAddress class>>#allocate:bytesDuring: #7727
        https://github.com/pharo-project/pharo/pull/7727
       
- No "inconsistent method classification" for methods in deprecated method category #7868
        https://github.com/pharo-project/pharo/pull/7868


Cleaning unused Variables
=========================
After all vars are cleaned, we will add a ReleaseTest so this can never happen again.

- Remove unused ivars from HeuristicCompletion packages #7943
        https://github.com/pharo-project/pharo/pull/7943

- Care on unreferenced variables in OpalCompiler packages #7944
        https://github.com/pharo-project/pharo/pull/7944

- Remove unused environment ivar from BuilderManifestTest #7940
        https://github.com/pharo-project/pharo/pull/7940
       
- Removed unused instance variable traitDefinition in CDTraitParserTest #7886
        https://github.com/pharo-project/pharo/pull/7886
       

Halt Cleanups
=============

There should be no #halt (and similar) sends in the code, Iif it is used for testing, this should be tagged.
The goal then is to add a ReleaseTest to make sure the code stays clean.
This makes the "Browse Breakpoints” feature more usable, too

- tag more tests with <haltOrBreakpointForTesting> #7926
        https://github.com/pharo-project/pharo/pull/7926
       
- 7927-halt-left-in-OmBlockrefreshIfNeededStartingAtsince #7931
        https://github.com/pharo-project/pharo/pull/7931


Cleanups: remove Code
======================

- 7830-DummyFindReplaceService-not-documented-not-used-Can-be-removed #7891
        https://github.com/pharo-project/pharo/pull/7891

- Remove DeprecatedFileStream package #7885
        https://github.com/pharo-project/pharo/pull/7885
       
- shouldDisplayOnTopContext-seems-to-be-not-needed #7873
        https://github.com/pharo-project/pharo/pull/7873

Cleanups
========
And again lots of small cleanups… think about them not as how important one of them is.
This about what happens if you do 10.000 of those.

- 7914-Fluid-builder-should-encapsulate-call-to-install-the-class #7921
        https://github.com/pharo-project/pharo/pull/7921

- on local variable, we had #isUnused, while on Behavior is was #isUsed #7887
        https://github.com/pharo-project/pharo/pull/7887

- RBPragmaNode-accessor-simpler #7950
        https://github.com/pharo-project/pharo/pull/7950
       
- Cleanup tests and mock package of DrTest (Second attempt) #7933
        https://github.com/pharo-project/pharo/pull/7933
       
- Tag classes in DrTests-CommentsToTests #7913
        https://github.com/pharo-project/pharo/pull/7913
       
- Tag classes in DrTests-TestsRunner #7910
        https://github.com/pharo-project/pharo/pull/7910
       
- Typo in DTStatusUpdate class comment #7911
        https://github.com/pharo-project/pharo/pull/7911
       
- 7904-Improve-comment-of--methods #7905
        https://github.com/pharo-project/pharo/pull/7905
       
- Fixed #7840. Deprecating hasPropertyNamed: #7880
        https://github.com/pharo-project/pharo/pull/7880
       
- Cleanup CompiledMethodTest #7874
        https://github.com/pharo-project/pharo/pull/7874
       
- Creating abstract method byteAt: in Integer #7883
        https://github.com/pharo-project/pharo/pull/7883
       
- Deprecated Behavior methods should go to Deprecated Behavior methods … #7866
        https://github.com/pharo-project/pharo/pull/7866
Reply | Threaded
Open this post in threaded view
|

Re: This week (49/2020) on the Issue Tracker

Sean P. DeNigris
Administrator
Wow! Impressive list :)


Marcus Denker-4 wrote
> - Activation in single click (which triggers column expansion) is now
> default for inspections (it was double click, but it felt weird).

-1 on this. The problem with single click is that it adds a column even when
you don't want it to. This was very annoying. IMO after using the
double-click for a few months (it took that long to get used to it), the
extra click is significantly less disruptive than the unnecessary column
adding.



-----
Cheers,
Sean
--
Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: This week (49/2020) on the Issue Tracker

Guillermo Polito


> El 7 dic 2020, a las 17:02, Sean P. DeNigris <[hidden email]> escribió:
>
> Wow! Impressive list :)
>
>
> Marcus Denker-4 wrote
>> - Activation in single click (which triggers column expansion) is now
>> default for inspections (it was double click, but it felt weird).
>
> -1 on this. The problem with single click is that it adds a column even when
> you don't want it to. This was very annoying. IMO after using the
> double-click for a few months (it took that long to get used to it), the
> extra click is significantly less disruptive than the unnecessary column
> adding.

+1 on this.
That is why I made double click by default when I first implemented it.
Every time you click on glamour everything shifts, rotates, moves, it is super disrupting when you **just want to click**.

The single click should not shuffle the UI, or the UI should provide a way to “click” on something without moving everything around.

>
>
>
> -----
> Cheers,
> Sean
> --
> Sent from: http://forum.world.st/Pharo-Smalltalk-Developers-f1294837.html
Reply | Threaded
Open this post in threaded view
|

Re: This week (49/2020) on the Issue Tracker

Esteban Lorenzano


On Dec 7 2020, at 5:22 pm, Guillermo Polito <[hidden email]> wrote:


> El 7 dic 2020, a las 17:02, Sean P. DeNigris <[hidden email]> escribió:
>
> Wow! Impressive list :)
>
>
> Marcus Denker-4 wrote
>> - Activation in single click (which triggers column expansion) is now
>> default for inspections (it was double click, but it felt weird).
>
> -1 on this. The problem with single click is that it adds a column even when
> you don't want it to. This was very annoying. IMO after using the
> double-click for a few months (it took that long to get used to it), the
> extra click is significantly less disruptive than the unnecessary column
> adding.   

+1 on this.
That is why I made double click by default when I first implemented it.
Every time you click on glamour everything shifts, rotates, moves, it is super disrupting when you **just want to click**.

The single click should not shuffle the UI, or the UI should provide a way to “click” on something without moving everything around.


that's why it was double click first and is a setting now.
I preferred the other way too, but people complained so I added a setting.
we are still trying so we can revert the default.
but there is a bug around I want to fix: default activation event is double click or enter, and that's not how it works now (easy to fix, though).

Esteban