2011/5/25 Gastón Dall' Oglio <[hidden email]>
Feel free to play. Just try to write tests for TilingWM please :)
For TWMBar I'm not sure this will be a final GUI. Ideally all will be keyboard driven, I have to play with KeyMapping. I also think the UI theme Patrick has cleaned fits better with TilingWM:
To try it: Gofer it squeaksource: 'PBASandbox'; package: 'PBSandbox';
load. StandardUITheme beCurrent. See screenshot.
Patrick, could you push this with a nice package name ? Laurent.
twm.png (525K) Download Attachment |
2011/5/25 laurent laffont <[hidden email]>
ok. I load a new version to ss. Now teh button tile visible windows only. I fixed the test...
yes, sure.
I try, yes.
|
Gastòn, I've downloaded the new version - thanks a lot for contributing, it brings fun :) Some comment: - tiling browsers don't work any more with OB, WMWithAnOBBrowserAndDockingBarsTest does not create an OBBrowser anymore but a Browser
- you've changed TilingWM>>visibleWindows to TilingWM>>windows. The "visible" was not innocent, because tileVisibleWindows cares about windows that are not minimized. On the other side, tileWorkspaces tile all workspaces, minimized or not. So I think in final we may have:
#tileVisibleWindows #tileWindows (maybe #tileAllWindows is a better name) #tileVisibleWorkspaces
#tileWorkspaces / #tileAllWorkspaces ...... - I will add tests to TWMBar finally as it seems to grow
- I want TilingWM to be 100% test coverage - Balloon and spaces for TWMBar is a good idea - we need to make this work effectively :)
- Great to have all the buttons per type of applications ! I've merge some of your changes in TWM-LaurentLaffont.5
Laurent Laffont - @lolgzs Pharo Smalltalk Screencasts: http://www.pharocasts.com/ Blog: http://magaloma.blogspot.com/ Developer group: http://cara74.seasidehosting.st 2011/5/26 Gastón Dall' Oglio <[hidden email]>
|
2011/5/26 laurent laffont <[hidden email]>
In 1.3 core there's not OBBrowser, then, when trying to modify a method with reference to OBBrowser obtained an error. So I remove their references.
Please, see you the comment in de versión 5 of de package, "Now all botton tile visibles windows.". I think it's better to just get organized visible windows, even when done on a particular kind (such as workspaces). For this is that the word was redundant now visible.
Sorry, give me some time for learn about this...
yes
it is still very rudimentary way to filter the windows, but it was helpful to learn about the hierarchy of classes 1.3, in regard to the Models for example.
:)
|
2011/5/26 Gastón Dall' Oglio <[hidden email]>
I see. I will refactor this so it will be compatible with Core and still work with OB (quite easy).
I will think about this.
Don't hesitate to ask.
Indeed I've disable TaskBarMorph in my image as it's useless now :) Laurent.
|
2011/5/26 laurent laffont <[hidden email]>
This would be great, because now I think, in a core are never the most useful tools (Seaside control panel, memory monitor), and TWM should know about them in some way (you apply a pattern to solve this problem?).
When you have many windows, minimizing them is the way to let them "suspended", therefore I think it should be organized only visibles.
ok.
Great!!! I'll be honest, this is my first serious development in Squeak / Pharo, so it gives me much encouragement your comment, there is still much to learn and improve, but it is very encouraging to devote time to something that might be useful to others.
|
- Now loads in PharoCore - more tests - fill all space even if number of windows is not square. Laurent Laffont - @lolgzs Pharo Smalltalk Screencasts: http://www.pharocasts.com/ Blog: http://magaloma.blogspot.com/
Developer group: http://cara74.seasidehosting.st
2011/5/26 Gastón Dall' Oglio <[hidden email]>
|
:)
2011/5/26 laurent laffont <[hidden email]>
|
Now added top window placement à la OptimizeLayout.
Need to find nice icons. Someone ? Laurent.
2011/5/26 Gastón Dall' Oglio <[hidden email]> :) |
Now with icons, and thanks Patrick for the icon generation idea :)
Laurent.
2011/5/27 laurent laffont <[hidden email]> Now added top window placement à la OptimizeLayout. |
Ohhh look good and simple! I would suggest you use these renovated, but it's too late, and also do not know if there may be some licensing issue: A question, the correct way to load external icons in the image is used ThemeIcons>>createIconMethodsFromDirectory: directory? that particular class should be loaded? PharoUIThemeIcons or TWMBar, for example? in class o instance side?
2011/5/27 laurent laffont <[hidden email]> Now with icons, and thanks Patrick for the icon generation idea :) |
version 11: Added screenshot of bounding of visible windows test comming soon, give some time :) 2011/5/27 Gastón Dall' Oglio <[hidden email]>
|
2011/5/27 Gastón Dall' Oglio <[hidden email]>
No problem. Tell me when it's ready I will check & merge.
Laurent.
|
Well, I coded 2 test, that's something: (
Laurent, at this point both my changes in your work must be something heavy to do, but the less load my package in a clean image to see the idea of keeping the UserTiles:) Thanks ;) 2011/5/27 laurent laffont <[hidden email]>
|
Hi,
TilingWM class>>numberOfLastUsedWindows was returning a boolean instead of a number. therefore i submitted a fix with a small test could you check it? the idea is awesome!! 2011/5/27 Gastón Dall' Oglio <[hidden email]> Well, I coded 2 test, that's something: ( |
Thanks a lot Bernardo.
Laurent. On Sat, May 28, 2011 at 2:38 AM, Bernardo Ezequiel Contreras <[hidden email]> wrote: Hi, |
In reply to this post by Gastón Dall' Oglio
2011/5/28 Gastón Dall' Oglio <[hidden email]> Well, I coded 2 test, that's something: ( OK Gastón I see the functionality. I will merge and refactor as I have some ideas on it (maybe tomorrow I will be busy today). Thanks a lot for the tests !!!
Laurent.
|
Thanks. If there are more ideas and I can encode (and test:), I will send them to you.
2011/5/28 laurent laffont <[hidden email]>
|
Free forum by Nabble | Edit this page |