Tiny patch for RFB
Locked
 
|
I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open to fail in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the reference to a missing class, EmptyArray, with Array empty. Seems to have solved the problem. Is there a preferred way to submit this change so that the repository on SqueakSource gets updated?
'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August 2015 at 1:25:32 am'! !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! add: label get: getBlock set: setBlock help: helpString "Add a new updating item with the given label and balloon helpString. The getBlock provides a Boolean with which the <yes>/<no> prefix for the label is retrieved. If the item is selected then setBlock is invoked." (self addUpdating: #getLabel: target: setBlock selector: #value argumentList: Array empty) wordingProvider: self wordingSelector: #getLabel:; wordingArgument: (Array with: getBlock with: label). self balloonTextForLastItem: helpString! ! |
|
|
On Sun, Aug 16, 2015 at 06:44:53PM -0700, Patrick Shouse wrote:
> I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open to fail > in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the > reference to a missing class, EmptyArray, with Array empty. Seems to have > solved the problem. Is there a preferred way to submit this change so that > the repository on SqueakSource gets updated? Hi Patrick, Checking the RFB project on www.squeaksource.com, the project is owned by Ian Piumarta (author of the package). You can send the change to Ian (CCed on this), or ask him if he would like to add you or someone else as an additional developer on the project. Your fix looks good to me. Thanks, Dave > > 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August 2015 > at 1:25:32 am'! > > !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! > add: label get: getBlock set: setBlock help: helpString > "Add a new updating item with the given label and balloon helpString. The > getBlock provides a Boolean with which the <yes>/<no> prefix for the label > is retrieved. If the item is selected then setBlock is invoked." > > (self addUpdating: #getLabel: target: setBlock selector: #value > argumentList: Array empty) > wordingProvider: self > wordingSelector: #getLabel:; > wordingArgument: (Array with: getBlock with: label). > self balloonTextForLastItem: helpString! ! > > > > -- > View this message in context: http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html > Sent from the Squeak - Dev mailing list archive at Nabble.com. |
|
|
In reply to this post by Patrick Shouse
I've fixed this bug a while ago in "my branch", but it has some other
changes which may not be useful for everyone. You can find the latest version here: http://leves.web.elte.hu/squeak/RFB-ul.11.mcz Levente On Sun, 16 Aug 2015, Patrick Shouse wrote: > I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open to fail > in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the > reference to a missing class, EmptyArray, with Array empty. Seems to have > solved the problem. Is there a preferred way to submit this change so that > the repository on SqueakSource gets updated? > > 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August 2015 > at 1:25:32 am'! > > !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! > add: label get: getBlock set: setBlock help: helpString > "Add a new updating item with the given label and balloon helpString. The > getBlock provides a Boolean with which the <yes>/<no> prefix for the label > is retrieved. If the item is selected then setBlock is invoked." > > (self addUpdating: #getLabel: target: setBlock selector: #value > argumentList: Array empty) > wordingProvider: self > wordingSelector: #getLabel:; > wordingArgument: (Array with: getBlock with: label). > self balloonTextForLastItem: helpString! ! > > > > -- > View this message in context: http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html > Sent from the Squeak - Dev mailing list archive at Nabble.com. > > |
|
|
I, too, fixed this a while ago as well as a couple of other
improvements. Since RFB is now needed by the updated SqueakSource package at http://source.squeak.org/ss, and none of the original authors RFB are active in the community, continued development on RFB should continue there. Please find my improved versions of RFB with that fix there. Levente, what other improvements did you make? We may want to integrate them? - Chris On Mon, Aug 17, 2015 at 7:15 AM, Levente Uzonyi <[hidden email]> wrote: > I've fixed this bug a while ago in "my branch", but it has some other > changes which may not be useful for everyone. You can find the latest > version here: http://leves.web.elte.hu/squeak/RFB-ul.11.mcz > > Levente > > > On Sun, 16 Aug 2015, Patrick Shouse wrote: > >> I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open to >> fail >> in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the >> reference to a missing class, EmptyArray, with Array empty. Seems to have >> solved the problem. Is there a preferred way to submit this change so that >> the repository on SqueakSource gets updated? >> >> 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August >> 2015 >> at 1:25:32 am'! >> >> !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! >> add: label get: getBlock set: setBlock help: helpString >> "Add a new updating item with the given label and balloon >> helpString. The >> getBlock provides a Boolean with which the <yes>/<no> prefix for the label >> is retrieved. If the item is selected then setBlock is invoked." >> >> (self addUpdating: #getLabel: target: setBlock selector: #value >> argumentList: Array empty) >> wordingProvider: self >> wordingSelector: #getLabel:; >> wordingArgument: (Array with: getBlock with: label). >> self balloonTextForLastItem: helpString! ! >> >> >> >> -- >> View this message in context: >> http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html >> Sent from the Squeak - Dev mailing list archive at Nabble.com. >> >> > |
|
|
As a matter of protocol and of common courtesy, please ask the author of
the package how he prefers to handle this. Dave > I, too, fixed this a while ago as well as a couple of other > improvements. Since RFB is now needed by the updated SqueakSource > package at http://source.squeak.org/ss, and none of the original > authors RFB are active in the community, continued development on RFB > should continue there. Please find my improved versions of RFB with > that fix there. > > Levente, what other improvements did you make? We may want to integrate > them? > > - Chris > > On Mon, Aug 17, 2015 at 7:15 AM, Levente Uzonyi <[hidden email]> wrote: >> I've fixed this bug a while ago in "my branch", but it has some other >> changes which may not be useful for everyone. You can find the latest >> version here: http://leves.web.elte.hu/squeak/RFB-ul.11.mcz >> >> Levente >> >> >> On Sun, 16 Aug 2015, Patrick Shouse wrote: >> >>> I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open >>> to >>> fail >>> in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the >>> reference to a missing class, EmptyArray, with Array empty. Seems to >>> have >>> solved the problem. Is there a preferred way to submit this change so >>> that >>> the repository on SqueakSource gets updated? >>> >>> 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August >>> 2015 >>> at 1:25:32 am'! >>> >>> !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! >>> add: label get: getBlock set: setBlock help: helpString >>> "Add a new updating item with the given label and balloon >>> helpString. The >>> getBlock provides a Boolean with which the <yes>/<no> prefix for the >>> label >>> is retrieved. If the item is selected then setBlock is invoked." >>> >>> (self addUpdating: #getLabel: target: setBlock selector: #value >>> argumentList: Array empty) >>> wordingProvider: self >>> wordingSelector: #getLabel:; >>> wordingArgument: (Array with: getBlock with: label). >>> self balloonTextForLastItem: helpString! ! >>> >>> >>> >>> -- >>> View this message in context: >>> http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html >>> Sent from the Squeak - Dev mailing list archive at Nabble.com. >>> >>> >> > |
|
|
The system (SqueakSource) does not provide any way to contact the
original author (no email information), but you said you've already done that anyway, ("cc'd on this" you said). Since Ian has not been visible in the community for a long time, I do not feel I'm being discourteous. How long do you want to wait for a reply before proceeding with further development needed by today's community? On Mon, Aug 17, 2015 at 9:58 AM, David T. Lewis <[hidden email]> wrote: > As a matter of protocol and of common courtesy, please ask the author of > the package how he prefers to handle this. > > Dave > >> I, too, fixed this a while ago as well as a couple of other >> improvements. Since RFB is now needed by the updated SqueakSource >> package at http://source.squeak.org/ss, and none of the original >> authors RFB are active in the community, continued development on RFB >> should continue there. Please find my improved versions of RFB with >> that fix there. >> >> Levente, what other improvements did you make? We may want to integrate >> them? >> >> - Chris >> >> On Mon, Aug 17, 2015 at 7:15 AM, Levente Uzonyi <[hidden email]> wrote: >>> I've fixed this bug a while ago in "my branch", but it has some other >>> changes which may not be useful for everyone. You can find the latest >>> version here: http://leves.web.elte.hu/squeak/RFB-ul.11.mcz >>> >>> Levente >>> >>> >>> On Sun, 16 Aug 2015, Patrick Shouse wrote: >>> >>>> I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open >>>> to >>>> fail >>>> in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the >>>> reference to a missing class, EmptyArray, with Array empty. Seems to >>>> have >>>> solved the problem. Is there a preferred way to submit this change so >>>> that >>>> the repository on SqueakSource gets updated? >>>> >>>> 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August >>>> 2015 >>>> at 1:25:32 am'! >>>> >>>> !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! >>>> add: label get: getBlock set: setBlock help: helpString >>>> "Add a new updating item with the given label and balloon >>>> helpString. The >>>> getBlock provides a Boolean with which the <yes>/<no> prefix for the >>>> label >>>> is retrieved. If the item is selected then setBlock is invoked." >>>> >>>> (self addUpdating: #getLabel: target: setBlock selector: #value >>>> argumentList: Array empty) >>>> wordingProvider: self >>>> wordingSelector: #getLabel:; >>>> wordingArgument: (Array with: getBlock with: label). >>>> self balloonTextForLastItem: helpString! ! >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html >>>> Sent from the Squeak - Dev mailing list archive at Nabble.com. >>>> >>>> >>> >> > > > |
|
|
Try piumarta at gmail dot com
Dave > The system (SqueakSource) does not provide any way to contact the > original author (no email information), but you said you've already > done that anyway, ("cc'd on this" you said). Since Ian has not been > visible in the community for a long time, I do not feel I'm being > discourteous. How long do you want to wait for a reply before > proceeding with further development needed by today's community? > > > On Mon, Aug 17, 2015 at 9:58 AM, David T. Lewis <[hidden email]> > wrote: >> As a matter of protocol and of common courtesy, please ask the author of >> the package how he prefers to handle this. >> >> Dave >> >>> I, too, fixed this a while ago as well as a couple of other >>> improvements. Since RFB is now needed by the updated SqueakSource >>> package at http://source.squeak.org/ss, and none of the original >>> authors RFB are active in the community, continued development on RFB >>> should continue there. Please find my improved versions of RFB with >>> that fix there. >>> >>> Levente, what other improvements did you make? We may want to >>> integrate >>> them? >>> >>> - Chris >>> >>> On Mon, Aug 17, 2015 at 7:15 AM, Levente Uzonyi <[hidden email]> wrote: >>>> I've fixed this bug a while ago in "my branch", but it has some other >>>> changes which may not be useful for everyone. You can find the latest >>>> version here: http://leves.web.elte.hu/squeak/RFB-ul.11.mcz >>>> >>>> Levente >>>> >>>> >>>> On Sun, 16 Aug 2015, Patrick Shouse wrote: >>>> >>>>> I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open >>>>> to >>>>> fail >>>>> in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the >>>>> reference to a missing class, EmptyArray, with Array empty. Seems to >>>>> have >>>>> solved the problem. Is there a preferred way to submit this change so >>>>> that >>>>> the repository on SqueakSource gets updated? >>>>> >>>>> 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 >>>>> August >>>>> 2015 >>>>> at 1:25:32 am'! >>>>> >>>>> !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 >>>>> 00:28'! >>>>> add: label get: getBlock set: setBlock help: helpString >>>>> "Add a new updating item with the given label and balloon >>>>> helpString. The >>>>> getBlock provides a Boolean with which the <yes>/<no> prefix for the >>>>> label >>>>> is retrieved. If the item is selected then setBlock is invoked." >>>>> >>>>> (self addUpdating: #getLabel: target: setBlock selector: >>>>> #value >>>>> argumentList: Array empty) >>>>> wordingProvider: self >>>>> wordingSelector: #getLabel:; >>>>> wordingArgument: (Array with: getBlock with: label). >>>>> self balloonTextForLastItem: helpString! ! >>>>> >>>>> >>>>> >>>>> -- >>>>> View this message in context: >>>>> http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html >>>>> Sent from the Squeak - Dev mailing list archive at Nabble.com. >>>>> >>>>> >>>> >>> >> >> >> > |
|
|
In reply to this post by Chris Muller-3
Hi Chris,
Most changes are related to server-side key decoding (see RFBSession >> #decodeKey:). I've added support for 8-bit ASCII, Unicode and all legacy X11R7 keysyms. With these changes you can enter accented characters to the image over RFB. If your client has Unicode support (I haven't seen such client yet), then you can enter any Unicode character. Levente On Mon, 17 Aug 2015, Chris Muller wrote: > I, too, fixed this a while ago as well as a couple of other > improvements. Since RFB is now needed by the updated SqueakSource > package at http://source.squeak.org/ss, and none of the original > authors RFB are active in the community, continued development on RFB > should continue there. Please find my improved versions of RFB with > that fix there. > > Levente, what other improvements did you make? We may want to integrate them? > > - Chris > > On Mon, Aug 17, 2015 at 7:15 AM, Levente Uzonyi <[hidden email]> wrote: >> I've fixed this bug a while ago in "my branch", but it has some other >> changes which may not be useful for everyone. You can find the latest >> version here: http://leves.web.elte.hu/squeak/RFB-ul.11.mcz >> >> Levente >> >> >> On Sun, 16 Aug 2015, Patrick Shouse wrote: >> >>> I've fixed a tiny bug in RFBMenuMorph that was causing RFBServer open to >>> fail >>> in an up-to-date Squeak-5.0-All-in-One image. I simply replaced the >>> reference to a missing class, EmptyArray, with Array empty. Seems to have >>> solved the problem. Is there a preferred way to submit this change so that >>> the repository on SqueakSource gets updated? >>> >>> 'From Squeak5.0 of 14 August 2015 [latest update: #15135] on 17 August >>> 2015 >>> at 1:25:32 am'! >>> >>> !RFBMenuMorph methodsFor: 'construction' stamp: 'pls 8/17/2015 00:28'! >>> add: label get: getBlock set: setBlock help: helpString >>> "Add a new updating item with the given label and balloon >>> helpString. The >>> getBlock provides a Boolean with which the <yes>/<no> prefix for the label >>> is retrieved. If the item is selected then setBlock is invoked." >>> >>> (self addUpdating: #getLabel: target: setBlock selector: #value >>> argumentList: Array empty) >>> wordingProvider: self >>> wordingSelector: #getLabel:; >>> wordingArgument: (Array with: getBlock with: label). >>> self balloonTextForLastItem: helpString! ! >>> >>> >>> >>> -- >>> View this message in context: >>> http://forum.world.st/Tiny-patch-for-RFB-tp4843388.html >>> Sent from the Squeak - Dev mailing list archive at Nabble.com. >>> >>> >> > > |
«
Return to Squeak - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |