To the Point

Hello,

----------------------------------------

PL3 fixed Point>>=, but Point3D>>= is still incorrect:

0=(0@0@0) "true"
(0@0@0)=0 "false"

----------------------------------------

There is some inconsistency here:

(1@-1) abs "1@-1"
(1@-1@0) abs "1@1@0"

----------------------------------------

and here:

Point new "0@0"
Point3D new "nil@nil@nil

----------------------------------------

Point3D should probably implement #asPoint.

----------------------------------------

Point3D class>>publishedAspectsOfInstances is missing
(it used to be there).

----------------------------------------

I may be misremembering things, but weren't Point>>printOn:
and Point3D>>printOn: printing parens around textual
representation of a point ? If not, they probably should.

Now that I think about it, so should Association>>printOn:
and maybe even Rectangle>>printOn: and Interval>>printOn:.

----------------------------------------

Related to the one above - inspecting:

0 to: 0@0

walkbacks. I wouldn't report that but, since
SequenceableCollectionInspector>>getFieldList does have some
code which is supposed to catch other cases of invalid
collections, it could deal with this one as well.

----------------------------------------

This has nothing to do with points, but I'll put it in
here anyway. StdioFileStream>>nextPut: doesn't return it's
argument, so String>>printOn: won't work correctly on it.

It's not the first time there is a problem with String>>printOn:
so I think it would be best to rewrite it so it doesn't use
the result of #nextPut:.

----------------------------------------

Artur Zaroda
[hidden email]

Artur

You wrote in message
news:[hidden email]...
Noted as defects 271 through 275, and fixed for the next patch or release.

> I may be misremembering things, but weren't Point>>printOn:
> and Point3D>>printOn: printing parens around textual
> representation of a point ? If not, they probably should.

I would tend to agree, but that has not traditionally been the case.

> Now that I think about it, so should Association>>printOn:
> and maybe even Rectangle>>printOn: and Interval>>printOn:.

Ditto, except that I note Intervals are bracketed in VW and Squeak so that
was probably the case in St-80 (recorded as defect 277, fixed for next
release).

I'm not sure about that one, but nevertheless recorded as defect 276.

> ----------------------------------------
>
> This has nothing to do with points, but I'll put it in
> here anyway. StdioFileStream>>nextPut: doesn't return it's
> argument, so String>>printOn: won't work correctly on it.

Recorded as defect 278 and fixed for the next release.

Thanks for your continuing detailed bug reports.

Regards

Blair