Typo fix in src

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Typo fix in src

aa72
 
Please bear with me as I don't yet know how to work with/submit changes to generated code, so for now here's a teeny typo fix.


Stu


Patch:

Index: src/plugins/ImmX11Plugin/ImmX11Plugin.c
--- src/plugins/ImmX11Plugin/ImmX11Plugin.c.orig
+++ src/plugins/ImmX11Plugin/ImmX11Plugin.c
@@ -34,7 +34,7 @@ static char __buildInfo[] = "ImmX11Plugin VMMaker.osco
 #include "sqUnixCharConv.h"
 extern char *setLocale(char *, size_t);
 extern int setCompositionWindowPosition(int, int);
-extern int setCompostionFocus(int);
+extern int setCompositionFocus(int);
 #include "sqMemoryAccess.h"
 

A changeset that I fileOut'd:

'From Squeak6.0alpha of 21 December 2017 [latest update: #17606] on 7 January 2018 at 9:13:34 am'!

!ImmX11Plugin class methodsFor: 'as yet unclassified' stamp: 'sc 1/7/2018 09:12'!
declareHeaderFilesIn: cg

        cg addHeaderFile: '<locale.h>'.
        cg addHeaderFile: '"sqUnixMain.h"'.
        cg addHeaderFile: '"sqUnixCharConv.h"', Character cr asString,
                'extern char *setLocale(char *, size_t);', Character cr asString,
                'extern int setCompositionWindowPosition(int, int);', Character cr asString,
                'extern int setCompositionFocus(int);'.! !
Reply | Threaded
Open this post in threaded view
|

Re: Typo fix in src

David T. Lewis
 
On Sun, Jan 07, 2018 at 09:44:05AM -0500, Stuart Cassoff wrote:
>  
> Please bear with me as I don't yet know how to work with/submit changes to generated code, so for now here's a teeny typo fix.
>
>
> Stu

Stu,

Good catch!

Do you have a VMMaker image handy? (If not, look opensmalltalk-vm/image in your
git folder). Take a look at ImmX11Plugin class>>declareHeaderFilesIn: and you
will see the Smalltalk source code with the typo that you have identified.

The fix will be to make the correction in this method. The change will be
committed to the VMMaker repository, and the generated sources will be
committed to GitHub.

Dave


>
>
> Patch:
>
> Index: src/plugins/ImmX11Plugin/ImmX11Plugin.c
> --- src/plugins/ImmX11Plugin/ImmX11Plugin.c.orig
> +++ src/plugins/ImmX11Plugin/ImmX11Plugin.c
> @@ -34,7 +34,7 @@ static char __buildInfo[] = "ImmX11Plugin VMMaker.osco
>  #include "sqUnixCharConv.h"
>  extern char *setLocale(char *, size_t);
>  extern int setCompositionWindowPosition(int, int);
> -extern int setCompostionFocus(int);
> +extern int setCompositionFocus(int);
>  #include "sqMemoryAccess.h"
>  
>
> A changeset that I fileOut'd:
>
> 'From Squeak6.0alpha of 21 December 2017 [latest update: #17606] on 7 January 2018 at 9:13:34 am'!
>
> !ImmX11Plugin class methodsFor: 'as yet unclassified' stamp: 'sc 1/7/2018 09:12'!
> declareHeaderFilesIn: cg
>
>         cg addHeaderFile: '<locale.h>'.
>         cg addHeaderFile: '"sqUnixMain.h"'.
>         cg addHeaderFile: '"sqUnixCharConv.h"', Character cr asString,
>                 'extern char *setLocale(char *, size_t);', Character cr asString,
>                 'extern int setCompositionWindowPosition(int, int);', Character cr asString,
>                 'extern int setCompositionFocus(int);'.! !
Reply | Threaded
Open this post in threaded view
|

Re: Typo fix in src

David T. Lewis
 
Stu,

I added your fix to VMMaker. I don't have time to follow up on the code generation
right now, but the next time someone generates sources your fix should be included.

Dave


On Sun, Jan 07, 2018 at 11:04:23AM -0500, David T. Lewis wrote:

> On Sun, Jan 07, 2018 at 09:44:05AM -0500, Stuart Cassoff wrote:
> >  
> > Please bear with me as I don't yet know how to work with/submit changes to generated code, so for now here's a teeny typo fix.
> >
> >
> > Stu
>
> Stu,
>
> Good catch!
>
> Do you have a VMMaker image handy? (If not, look opensmalltalk-vm/image in your
> git folder). Take a look at ImmX11Plugin class>>declareHeaderFilesIn: and you
> will see the Smalltalk source code with the typo that you have identified.
>
> The fix will be to make the correction in this method. The change will be
> committed to the VMMaker repository, and the generated sources will be
> committed to GitHub.
>
> Dave
>
>
> >
> >
> > Patch:
> >
> > Index: src/plugins/ImmX11Plugin/ImmX11Plugin.c
> > --- src/plugins/ImmX11Plugin/ImmX11Plugin.c.orig
> > +++ src/plugins/ImmX11Plugin/ImmX11Plugin.c
> > @@ -34,7 +34,7 @@ static char __buildInfo[] = "ImmX11Plugin VMMaker.osco
> >  #include "sqUnixCharConv.h"
> >  extern char *setLocale(char *, size_t);
> >  extern int setCompositionWindowPosition(int, int);
> > -extern int setCompostionFocus(int);
> > +extern int setCompositionFocus(int);
> >  #include "sqMemoryAccess.h"
> >  
> >
> > A changeset that I fileOut'd:
> >
> > 'From Squeak6.0alpha of 21 December 2017 [latest update: #17606] on 7 January 2018 at 9:13:34 am'!
> >
> > !ImmX11Plugin class methodsFor: 'as yet unclassified' stamp: 'sc 1/7/2018 09:12'!
> > declareHeaderFilesIn: cg
> >
> >         cg addHeaderFile: '<locale.h>'.
> >         cg addHeaderFile: '"sqUnixMain.h"'.
> >         cg addHeaderFile: '"sqUnixCharConv.h"', Character cr asString,
> >                 'extern char *setLocale(char *, size_t);', Character cr asString,
> >                 'extern int setCompositionWindowPosition(int, int);', Character cr asString,
> >                 'extern int setCompositionFocus(int);'.! !
Reply | Threaded
Open this post in threaded view
|

Re: Typo fix in src

aa72
 
Great, thanks!

> ---------- Original Message ----------
> From: "David T. Lewis" <[hidden email]>
> Date: January 7, 2018 at 1:23 PM
>
>
> Stu,
>
> I added your fix to VMMaker. I don't have time to follow up on the code generation
> right now, but the next time someone generates sources your fix should be included.
>
> Dave
>
>
> On Sun, Jan 07, 2018 at 11:04:23AM -0500, David T. Lewis wrote:
> > On Sun, Jan 07, 2018 at 09:44:05AM -0500, Stuart Cassoff wrote:
> > >  
> > > Please bear with me as I don't yet know how to work with/submit changes to generated code, so for now here's a teeny typo fix.
> > >
> > >
> > > Stu
> >
> > Stu,
> >
> > Good catch!
> >
> > Do you have a VMMaker image handy? (If not, look opensmalltalk-vm/image in your
> > git folder). Take a look at ImmX11Plugin class>>declareHeaderFilesIn: and you
> > will see the Smalltalk source code with the typo that you have identified.
> >
> > The fix will be to make the correction in this method. The change will be
> > committed to the VMMaker repository, and the generated sources will be
> > committed to GitHub.
> >
> > Dave
> >
> >
> > >
> > >
> > > Patch:
> > >
> > > Index: src/plugins/ImmX11Plugin/ImmX11Plugin.c
> > > --- src/plugins/ImmX11Plugin/ImmX11Plugin.c.orig
> > > +++ src/plugins/ImmX11Plugin/ImmX11Plugin.c
> > > @@ -34,7 +34,7 @@ static char __buildInfo[] = "ImmX11Plugin VMMaker.osco
> > >  #include "sqUnixCharConv.h"
> > >  extern char *setLocale(char *, size_t);
> > >  extern int setCompositionWindowPosition(int, int);
> > > -extern int setCompostionFocus(int);
> > > +extern int setCompositionFocus(int);
> > >  #include "sqMemoryAccess.h"
> > >  
> > >
> > > A changeset that I fileOut'd:
> > >
> > > 'From Squeak6.0alpha of 21 December 2017 [latest update: #17606] on 7 January 2018 at 9:13:34 am'!
> > >
> > > !ImmX11Plugin class methodsFor: 'as yet unclassified' stamp: 'sc 1/7/2018 09:12'!
> > > declareHeaderFilesIn: cg
> > >
> > >         cg addHeaderFile: '<locale.h>'.
> > >         cg addHeaderFile: '"sqUnixMain.h"'.
> > >         cg addHeaderFile: '"sqUnixCharConv.h"', Character cr asString,
> > >                 'extern char *setLocale(char *, size_t);', Character cr asString,
> > >                 'extern int setCompositionWindowPosition(int, int);', Character cr asString,
> > >                 'extern int setCompositionFocus(int);'.! !