UML shape broken

> Hi,
> i just notice that the UML Class shape is broken, going back in the  
> history seems that the problem has been introduced from  the  
> relative coordinates.
>
> This screen shot is from the commit Mondrian-tg.540
> <Mondrian-tg.540.png>
>
> This from the commit Mondrian-Alexandre_Bergel.540
> <Mondrian-Alexandre_Bergel.540.png>
>
> Than staring from the commit Mondrian-AlexandreBergel.545 the class  
> name disappear i think covered by the rectangle containing the  
> methods name that is bigger than before.
>
> <Mondrian-AlexandreBergel.545.png>
> The problem is in the method MOShapeSelector>>umlClass that has not  
> been updated considering the last changes or in the changes  
> themselves?
>
> Fabrizio_______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

> Hi,
> i just notice that the UML Class shape is broken, going back in the history seems that the problem has been introduced from  the relative coordinates.
>
> This screen shot is from the commit Mondrian-tg.540
> <Mondrian-tg.540.png>
>
> This from the commit Mondrian-Alexandre_Bergel.540
> <Mondrian-Alexandre_Bergel.540.png>
>
> Than staring from the commit Mondrian-AlexandreBergel.545 the class name disappear i think covered by the rectangle containing the methods name that is bigger than before.
>
> <Mondrian-AlexandreBergel.545.png>
> The problem is in the method MOShapeSelector>>umlClass that has not been updated considering the last changes or in the changes themselves?
>
> Fabrizio_______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

> sorry i did not finish the answer:
>
> the problem on more than one class is that the rectangles seem  
> aligned:
>
> <moreThanOne.png>
> i don't know if this is an expected behaviour or not. Anyway i can  
> encapsulate all the classes in a bigger rectangle without border to  
> keep everything togheter.
>
> cheerrs,
>
> Fabrizio
>
> Begin forwarded message:
>
>> From: Fabrizio Perin <[hidden email]>
>> Date: 1 September 2010 12:07:53 CEST
>> To: Moose-related development <[hidden email]>
>> Subject: Re: [Moose-dev] Re: UML shape broken
>>
>> Hi Alex,
>> thanks a lot for the quick answer. The umlClass is now fix but i  
>> still have some problem with my stuff:
>> Using this script:
>>
>> | builder |
>> builder := MOFormsBuilder new.
>> builder column; fill.
>> builder row; fill; row; fill; row; fill.
>> builder x: 1 y: 1 add: ((MORectangleShape new withText) text:  
>> [ :cls | cls name ]; fontSize: 10; textPadding: 2; textAlignment:  
>> #center).
>> builder x: 1 y: 2 add: (MORectangleShape new text: [ :cls |
>> cls attributes asArray inject: '' into: [ :sum :el | sum , el  
>> name , String cr ] ]; fontSize: 6; textVerticalPadding: 2;  
>> textAlignment: #left).
>> builder x: 1 y: 3 add: (MORectangleShape new text: [ :cls |
>> cls methods asArray inject: '' into: [ :sum :el | sum , el name ,  
>> String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment:  
>> #left).
>> ^ view shape: builder shape
>>
>> that basically visualized not only the methods but also the  
>> attributes of the class i have the following results:
>>
>> on a single the result is perfect
>>
>> <singleClass.png>
>>
>> Thanks,
>>
>> Fabrizio
>>
>> On 31 Aug 2010, at 21:09, Alexandre Bergel wrote:
>>
>>> Hi Lorenzo,
>>>
>>> Please, try with Mondrian-AlexandreBergel.550
>>> UML Shape should work now.
>>>
>>> Cheers,
>>> Alexandre
>>>
>>>
>>> On 31 Aug 2010, at 05:18, Fabrizio Perin wrote:
>>>
>>>> Hi,
>>>> i just notice that the UML Class shape is broken, going back in  
>>>> the history seems that the problem has been introduced from  the  
>>>> relative coordinates.
>>>>
>>>> This screen shot is from the commit Mondrian-tg.540
>>>> <Mondrian-tg.540.png>
>>>>
>>>> This from the commit Mondrian-Alexandre_Bergel.540
>>>> <Mondrian-Alexandre_Bergel.540.png>
>>>>
>>>> Than staring from the commit Mondrian-AlexandreBergel.545 the  
>>>> class name disappear i think covered by the rectangle containing  
>>>> the methods name that is bigger than before.
>>>>
>>>> <Mondrian-AlexandreBergel.545.png>
>>>> The problem is in the method MOShapeSelector>>umlClass that has  
>>>> not been updated considering the last changes or in the changes  
>>>> themselves?
>>>>
>>>> Fabrizio_______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> --
>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>> Alexandre Bergel  http://www.bergel.eu
>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

> This is really strange. I can reproduce it in a more general case:
>
> | builder |
> builder := MOFormsBuilder new.
> builder column; fill.
> builder row; fill; row; fill; row; fill.
> builder x: 1 y: 1 add: (MORectangleShape new text: [ :x | (1 to: x) inject: '' into: [ :sum :el | sum , el printString , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
> builder x: 1 y: 2 add: (MORectangleShape new text: [ :x | (1 to: x) inject: '' into: [ :sum :el | sum , el printString , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
> builder x: 1 y: 3 add: (MORectangleShape new text: [ :x | (1 to: x) inject: '' into: [ :sum :el | sum , el printString , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
> view shape: builder shape.
> view nodes: (1 to: 5)
>
> Alex, this looks like there is a problem in the forms builder that somehow shares the alignment information.
>
> For a variation of what I believe is a similar problem, please open the same shape with the following nodes:
> view nodes: (1 to: 5) reversed
>
> Fabrizio, please open a ticket with these snippets.
>
> Cheers,
> Doru
>
>
> On 1 Sep 2010, at 12:11, Fabrizio Perin wrote:
>
>> sorry i did not finish the answer:
>>
>> the problem on more than one class is that the rectangles seem aligned:
>>
>> <moreThanOne.png>
>> i don't know if this is an expected behaviour or not. Anyway i can encapsulate all the classes in a bigger rectangle without border to keep everything togheter.
>>
>> cheerrs,
>>
>> Fabrizio
>>
>> Begin forwarded message:
>>
>>> From: Fabrizio Perin <[hidden email]>
>>> Date: 1 September 2010 12:07:53 CEST
>>> To: Moose-related development <[hidden email]>
>>> Subject: Re: [Moose-dev] Re: UML shape broken
>>>
>>> Hi Alex,
>>> thanks a lot for the quick answer. The umlClass is now fix but i still have some problem with my stuff:
>>> Using this script:
>>>
>>> | builder |
>>> builder := MOFormsBuilder new.
>>> builder column; fill.
>>> builder row; fill; row; fill; row; fill.
>>> builder x: 1 y: 1 add: ((MORectangleShape new withText) text: [ :cls | cls name ]; fontSize: 10; textPadding: 2; textAlignment: #center).
>>> builder x: 1 y: 2 add: (MORectangleShape new text: [ :cls |
>>> cls attributes asArray inject: '' into: [ :sum :el | sum , el name , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>>> builder x: 1 y: 3 add: (MORectangleShape new text: [ :cls |
>>> cls methods asArray inject: '' into: [ :sum :el | sum , el name , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>>> ^ view shape: builder shape
>>>
>>> that basically visualized not only the methods but also the attributes of the class i have the following results:
>>>
>>> on a single the result is perfect
>>>
>>> <singleClass.png>
>>>
>>> Thanks,
>>>
>>> Fabrizio
>>>
>>> On 31 Aug 2010, at 21:09, Alexandre Bergel wrote:
>>>
>>>> Hi Lorenzo,
>>>>
>>>> Please, try with Mondrian-AlexandreBergel.550
>>>> UML Shape should work now.
>>>>
>>>> Cheers,
>>>> Alexandre
>>>>
>>>>
>>>> On 31 Aug 2010, at 05:18, Fabrizio Perin wrote:
>>>>
>>>>> Hi,
>>>>> i just notice that the UML Class shape is broken, going back in the history seems that the problem has been introduced from  the relative coordinates.
>>>>>
>>>>> This screen shot is from the commit Mondrian-tg.540
>>>>> <Mondrian-tg.540.png>
>>>>>
>>>>> This from the commit Mondrian-Alexandre_Bergel.540
>>>>> <Mondrian-Alexandre_Bergel.540.png>
>>>>>
>>>>> Than staring from the commit Mondrian-AlexandreBergel.545 the class name disappear i think covered by the rectangle containing the methods name that is bigger than before.
>>>>>
>>>>> <Mondrian-AlexandreBergel.545.png>
>>>>> The problem is in the method MOShapeSelector>>umlClass that has not been updated considering the last changes or in the changes themselves?
>>>>>
>>>>> Fabrizio_______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel  http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Sometimes the best solution is not the best solution."
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

> done
>
> http://code.google.com/p/moose-technology/issues/detail?id=446
>
> On 1 Sep 2010, at 16:18, Tudor Girba wrote:
>
>> This is really strange. I can reproduce it in a more general case:
>>
>> | builder |
>> builder := MOFormsBuilder new.
>> builder column; fill.
>> builder row; fill; row; fill; row; fill.
>> builder x: 1 y: 1 add: (MORectangleShape new text: [ :x | (1 to: x)  
>> inject: '' into: [ :sum :el | sum , el printString , String cr ] ];  
>> fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>> builder x: 1 y: 2 add: (MORectangleShape new text: [ :x | (1 to: x)  
>> inject: '' into: [ :sum :el | sum , el printString , String cr ] ];  
>> fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>> builder x: 1 y: 3 add: (MORectangleShape new text: [ :x | (1 to: x)  
>> inject: '' into: [ :sum :el | sum , el printString , String cr ] ];  
>> fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>> view shape: builder shape.
>> view nodes: (1 to: 5)
>>
>> Alex, this looks like there is a problem in the forms builder that  
>> somehow shares the alignment information.
>>
>> For a variation of what I believe is a similar problem, please open  
>> the same shape with the following nodes:
>> view nodes: (1 to: 5) reversed
>>
>> Fabrizio, please open a ticket with these snippets.
>>
>> Cheers,
>> Doru
>>
>>
>> On 1 Sep 2010, at 12:11, Fabrizio Perin wrote:
>>
>>> sorry i did not finish the answer:
>>>
>>> the problem on more than one class is that the rectangles seem  
>>> aligned:
>>>
>>> <moreThanOne.png>
>>> i don't know if this is an expected behaviour or not. Anyway i can  
>>> encapsulate all the classes in a bigger rectangle without border  
>>> to keep everything togheter.
>>>
>>> cheerrs,
>>>
>>> Fabrizio
>>>
>>> Begin forwarded message:
>>>
>>>> From: Fabrizio Perin <[hidden email]>
>>>> Date: 1 September 2010 12:07:53 CEST
>>>> To: Moose-related development <[hidden email]>
>>>> Subject: Re: [Moose-dev] Re: UML shape broken
>>>>
>>>> Hi Alex,
>>>> thanks a lot for the quick answer. The umlClass is now fix but i  
>>>> still have some problem with my stuff:
>>>> Using this script:
>>>>
>>>> | builder |
>>>> builder := MOFormsBuilder new.
>>>> builder column; fill.
>>>> builder row; fill; row; fill; row; fill.
>>>> builder x: 1 y: 1 add: ((MORectangleShape new withText) text:  
>>>> [ :cls | cls name ]; fontSize: 10; textPadding: 2; textAlignment:  
>>>> #center).
>>>> builder x: 1 y: 2 add: (MORectangleShape new text: [ :cls |
>>>> cls attributes asArray inject: '' into: [ :sum :el | sum , el  
>>>> name , String cr ] ]; fontSize: 6; textVerticalPadding: 2;  
>>>> textAlignment: #left).
>>>> builder x: 1 y: 3 add: (MORectangleShape new text: [ :cls |
>>>> cls methods asArray inject: '' into: [ :sum :el | sum , el  
>>>> name , String cr ] ]; fontSize: 6; textVerticalPadding: 2;  
>>>> textAlignment: #left).
>>>> ^ view shape: builder shape
>>>>
>>>> that basically visualized not only the methods but also the  
>>>> attributes of the class i have the following results:
>>>>
>>>> on a single the result is perfect
>>>>
>>>> <singleClass.png>
>>>>
>>>> Thanks,
>>>>
>>>> Fabrizio
>>>>
>>>> On 31 Aug 2010, at 21:09, Alexandre Bergel wrote:
>>>>
>>>>> Hi Lorenzo,
>>>>>
>>>>> Please, try with Mondrian-AlexandreBergel.550
>>>>> UML Shape should work now.
>>>>>
>>>>> Cheers,
>>>>> Alexandre
>>>>>
>>>>>
>>>>> On 31 Aug 2010, at 05:18, Fabrizio Perin wrote:
>>>>>
>>>>>> Hi,
>>>>>> i just notice that the UML Class shape is broken, going back in  
>>>>>> the history seems that the problem has been introduced from  
>>>>>> the relative coordinates.
>>>>>>
>>>>>> This screen shot is from the commit Mondrian-tg.540
>>>>>> <Mondrian-tg.540.png>
>>>>>>
>>>>>> This from the commit Mondrian-Alexandre_Bergel.540
>>>>>> <Mondrian-Alexandre_Bergel.540.png>
>>>>>>
>>>>>> Than staring from the commit Mondrian-AlexandreBergel.545 the  
>>>>>> class name disappear i think covered by the rectangle  
>>>>>> containing the methods name that is bigger than before.
>>>>>>
>>>>>> <Mondrian-AlexandreBergel.545.png>
>>>>>> The problem is in the method MOShapeSelector>>umlClass that has  
>>>>>> not been updated considering the last changes or in the changes  
>>>>>> themselves?
>>>>>>
>>>>>> Fabrizio_______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> --
>>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>>> Alexandre Bergel  http://www.bergel.eu
>>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>> www.tudorgirba.com
>>
>> "Sometimes the best solution is not the best solution."
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

> This is really strange. I can reproduce it in a more general case:
>
> | builder |
> builder := MOFormsBuilder new.
> builder column; fill.
> builder row; fill; row; fill; row; fill.
> builder x: 1 y: 1 add: (MORectangleShape new text: [ :x | (1 to: x) inject: '' into: [ :sum :el | sum , el printString , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
> builder x: 1 y: 2 add: (MORectangleShape new text: [ :x | (1 to: x) inject: '' into: [ :sum :el | sum , el printString , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
> builder x: 1 y: 3 add: (MORectangleShape new text: [ :x | (1 to: x) inject: '' into: [ :sum :el | sum , el printString , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
> view shape: builder shape.
> view nodes: (1 to: 5)
>
> Alex, this looks like there is a problem in the forms builder that somehow shares the alignment information.
>
> For a variation of what I believe is a similar problem, please open the same shape with the following nodes:
> view nodes: (1 to: 5) reversed
>
> Fabrizio, please open a ticket with these snippets.
>
> Cheers,
> Doru
>
>
> On 1 Sep 2010, at 12:11, Fabrizio Perin wrote:
>
>> sorry i did not finish the answer:
>>
>> the problem on more than one class is that the rectangles seem aligned:
>>
>> <moreThanOne.png>
>> i don't know if this is an expected behaviour or not. Anyway i can encapsulate all the classes in a bigger rectangle without border to keep everything togheter.
>>
>> cheerrs,
>>
>> Fabrizio
>>
>> Begin forwarded message:
>>
>>> From: Fabrizio Perin <[hidden email]>
>>> Date: 1 September 2010 12:07:53 CEST
>>> To: Moose-related development <[hidden email]>
>>> Subject: Re: [Moose-dev] Re: UML shape broken
>>>
>>> Hi Alex,
>>> thanks a lot for the quick answer. The umlClass is now fix but i still have some problem with my stuff:
>>> Using this script:
>>>
>>> | builder |
>>> builder := MOFormsBuilder new.
>>> builder column; fill.
>>> builder row; fill; row; fill; row; fill.
>>> builder x: 1 y: 1 add: ((MORectangleShape new withText) text: [ :cls | cls name ]; fontSize: 10; textPadding: 2; textAlignment: #center).
>>> builder x: 1 y: 2 add: (MORectangleShape new text: [ :cls |
>>> cls attributes asArray inject: '' into: [ :sum :el | sum , el name , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>>> builder x: 1 y: 3 add: (MORectangleShape new text: [ :cls |
>>> cls methods asArray inject: '' into: [ :sum :el | sum , el name , String cr ] ]; fontSize: 6; textVerticalPadding: 2; textAlignment: #left).
>>> ^ view shape: builder shape
>>>
>>> that basically visualized not only the methods but also the attributes of the class i have the following results:
>>>
>>> on a single the result is perfect
>>>
>>> <singleClass.png>
>>>
>>> Thanks,
>>>
>>> Fabrizio
>>>
>>> On 31 Aug 2010, at 21:09, Alexandre Bergel wrote:
>>>
>>>> Hi Lorenzo,
>>>>
>>>> Please, try with Mondrian-AlexandreBergel.550
>>>> UML Shape should work now.
>>>>
>>>> Cheers,
>>>> Alexandre
>>>>
>>>>
>>>> On 31 Aug 2010, at 05:18, Fabrizio Perin wrote:
>>>>
>>>>> Hi,
>>>>> i just notice that the UML Class shape is broken, going back in the history seems that the problem has been introduced from  the relative coordinates.
>>>>>
>>>>> This screen shot is from the commit Mondrian-tg.540
>>>>> <Mondrian-tg.540.png>
>>>>>
>>>>> This from the commit Mondrian-Alexandre_Bergel.540
>>>>> <Mondrian-Alexandre_Bergel.540.png>
>>>>>
>>>>> Than staring from the commit Mondrian-AlexandreBergel.545 the class name disappear i think covered by the rectangle containing the methods name that is bigger than before.
>>>>>
>>>>> <Mondrian-AlexandreBergel.545.png>
>>>>> The problem is in the method MOShapeSelector>>umlClass that has not been updated considering the last changes or in the changes themselves?
>>>>>
>>>>> Fabrizio_______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel  http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Sometimes the best solution is not the best solution."
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev