Usability issue with text decoration halo handles

Am 21.05.2018 22:55:22 schrieb Jakob Reschke <[hidden email]>:

Confirmed. If I revert to the previous version cmm 3/30/2018 14:24 of
DialogWindow getUserResponse, the issue does not arise any more.

2018-05-21 22:24 GMT+02:00 karl ramberg :

> Hi,
> Could it be similar issue as PopUpChoiceMorph I reported a while back? That
> is caused by this change
>
> The Trunk: Morphic-mt.1414.mcz
>
> Best,
> Karl
>
> On Mon, May 21, 2018 at 9:13 PM, Jakob Reschke
> wrote:
>>
>> Hello,
>>
>> After using the text emphasis halo handle (the orange one, next to
>> rightmost at the bottom) on a text morph to change the emphasis of
>> selected text, the emphasis selection dialog will appear again on
>> every click, albeit not clicking on the same handle again. In fact, it
>> does not matter where I click: even clicking the world invokes
>> chooseEmphasisOrAlignment on the text again.
>>
>> A workaround is to use the Ctrl+. interrupt. After that, the halo can
>> be dismissed by clicking somewhere else.
>>
>> The same issue also applies to the font style halo handle (the middle
>> one at the bottom), but not to the font size handle (next to leftmost
>> at the bottom). The issue does not show in my Squeak 5.1 image. There,
>> the halo vanishes after selecting the emphasis once.
>>
>> You should be able to reproduce it in a Workspace. Shift+blue click on
>> the text should open the halo on the relevant text morph immediately.
>>
>> Kind regards,
>> Jakob
>>
>> PS. I wanted to use this to apply the struck-out emphasis. Its
>> keyboard shortcut is overridden by the global font size changing
>> actions. If you know another, easier way to strike out text, please
>> tell me. :-)
>>
>
>
>
>

Am 22.05.2018 08:31:57 schrieb Marcel Taeumel <[hidden email]>:

Hi Jakob, hi Karl,

yes, this is related to: http://forum.world.st/PopUpChoiceMorph-borked-tp5074717p5074774.html

I am working on it. The issue is dialog invocation on a #mouseDown event, which concerns mouse focus capturing and restoring. It is a bigger issue that is not specifically related to dialogs or the pop-up choice morph or the halo thing.

Quick workaround: In the Trunk, move any dialog invocations from #mouseDown: to #mouseUp:.

Side effects. Phew. ;-)

Best,

Marcel

Am 21.05.2018 22:55:22 schrieb Jakob Reschke <[hidden email]>:

Confirmed. If I revert to the previous version cmm 3/30/2018 14:24 of
DialogWindow getUserResponse, the issue does not arise any more.

2018-05-21 22:24 GMT+02:00 karl ramberg :

> Hi,
> Could it be similar issue as PopUpChoiceMorph I reported a while back? That
> is caused by this change
>
> The Trunk: Morphic-mt.1414.mcz
>
> Best,
> Karl
>
> On Mon, May 21, 2018 at 9:13 PM, Jakob Reschke
> wrote:
>>
>> Hello,
>>
>> After using the text emphasis halo handle (the orange one, next to
>> rightmost at the bottom) on a text morph to change the emphasis of
>> selected text, the emphasis selection dialog will appear again on
>> every click, albeit not clicking on the same handle again. In fact, it
>> does not matter where I click: even clicking the world invokes
>> chooseEmphasisOrAlignment on the text again.
>>
>> A workaround is to use the Ctrl+. interrupt. After that, the halo can
>> be dismissed by clicking somewhere else.
>>
>> The same issue also applies to the font style halo handle (the middle
>> one at the bottom), but not to the font size handle (next to leftmost
>> at the bottom). The issue does not show in my Squeak 5.1 image. There,
>> the halo vanishes after selecting the emphasis once.
>>
>> You should be able to reproduce it in a Workspace. Shift+blue click on
>> the text should open the halo on the relevant text morph immediately.
>>
>> Kind regards,
>> Jakob
>>
>> PS. I wanted to use this to apply the struck-out emphasis. Its
>> keyboard shortcut is overridden by the global font size changing
>> actions. If you know another, easier way to strike out text, please
>> tell me. :-)
>>
>
>
>
>