VFSAddOns fix

Hee,

I've fixed two bugs in the VFSAddOns package, both in fileData, which
should make the package usable now.
The first bug was a little hard to find as it seemed to be time related.
It showed up every now and then. It seemed to be the case that a pipe
was still being read out while it's output was already being processed.

The second bug. fileData returns an array with some information, but the
VFSAddOns package didn't fill every variable in this array. A loop goes
over a string and extracts information from it. The Date package read
the string till the end while processing the date, leaving no data for
any processing after it.

I've attached a patch, which should explain some more.

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 11/23/2011 11:59 AM, maarten wrote:
> Hee,
>
> I've fixed two bugs in the VFSAddOns package, both in fileData, which
> should make the package usable now.
> The first bug was a little hard to find as it seemed to be time related.
> It showed up every now and then. It seemed to be the case that a pipe
> was still being read out while it's output was already being processed.

Hi Maarten.  Do you have a reproducer?  In this case, the pipe should
block until all data is read.

> The second bug. fileData returns an array with some information, but the
> VFSAddOns package didn't fill every variable in this array. A loop goes
> over a string and extracts information from it. The Date package read
> the string till the end while processing the date, leaving no data for
> any processing after it.

I think the bug here is in the Date/Duration/DateTime readers.  Does
something like the attached patch (lightly tested) help?

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

On 11/23/2011 01:07 PM, Paolo Bonzini wrote:
>
> I think the bug here is in the Date/Duration/DateTime readers.  Does
> something like the attached patch (lightly tested) help?

I pushed the patch with some fixes and over 200 testcases. :)

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk