VM Maker: CogTools-sk.17.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

VM Maker: CogTools-sk.17.mcz

commits-2
 
Sophie Kaleba uploaded a new version of CogTools to project VM Maker:
http://source.squeak.org/VMMaker/CogTools-sk.17.mcz

==================== Summary ====================

Name: CogTools-sk.17
Author: sk
Time: 17 May 2017, 6:38:35.956825 pm
UUID: 1efa7ff2-e5d2-40f6-a40c-b8241e98407c
Ancestors: CogTools-sk.16

disabling temporarily some features

=============== Diff against CogTools-sk.16 ===============

Item was changed:
  ----- Method: SqueakVMProfiler class>>initialize (in category 'as yet unclassified') -----
  initialize
 
  super initialize.
+ "(TheWorldMenu respondsTo: #registerOpenCommand:) ifTrue:
- (TheWorldMenu respondsTo: #registerOpenCommand:) ifTrue:
  [TheWorldMenu registerOpenCommand: {'VM Profiler'. {self. #open}. 'A VM profiler'}].
  Preferences
  addBooleanPreference: #vmProfilerFillInIntegral
  category: #vmProfiler
  default: false
  balloonHelp: 'If enabled, the profiler will fill in the area under the integral.'.
+ self fixTabs" "makes the import fail on Pharo. Have to find a workaround"!
- self fixTabs!

Item was added:
+ ----- Method: SqueakVMProfiler>>stopProfiling (in category 'as yet unclassified') -----
+ stopProfiling
+
+ super stopProfiling.
+ self updateButtons!

Item was changed:
  ----- Method: VMProfiler>>stopProfiling (in category 'profiling') -----
  stopProfiling
  "still UI-dependent"
  | numSamples now vmParameters |
  numSamples := self stopVMProfile.
  now := Time millisecondClockValue.
  vmParameters := self getVMParameters.
  cogCodeConstituents := self primitiveCollectCogCodeConstituents.
  elapsedTime := now - startTime + elapsedTime.
  self computeStats: vmParameters.
  self computeHistograms: numSamples.
  self computeCogCodeModule.
  "self computeSortedSymbols." "makes the profiling crash"
  self clearHistory.
+ !
- "self updateButtons"!

Item was changed:
  ----- Method: VMProfilerLinuxSymbolsManager class>>shutDown: (in category 'shut down') -----
  shutDown: quitting
+ "(quitting
- (quitting
  and: [#('Mac OS' 'unix') includes: Smalltalk platformName]) ifTrue:
  [| tempDir |
  (tempDir := self tempDirectory) exists ifTrue:
+ [tempDir recursiveDelete]]" "error on Pharo as recursiveDelete is from FileDirectory. Have to find something similar with FileSystem"!
- [tempDir recursiveDelete]]!

Item was changed:
  ----- Method: VMProfilerMacSymbolsManager class>>shutDown: (in category 'shut down') -----
  shutDown: quitting
  "(quitting
  and: [Smalltalk platformName= 'Mac OS']) ifTrue:
  [| tempDir |
  (tempDir := self tempDirectory) exists ifTrue:
+ [tempDir recursiveDelete]]" "error on Pharo as recursiveDelete is from FileDirectory. Have to find something similar with FileSystem"!
- [tempDir recursiveDelete]]"!