Eliot Miranda uploaded a new version of VMMaker to project VM Maker:
http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2309.mcz==================== Summary ====================
Name: VMMaker.oscog-eem.2309
Author: eem
Time: 5 January 2018, 12:28:49.355435 am
UUID: 122d5ac0-b546-4f56-a020-8e8988fc5c10
Ancestors: VMMaker.oscog-eem.2307
Tweak the recent inlining commenting change; don't bother to comment if what's being inlined is a named constant.
=============== Diff against VMMaker.oscog-eem.2307 ===============
Item was changed:
----- Method: TMethod>>tryToInlineMethodExpressionsIn: (in category 'inlining') -----
tryToInlineMethodExpressionsIn: aCodeGen
"Expand any (complete) inline methods sent by this method as receivers or parameters.
Answer if anything was inlined."
| sendsToInline |
sendsToInline := Dictionary new: 100.
aCodeGen
pushScope: declarations
while: [parseTree
nodesDo:
[:node|
(self inlineableFunctionCall: node in: aCodeGen) ifTrue:
[(self inlineFunctionCall: node in: aCodeGen) ifNotNil:
[:replacement|
+ (replacement isConstant
+ and: [replacement isDefine not
+ and: [replacement value isNumber
+ and: [replacement comment isNil]]]) ifTrue:
- (replacement isConstant and: [replacement value isNumber and: [replacement comment isNil]]) ifTrue:
[replacement comment: node selector].
sendsToInline at: node put: replacement]]]
unless: "Don't inline the arguments to asserts to keep the asserts readable"
[:node|
node isSend
and: [node selector == #cCode:inSmalltalk:
or: [aCodeGen isAssertSelector: node selector]]]].
sendsToInline isEmpty ifTrue:
[^false].
self replaceNodesIn: sendsToInline.
^true!