Smalltalk › Cincom › VisualWorks

[VW 7.4.1] [Bug] isRuntime answers false @ runtime

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 3 messages Options
Stew MacLean
Reply | Threaded
Open this post in threaded view
♦
♦
|

[VW 7.4.1] [Bug] isRuntime answers false @ runtime

Stew MacLean

If you evaluate

 

RuntimeManager class>> isRuntime

 

Or

 

RuntimeSystem class>>isRuntime

 

Or

 

DeploymentOptionsSystem class/instance>>isRuntime (they all end up here, instance side)

 

At runtime, the answer is false.

 

The reason being is that it is not being set during Packaging.

 

To fix this add

 

DeploymentOptionsSystem current isRuntime: true.

 

to:

 

RuntimeManager class>>doOneStepFinalImageSave

RuntimeManager class>>doThreeStepFinalImageSave

 

These methods currently only set startInRuntime, which is not the same thing.

 

Cheers,

 

Stewart

 

 

 

 
Alan Knight-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [VW 7.4.1] [Bug] isRuntime answers false @ runtime

Alan Knight-2
Well, there's a reason it's done that way, and normally the line
   isRuntime := startInRuntime
in DeploymentOptionsSystem would take care of that. I'd conjecture that your altering of the startup order has more side effects than you realized, and that DeploymentOptionsSystem, and possibly other things, are not being run at all.

At 03:49 AM 4/19/2007, Stewart MacLean wrote:
If you evaluate
 
RuntimeManager class>> isRuntime
 
Or
 
RuntimeSystem class>>isRuntime
 
Or
 
DeploymentOptionsSystem class/instance>>isRuntime (they all end up here, instance side)
 
At runtime, the answer is false.
 
The reason being is that it is not being set during Packaging.
 
To fix this add
 
DeploymentOptionsSystem current isRuntime: true.
 
to:
 
RuntimeManager class>>doOneStepFinalImageSave
RuntimeManager class>>doThreeStepFinalImageSave
 
These methods currently only set startInRuntime, which is not the same thing.
 
Cheers,
 
Stewart
 
 
 
 

--
Alan Knight [|], Cincom Smalltalk Development

"The Static Typing Philosophy: Make it fast. Make it right. Make it run." - Niall Ross
Stew MacLean
Reply | Threaded
Open this post in threaded view
♦
♦
|

RE: [VW 7.4.1] [Bug] isRuntime answers false @ runtime

Stew MacLean

Alan, I eat my words!

 

It’s not the altering of the start up order (when I test for isRuntime, I haven’t initialised the ExternalInterface – that’s done later in the method), it’s just that DeploymentOptionsSystem>>setup has not run yet.

 

I had checked for sends of isRuntime:, but not for assignment.

 

Duh!

 

-----Original Message-----
From: Alan Knight [mailto:[hidden email]]
Sent: 20 April 2007 12:59 a.m.
To: Stewart MacLean; [hidden email]
Subject: Re: [VW 7.4.1] [Bug] isRuntime answers false @ runtime

 

Well, there's a reason it's done that way, and normally the line
   isRuntime := startInRuntime
in DeploymentOptionsSystem would take care of that. I'd conjecture that your altering of the startup order has more side effects than you realized, and that DeploymentOptionsSystem, and possibly other things, are not being run at all.

At 03:49 AM 4/19/2007, Stewart MacLean wrote:

If you evaluate
 
RuntimeManager class>> isRuntime
 
Or
 
RuntimeSystem class>>isRuntime
 
Or
 
DeploymentOptionsSystem class/instance>>isRuntime (they all end up here, instance side)
 
At runtime, the answer is false.
 
The reason being is that it is not being set during Packaging.
 
To fix this add
 
DeploymentOptionsSystem current isRuntime: true.
 
to:
 
RuntimeManager class>>doOneStepFinalImageSave
RuntimeManager class>>doThreeStepFinalImageSave
 
These methods currently only set startInRuntime, which is not the same thing.
 
Cheers,
 
Stewart
 
 
 
 


--
Alan Knight [|], Cincom Smalltalk Development

"The Static Typing Philosophy: Make it fast. Make it right. Make it run." - Niall Ross
Free forum by Nabble Edit this page