[VW 7.9] Some override comparisons cause exceptions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[VW 7.9] Some override comparisons cause exceptions

Terry Raymond

There is a bug in TextFragment>>smalltalkOrWordAndWhitespaceFragments.

An exception handler block is missing the block argument.

 

I have attached the fixed method.

 

Terry

 

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI  02878

(401) 624-4517      [hidden email]

===========================================================

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc

TextFragment-smalltalkOrWordAndWhitespaceFragments.st (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VW 7.9] Some override comparisons cause exceptions

Boris Popov, DeepCove Labs (SNN)

I thought those were optional as per #cull: in the below,

 

[1/0] on: ZeroDivide do: [#zork] => #zork

 

performHandler: aContext

 

                | result oldHandler |

                (handlerContext := aContext) == nil

                                ifTrue:

                                                [result := self defaultAction.

                                                self isResumable

                                                                ifTrue:

                                                                                [handlerContext := initialContext.

                                                                                firstUnwindContext := nil.

                                                                                self unwind.

                                                                                thisContext terminateTo: handlerContext.

                                                                                handlerContext := nil]]

                                ifFalse:

                                                [oldHandler := handlerContext.

                                                result := handlerContext handlerBlock cull: self.

                                                handlerContext := oldHandler. "Executing the handler may have set a new handler."

                                                self unwind.

                                                thisContext terminateTo: handlerContext].

                ^result

 

-Boris

 

From: [hidden email] [mailto:[hidden email]] On Behalf Of Terry Raymond
Sent: Thursday, July 12, 2012 2:19 PM
To: VWNC
Subject: [vwnc] [VW 7.9] Some override comparisons cause exceptions

 

There is a bug in TextFragment>>smalltalkOrWordAndWhitespaceFragments.

An exception handler block is missing the block argument.

 

I have attached the fixed method.

 

Terry

 

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI  02878

(401) 624-4517      [hidden email]

===========================================================

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc
Reply | Threaded
Open this post in threaded view
|

Re: [VW 7.9] Some override comparisons cause exceptions

Terry Raymond

Boris

 

ARGH!!  Thanks, we modified #performHandler: in 7.6 and I missed the change

when I brought forward to 7.9.

 

Terry

 

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI  02878

(401) 624-4517      [hidden email]

===========================================================

 

From: Boris Popov, DeepCove Labs [mailto:[hidden email]]
Sent: Thursday, July 12, 2012 2:26 PM
To: Terry Raymond; VWNC
Subject: RE: [vwnc] [VW 7.9] Some override comparisons cause exceptions

 

I thought those were optional as per #cull: in the below,

 

[1/0] on: ZeroDivide do: [#zork] => #zork

 

performHandler: aContext

 

                | result oldHandler |

                (handlerContext := aContext) == nil

                                ifTrue:

                                                [result := self defaultAction.

                                                self isResumable

                                                                ifTrue:

                                                                                [handlerContext := initialContext.

                                                                                firstUnwindContext := nil.

                                                                                self unwind.

                                                                                thisContext terminateTo: handlerContext.

                                                                                handlerContext := nil]]

                                ifFalse:

                                                [oldHandler := handlerContext.

                                                result := handlerContext handlerBlock cull: self.

                                                handlerContext := oldHandler. "Executing the handler may have set a new handler."

                                                self unwind.

                                                thisContext terminateTo: handlerContext].

                ^result

 

-Boris

 

From: [hidden email] [hidden email] On Behalf Of Terry Raymond
Sent: Thursday, July 12, 2012 2:19 PM
To: VWNC
Subject: [vwnc] [VW 7.9] Some override comparisons cause exceptions

 

There is a bug in TextFragment>>smalltalkOrWordAndWhitespaceFragments.

An exception handler block is missing the block argument.

 

I have attached the fixed method.

 

Terry

 

===========================================================

Terry Raymond

Crafted Smalltalk

80 Lazywood Ln.

Tiverton, RI  02878

(401) 624-4517      [hidden email]

===========================================================

 


_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc