Version number in star packages

> Hi,
>
> Now that we have the infrastructure for downloading and installing star
> packages from smalltalk.gnu.org, I think it would be nice to have the
> version number information in the package.xml (and then in the package
> object).
>
> What about adding two tags, one for the major version, one for the minor
> version and one for the patch version?
>
> This would give: maj.min.patch -> 0.8.4
>
> Cheers!
>
> Nico
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> http://lists.gnu.org/mailman/listinfo/help-smalltalk

> On 12/30/2009 11:15 PM, Gwenael Casaccio wrote:
> > -    "I tried to put these from the most common to the least common"
> > -    tag = 'file' ifTrue: [self files add: cdata] ifFalse: [
> > -    tag = 'filein' ifTrue: [self fileIns add: cdata] ifFalse: [
> > -    tag = 'prereq' ifTrue: [self prerequisites add: cdata] ifFalse: [
> > -    tag = 'provides' ifTrue: [self features add: cdata] ifFalse: [
> > -    tag = 'module' ifTrue: [self modules add: cdata] ifFalse: [
> > -    tag = 'directory' ifTrue: [self relativeDirectory: cdata] ifFalse: [
> > -    tag = 'name' ifTrue: [self name: cdata] ifFalse: [
> > -    tag = 'url' ifTrue: [self url: cdata] ifFalse: [
> > -    tag = 'namespace' ifTrue: [self namespace: cdata] ifFalse: [
> > -    tag = 'library' ifTrue: [self libraries add: cdata] ifFalse: [
> > -    tag = 'built-file' ifTrue: [self builtFiles add: cdata] ifFalse: [
> > -    tag = 'sunit' ifTrue: [self sunitScripts add: cdata] ifFalse: [
> > -    tag = 'start' ifTrue: [self startScript: cdata] ifFalse: [
> > -    tag = 'stop' ifTrue: [self stopScript: cdata] ifFalse: [
> > -    tag = 'callout' ifTrue: [self callouts add: cdata] ifFalse: [
> > -    tag = openingTag ifTrue: [^self] ifFalse: [
> > - self error: 'invalid tag ' , tag]]]]]]]]]]]]]]]].
> > +    tag = openingTag ifTrue: [ ^ self ].
> > +    self perform: (self class tags at: tag ifAbsent: [ self error: 'invalid tag ', tag ]) with: cdata.
>
> I forgot to say that things like this one embarrass me. :-)

> On 12/30/2009 11:15 PM, Gwenael Casaccio wrote:
> > +    parseVersion: aString [
> > + <category: 'version parsing'>
> > +
> > + | tokens |
> > + (tokens := aString tokenize: '\.') size = 3 ifFalse: [ self error: 'Bad version string : ', aString, ' should be xx.yy.zz' ].
> > + self version: (Version major: tokens first asInteger minor: tokens second asInteger patch: tokens third asInteger)
> > +    ]
>
> This should:
>
> 1) use #subStrings: or alternatively a single regex match
>
>      ^(\d+)\.(\d+)(?:\.(\d+))$
>
> instead of tokenize.
>
> 2) be in Version class>>#fromString:
>
> 3) accept a version like 1.0 and change it to 1.0.0 (see regex above).
>
> Otherwise looks fine, filtering of prerequisites based on their version
> can be done later.
>
> Paolo

> On 12/30/2009 11:15 PM, Gwenael Casaccio wrote:
> > +    parseVersion: aString [
> > + <category: 'version parsing'>
> > +
> > + | tokens |
> > + (tokens := aString tokenize: '\.') size = 3 ifFalse: [ self error: 'Bad version string : ', aString, ' should be xx.yy.zz' ].
> > + self version: (Version major: tokens first asInteger minor: tokens second asInteger patch: tokens third asInteger)
> > +    ]
>
> This should:
>
> 1) use #subStrings: or alternatively a single regex match
>
>      ^(\d+)\.(\d+)(?:\.(\d+))$
>
> instead of tokenize.
>
> 2) be in Version class>>#fromString:
>
> 3) accept a version like 1.0 and change it to 1.0.0 (see regex above).
>
> Otherwise looks fine, filtering of prerequisites based on their version
> can be done later.
>
> Paolo