Versionner: Committing a config commits twice

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Versionner: Committing a config commits twice

Sean P. DeNigris
Administrator
Versionner is getting *really* cool!!

I found a bug:
http://ss3.gemstone.com/ss/Versionner.html/Issues
Issue 1: Committing a config commits twice

1. In Pharo 2.0, "ConfigurationOfVersionner project development load:#('Core' 'Spec')."
2. Create new config for a package
3. Click commit

It saves it, but then is shows it dirty again and asks about a new version number. Even though I cancelled, it saved the config to the repo (in this case http://ss3.gemstone.com/ss/VimPharo) again:
ConfigurationOfVimPharo-SeanDeNigris.1.mcz
ConfigurationOfVimPharo-SeanDeNigris.2.mcz
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Versionner: Committing a config commits twice

Juan Pablo Sandoval
Hi,

I am working in this issue, I will notify you when it's fixed.

Thanks,
Juan Pablo

2012/7/7 Sean P. DeNigris <[hidden email]>
Versionner is getting *really* cool!!

I found a bug:
http://ss3.gemstone.com/ss/Versionner.html/Issues
Issue 1: Committing a config commits twice

1. In Pharo 2.0, "ConfigurationOfVersionner project development
load:#('Core' 'Spec')."
2. Create new config for a package
3. Click commit

It saves it, but then is shows it dirty again and asks about a new version
number. Even though I cancelled, it saved the config to the repo (in this
case http://ss3.gemstone.com/ss/VimPharo) again:
ConfigurationOfVimPharo-SeanDeNigris.1.mcz
ConfigurationOfVimPharo-SeanDeNigris.2.mcz

--
View this message in context: http://forum.world.st/Versionner-Committing-a-config-commits-twice-tp4638988.html
Sent from the Pharo Smalltalk mailing list archive at Nabble.com.




--
Juampi
Reply | Threaded
Open this post in threaded view
|

Re: Versionner: Committing a config commits twice

Sean P. DeNigris
Administrator
Juan Pablo Sandoval wrote
I am working in this issue, I will notify you when it's fixed.
Any progress? I'd like to check out Versionner again...

thanks,
sean
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Versionner: Committing a config commits twice

Juan Pablo Sandoval
Hi Sean,

Yes, I worked in this issue. You can  try with the development version of Versionner.

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
(ConfigurationOfVersionner project version: #development)  load:#('Core' 'Spec')
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Changes:

1.35 : Remove glamour support. Port to Pharo 2.0
1.34 : Fixing issue 1 committing a config commits twice.

Regards,
Juan Pablo
(ConfigurationOfVersionner project version: #development)  load:#('Core' 'Spec')
2012/8/8 Sean P. DeNigris <[hidden email]>

Juan Pablo Sandoval wrote
>
> I am working in this issue, I will notify you when it's fixed.
>

Any progress? I'd like to check out Versionner again...

thanks,
sean



--
View this message in context: http://forum.world.st/Versionner-Committing-a-config-commits-twice-tp4638988p4643526.html
Sent from the Pharo Smalltalk mailing list archive at Nabble.com.




--
Juampi
Reply | Threaded
Open this post in threaded view
|

Re: Versionner: Committing a config commits twice

Sean P. DeNigris
Administrator
Juan Pablo Sandoval wrote
Yes, I worked in this issue. You can  try with the development version of
Versionner.
Thanks! I'll play some more...
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Versionner: Committing a config commits twice

Sean P. DeNigris
Administrator
In reply to this post by Juan Pablo Sandoval
Juan Pablo Sandoval wrote
Yes, I worked in this issue. You can  try with the development version of
Versionner.
I loaded with:
  Gofer new
    url: 'http://ss3.gemstone.com/ss/Versionner';
    package: 'ConfigurationOfVersionner';
    load.

  ConfigurationOfVersionner project development load:#('Core' 'Spec').

To use in Pharo 2.0, requires a change for SystemAnnouncer (patched mcz attached to Nabble post [1]).

On 1.4 #14457, from VersionnerSpecBrowser>>initializeWidgets, I got:

UndefinedObject(Object)>>doesNotUnderstand: #contents:
        Receiver: nil
        Arguments and temporary variables:
                aMessage: contents: [:configuration | self iconForConfiguration: configuration]...etc...
                exception: MessageNotUnderstood: receiver of "contents:" is nil
                resumeValue: nil
        Receiver's instance variables:
nil

IconListModel>>icons:
        Receiver: an IconListModel
        Arguments and temporary variables:
                aBlock: [:configuration | self iconForConfiguration: configuration]
        Receiver's instance variables:
                dependents: nil
                bindings: a BindingsHolder
                focusOrder: nil
                owner: a VersionnerSpecBrowser
                window: nil
                spec: nil
                extentHolder: a NewValueHolder
                needRebuild: a NewValueHolder
                isEventForNextFocusBlock: a NewValueHolder
                isEventForPreviousFocusBlock: a NewValueHolder
                helpHolder: a NewValueHolder
                borderWidth: a NewValueHolder
                borderColor: a NewValueHolder
                enabledHolder: a NewValueHolder
                selectionHolder: a SelectionValueHolder
                listHolder: a CollectionValueHolder
                menuHolder: a NewValueHolder
                shortcutsHolder: a NewValueHolder
                multiSelectionHolder: a DictionaryValueHolder
                multiSelection: a NewValueHolder
                allowToSelect: a NewValueHolder
                listItemsCache: nil
                filteringBlockHolder: a NewValueHolder
                sortingBlockHolder: a NewValueHolder
                wrapBlockHolder: a NewValueHolder
                iconHolder: a NewValueHolder

VersionnerSpecBrowser>>initializeWidgets
        Receiver: a VersionnerSpecBrowser
        Arguments and temporary variables:

        Receiver's instance variables:
                dependents: a DependentsArray(an IconListModel an IconListModel an IconListMode...etc...
                bindings: a BindingsHolder
                focusOrder: nil
                owner: nil
                window: nil
                spec: nil
                extentHolder: a NewValueHolder
                needRebuild: a NewValueHolder
                isEventForNextFocusBlock: a NewValueHolder
                isEventForPreviousFocusBlock: a NewValueHolder
                configurations: an IconListModel
                versions: nil
                baselines: nil
                toolbar: nil

[1] Versionner-Core-Model-SeanDeNigris.16.mcz
Cheers,
Sean