Versionner Wipes per-package #repository: setting

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Versionner Wipes per-package #repository: setting

Sean P. DeNigris
Administrator
If you have a config with e.g.:
  spec package: 'MyPackage' with: [ spec repository: aString ];
And then save it with Versionner, it gets truncated to:
  spec package: 'MyPackage';

Should I file a bug? Ideally, Versionner would support Metacello's full API, but in the mean time, at least leaving unknown options alone would be a big improvement. As it stands now, once one has something like the above in a config, one can't use Versionner anymore.
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Versionner Wipes per-package #repository: setting

demarey
Hi Sean,

Le 3 juin 2015 à 22:29, Sean P. DeNigris a écrit :

> If you have a config with e.g.:
>  spec package: 'MyPackage' with: [ spec repository: aString ];
> And then save it with Versionner, it gets truncated to:
>  spec package: 'MyPackage';
>
> Should I file a bug? Ideally, Versionner would support Metacello's full API,

Versionner is not thought to support Metacello full API but rather a subset and provide guidelines.

> but in the mean time, at least leaving unknown options alone would be a big
> improvement.

Fully agree with that. Even if not supported in the UI, Versionner should not discard data.

> As it stands now, once one has something like the above in a
> config, one can't use Versionner anymore.

In the meantime, I find very strange to have packages of a project in different repositories. When I saw this kind of things, it was in configurations using packages from another project without declaring this external project in the config. Maybe in some cases, it is needed but it is not something that we want to encourage.
Could you tell me more about your use case?

Cheers,
Christophe

smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Versionner Wipes per-package #repository: setting

Sean P. DeNigris
Administrator
demarey wrote
I find very strange to have packages of a project in different repositories. When I saw this kind of things, it was in configurations using packages from another project without declaring this external project in the config... Could you tell me more about your use case?
Hee hee, you caught me ;) I agree that we shouldn't encourage such irresponsible behavior, and request only that we limit the punishment to having to hand-write, instead of decapitation!
Cheers,
Sean
Reply | Threaded
Open this post in threaded view
|

Re: Versionner Wipes per-package #repository: setting

demarey

Le 3 juin 2015 à 22:51, Sean P. DeNigris a écrit :

> demarey wrote
>> I find very strange to have packages of a project in different
>> repositories. When I saw this kind of things, it was in configurations
>> using packages from another project without declaring this external
>> project in the config... Could you tell me more about your use case?
>
> Hee hee, you caught me ;) I agree that we shouldn't encourage such
> irresponsible behavior, and request only that we limit the punishment to
> having to hand-write, instead of decapitation!

no problem ;)
Please add a bug entry. I will take a look if it's can be done quickly.

Cheers,
Christophe.

smime.p7s (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Versionner Wipes per-package #repository: setting

Sean P. DeNigris
Administrator
demarey wrote
Please add a bug entry. I will take a look if it's can be done quickly.
I created an issue and forgot to tell you :/
Issue 15691: Versionner: Don't Cobber Unsupported Parts of Configurations
https://pharo.fogbugz.com/default.asp?15691
Cheers,
Sean