WAFormCharEncodingTest

> 2010/5/15 Michael Lucas-Smith<[hidden email]>:
>    
>> Hi All,
>>
>> Do #testBasicForm, #testDefaultAction, #testDefaultActionGet and #testIsGet
>> on WAFormCharEncodingTest fail for anyone else? For me it fails bceause the
>> form accept-charset becomes utf-16, not the expected utf-8 -- but it seems
>> as though it *should* be utf-16 because #createHandlers specifically sets
>> the charSet to be utf-16.
>>      
> The version in my image (lr.47) expects utf-16 and gets utf-16. What
> version do you have?
>    

> On 5/15/10 4:14 AM, Philippe Marschall wrote:
>>
>> 2010/5/15 Michael Lucas-Smith<[hidden email]>:
>>
>>>
>>> Hi All,
>>>
>>> Do #testBasicForm, #testDefaultAction, #testDefaultActionGet and
>>> #testIsGet
>>> on WAFormCharEncodingTest fail for anyone else? For me it fails bceause
>>> the
>>> form accept-charset becomes utf-16, not the expected utf-8 -- but it
>>> seems
>>> as though it *should* be utf-16 because #createHandlers specifically sets
>>> the charSet to be utf-16.
>>>
>>
>> The version in my image (lr.47) expects utf-16 and gets utf-16. What
>> version do you have?
>>
>
> lr.47
>
> WAFormCharEncodingTest inherits the tests from WAFormTagTest...

> 2010/5/17 Michael Lucas-Smith<[hidden email]>:
>    
>> On 5/15/10 4:14 AM, Philippe Marschall wrote:
>>      
>>> 2010/5/15 Michael Lucas-Smith<[hidden email]>:
>>>
>>>        
>>>> Hi All,
>>>>
>>>> Do #testBasicForm, #testDefaultAction, #testDefaultActionGet and
>>>> #testIsGet
>>>> on WAFormCharEncodingTest fail for anyone else? For me it fails bceause
>>>> the
>>>> form accept-charset becomes utf-16, not the expected utf-8 -- but it
>>>> seems
>>>> as though it *should* be utf-16 because #createHandlers specifically sets
>>>> the charSet to be utf-16.
>>>>
>>>>          
>>> The version in my image (lr.47) expects utf-16 and gets utf-16. What
>>> version do you have?
>>>
>>>        
>> lr.47
>>
>> WAFormCharEncodingTest inherits the tests from WAFormTagTest...
>>      
> Not in Pharo.
>    

> On 5/17/10 9:38 AM, Philippe Marschall wrote:
>>
>> 2010/5/17 Michael Lucas-Smith<[hidden email]>:
>>
>>>
>>> On 5/15/10 4:14 AM, Philippe Marschall wrote:
>>>
>>>>
>>>> 2010/5/15 Michael Lucas-Smith<[hidden email]>:
>>>>
>>>>
>>>>>
>>>>> Hi All,
>>>>>
>>>>> Do #testBasicForm, #testDefaultAction, #testDefaultActionGet and
>>>>> #testIsGet
>>>>> on WAFormCharEncodingTest fail for anyone else? For me it fails bceause
>>>>> the
>>>>> form accept-charset becomes utf-16, not the expected utf-8 -- but it
>>>>> seems
>>>>> as though it *should* be utf-16 because #createHandlers specifically
>>>>> sets
>>>>> the charSet to be utf-16.
>>>>>
>>>>>
>>>>
>>>> The version in my image (lr.47) expects utf-16 and gets utf-16. What
>>>> version do you have?
>>>>
>>>>
>>>
>>> lr.47
>>>
>>> WAFormCharEncodingTest inherits the tests from WAFormTagTest...
>>>
>>
>> Not in Pharo.
>>
>
> How does this work in Pharo? The test* methods are in the superclass, why
> aren't they run in the subclass?

> 2010/5/17 Michael Lucas-Smith <[hidden email]>:
>> ....
>>
>> How does this work in Pharo? The test* methods are in the superclass, why
>> aren't they run in the subclass?
>
> shouldInheritSelectors
>        "I should inherit from an Abstract superclass but not from a concrete
> one by default, unless I have no testSelectors in which case I must be
> expecting to inherit them from my superclass.  If a test case with
> selectors wants to inherit selectors from a concrete superclass,
> override this to true in that subclass."
>
>        ^self superclass isAbstract
>                or: [self testSelectors isEmpty]
>
> "$QA Ignore:Sends system method(superclass)$"

> 2010/5/17 Philippe Marschall<[hidden email]>:
>    
>> 2010/5/17 Michael Lucas-Smith<[hidden email]>:
>>      
>>> ....
>>>
>>> How does this work in Pharo? The test* methods are in the superclass, why
>>> aren't they run in the subclass?
>>>        
>> shouldInheritSelectors
>>         "I should inherit from an Abstract superclass but not from a concrete
>> one by default, unless I have no testSelectors in which case I must be
>> expecting to inherit them from my superclass.  If a test case with
>> selectors wants to inherit selectors from a concrete superclass,
>> override this to true in that subclass."
>>
>>         ^self superclass isAbstract
>>                 or: [self testSelectors isEmpty]
>>
>> "$QA Ignore:Sends system method(superclass)$"
>>      
>    

> 2010/5/17 Michael Lucas-Smith<[hidden email]>:
>    
>> ....
>>
>> Ah that makes sense. SUnitToo and SUnit deviate at this point.
>>      
> It would be cool if you could run them with SUnit instead of SUnitToo.
> SUnit has pretty well defined semantics across all dialects and we
> never had any problems with it.
>
>