> On 16.05.2017, at 18:05, Eliot Miranda <
[hidden email]> wrote:
>
>
>
> On Tue, May 16, 2017 at 8:57 AM, Tobias Pape <
[hidden email]> wrote:
>
>
> > On 16.05.2017, at 17:41, Eliot Miranda <
[hidden email]> wrote:
> >
> > Hi Win64 mavens,
> >
> > I see in platforms//win32/third-party/dx9sdk that the source code tests for
> > #if _WIN64
> > In most places we've used
> > #if WIN64
> > but in platforms//Cross/plugins/IA32ABI/ia32abi.h & platforms//Cross/vm/sqMemoryFence.h we have also used _WIN64.
> >
> > Is it OK for us to continue to use the cleaner form or should we use _WIN64?
>
>
> _WIN64 is defined by the compiler (
https://msdn.microsoft.com/en-us/library/b0084kay.aspx)
>
> "_WIN64 Defined as 1 when the compilation target is 64-bit ARM or x64. Otherwise, undefined."
> (which also means, #ifdef would be better than #if)
>
> According to the internet (
>
https://www.viva64.com/en/k/0040/> ) WIN64 is typically homegrown.
>
> OK, then _WIN64 and _WIN32 it must be. Would you be willing to change the platform source (still defining WIN32 and WIN64 as appropriate) if I changed the VMMaker source?
Tight resources atm, sorry :/
I don't know the impact of that change and currently I am to not cover myself with VM stuff…
>
>
>
> Also, it seems there are but a few (8x in plaform/ and src/) users of WIN64 (w/o _)
>
> Yes. I shall fix these ASAP. I want to do it now because Nicolas is impacted, and I can make his life easier. I've been over complicating by defining WIN64ABI, but it has no justification, and using _WIN64 would make things easier.
>
>
> Best regards
> -Tobias
>
>
>
> >
> > _,,,^..^,,,_
> > best, Eliot
>
>
>
>
> --
> _,,,^..^,,,_
> best, Eliot
Locked
