Welcome Workspace why not opened?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Welcome Workspace why not opened?

Mariano Martinez Peck
Hi. DEVImageWorkspaces class >> openWelcomeWorkspace
now looks like this:

SystemVersion current minor = 3 ifTrue: [^self]. "Workspace API chagend. To be Fixed"
    self
        newWorkspaceWithContents: self welcomeWorkspaceText 
        title: 'Welcome to Pharo'
        position: 50@120
        extent: 800 @ 500
 
so...of course in Pharo 1.3 it is just answring self. But in fact, the second part, that is, self
        newWorkspaceWithContents: self welcomeWorkspaceText 
        title: 'Welcome to Pharo'
        position: 50@120
        extent: 800 @ 500
 
is working correclty. So I don't understand the comment "Workspace API chagend. To be Fixed".  What has changed if in fact the other lines work ok ?
and even more, why we have that if: instead of a self deprecated:  ?

So...what should I do ? revert it to

openWelcomeWorkspace
    self
        newWorkspaceWithContents: self welcomeWorkspaceText 
        title: 'Welcome to Pharo'
        position: 50@120
        extent: 800 @ 500
 

or change something in th workspace API ?

Thanks

--
Mariano
http://marianopeck.wordpress.com

Reply | Threaded
Open this post in threaded view
|

Re: Welcome Workspace why not opened?

Marcus Denker-4

On Apr 24, 2011, at 5:23 PM, Mariano Martinez Peck wrote:

> Hi. DEVImageWorkspaces class >> openWelcomeWorkspace
> now looks like this:
>
> SystemVersion current minor = 3 ifTrue: [^self]. "Workspace API chagend. To be Fixed"
>     self
>         newWorkspaceWithContents: self welcomeWorkspaceText  
>         title: 'Welcome to Pharo'
>         position: 50@120
>         extent: 800 @ 500
>  
> so...of course in Pharo 1.3 it is just answring self. But in fact, the second part, that is, self
>         newWorkspaceWithContents: self welcomeWorkspaceText  
>         title: 'Welcome to Pharo'
>         position: 50@120
>         extent: 800 @ 500
>  
> is working correclty. So I don't understand the comment "Workspace API chagend. To be Fixed".  What has changed if in fact the other lines work ok ?
> and even more, why we have that if: instead of a self deprecated:  ?
>
> So...what should I do ? revert it to
>
> openWelcomeWorkspace
>     self
>         newWorkspaceWithContents: self welcomeWorkspaceText  
>         title: 'Welcome to Pharo'
>         position: 50@120
>         extent: 800 @ 500
>  
>
> or change something in th workspace API ?
>
When I tried it earlier in 1.3 it did not work. Now it works, so just remove the

        SystemVersion current minor = 3 ifTrue: [^self]. "Workspace API chagend. To be Fixed"


        Marcus



--
Marcus Denker  -- http://www.marcusdenker.de
INRIA Lille -- Nord Europe. Team RMoD.