Where I commit changes to AutomaticMethodCategorizer for example?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Where I commit changes to AutomaticMethodCategorizer for example?

Mariano Martinez Peck
Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).

So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?

thanks

Mariano

_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Where I commit changes to AutomaticMethodCategorizer for example?

Stéphane Ducasse
1 - ask him
        May be he is not even doing smalltalk anymore.
2- What is the license of the code
3- fork.
        PharoCategorizer
        Pharoxxxx

Stef

On Aug 15, 2010, at 8:52 PM, Mariano Martinez Peck wrote:

> Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
> The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).
>
> So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?
>
> thanks
>
> Mariano
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Where I commit changes to AutomaticMethodCategorizer for example?

Mariano Martinez Peck


On Sun, Aug 15, 2010 at 9:14 PM, Stéphane Ducasse <[hidden email]> wrote:
1 - ask him
       May be he is not even doing smalltalk anymore.
2- What is the license of the code

OK. I will.
 
3- fork.
       PharoCategorizer
       Pharoxxxx


I am starting to be tired about having XXXForPharo or PharoXXX. It seems to be evident that at some point we need a www.pharosource.com for those Pharo specific projects/forks.

Thanks!

Mariano
 
Stef

On Aug 15, 2010, at 8:52 PM, Mariano Martinez Peck wrote:

> Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
> The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).
>
> So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?
>
> thanks
>
> Mariano
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Where I commit changes to AutomaticMethodCategorizer for example?

Guillermo Polito


2010/8/15 Mariano Martinez Peck <[hidden email]>


On Sun, Aug 15, 2010 at 9:14 PM, Stéphane Ducasse <[hidden email]> wrote:
1 - ask him
       May be he is not even doing smalltalk anymore.
2- What is the license of the code

OK. I will.
 
3- fork.
       PharoCategorizer
       Pharoxxxx


I am starting to be tired about having XXXForPharo or PharoXXX. It seems to be evident that at some point we need a www.pharosource.com for those Pharo specific projects/forks.
 
+1
And we can get rid of the packages that are not mantained or used and that stuff...
 

Thanks!

Mariano
 
Stef

On Aug 15, 2010, at 8:52 PM, Mariano Martinez Peck wrote:

> Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
> The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).
>
> So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?
>
> thanks
>
> Mariano
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Where I commit changes to AutomaticMethodCategorizer for example?

Mariano Martinez Peck
In reply to this post by Stéphane Ducasse


On Sun, Aug 15, 2010 at 9:14 PM, Stéphane Ducasse <[hidden email]> wrote:
1 - ask him
       May be he is not even doing smalltalk anymore.
2- What is the license of the code


Ok. Good news. I've contacted him in private and he told me it was funny because exactly the same day (yesterday) he was thinking to send an email to the pharo mailing list to see if someone could continue the project. He put the repo as gloabl read / write  (it was only read before) and he put the license as MIT (there was no license before).

Now...the situation is this. You have a method that answers the defalt rules. However, you could add your own rules for the categorizacion. That was done in a way where you put in a preferences which class and which selector to use. Then, that method was invoke and you got the rules. We don't have Preferences anymore, so we have 2 options:

1) Remove the references to Preferences and have no way to change the method that it is execute to define rules...and thus, for the moment we use the default rules

2) Create settings for that

I would do 1) for now, because it is easy (I have already done it), and I am not sure that this way of calling a method is the best approach to make it extensible. I don't have the time right now, but maybe in a future someone can modify it and make it easily extensible. Maybe using pragmas, Announcements, or some kind of registration pattern.

what do you think?

 
3- fork.
       PharoCategorizer
       Pharoxxxx

Stef

On Aug 15, 2010, at 8:52 PM, Mariano Martinez Peck wrote:

> Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
> The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).
>
> So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?
>
> thanks
>
> Mariano
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Where I commit changes to AutomaticMethodCategorizer for example?

Stéphane Ducasse

On Aug 16, 2010, at 10:26 AM, Mariano Martinez Peck wrote:

>
>
> On Sun, Aug 15, 2010 at 9:14 PM, Stéphane Ducasse <[hidden email]> wrote:
> 1 - ask him
>        May be he is not even doing smalltalk anymore.
> 2- What is the license of the code
>
>
> Ok. Good news. I've contacted him in private and he told me it was funny because exactly the same day (yesterday) he was thinking to send an email to the pharo mailing list to see if someone could continue the project. He put the repo as gloabl read / write  (it was only read before) and he put the license as MIT (there was no license before).
>
> Now...the situation is this. You have a method that answers the defalt rules. However, you could add your own rules for the categorizacion. That was done in a way where you put in a preferences which class and which selector to use. Then, that method was invoke and you got the rules. We don't have Preferences anymore, so we have 2 options:
>
> 1) Remove the references to Preferences and have no way to change the method that it is execute to define rules...and thus, for the moment we use the default rules

Remove the preferences anyway.

> 2) Create settings for that
>
> I would do 1) for now, because it is easy (I have already done it), and I am not sure that this way of calling a method is the best approach to make it extensible. I don't have the time right now, but maybe in a future someone can modify it and make it easily extensible. Maybe using pragmas, Announcements, or some kind of registration pattern.
>
> what do you think?
>
>  
> 3- fork.
>        PharoCategorizer
>        Pharoxxxx
>
> Stef
>
> On Aug 15, 2010, at 8:52 PM, Mariano Martinez Peck wrote:
>
> > Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
> > The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).
> >
> > So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?
> >
> > thanks
> >
> > Mariano
> > _______________________________________________
> > Pharo-project mailing list
> > [hidden email]
> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
Reply | Threaded
Open this post in threaded view
|

Re: Where I commit changes to AutomaticMethodCategorizer for example?

Stéphane Ducasse
In reply to this post by Mariano Martinez Peck

On Aug 15, 2010, at 10:39 PM, Mariano Martinez Peck wrote:

>
>
> On Sun, Aug 15, 2010 at 9:14 PM, Stéphane Ducasse <[hidden email]> wrote:
> 1 - ask him
>        May be he is not even doing smalltalk anymore.
> 2- What is the license of the code
>
> OK. I will.
>  
> 3- fork.
>        PharoCategorizer
>        Pharoxxxx
>
>
> I am starting to be tired about having XXXForPharo or PharoXXX. It seems to be evident that at some point we need a www.pharosource.com for those Pharo specific projects/forks.

yes but what can we pragmatically do?

>
> Thanks!
>
> Mariano
>  
> Stef
>
> On Aug 15, 2010, at 8:52 PM, Mariano Martinez Peck wrote:
>
> > Hi. I am trying to work in the Pharo 1.2 but I an finding different problems. For example, AutomaticMethodCategorizer uses Preferences, and I need to update it.
> > The project has global read in squeaksource, thus I cannot commit. In addition, I don't think Diego will let me commit that as I will break the code for squeak (ok...I can add Smalltalk at:Preferences  ifTrue...but that's crap).
> >
> > So....what do I do ?  I commit that package in Pharo repository?  PharoNonCore?
> >
> > thanks
> >
> > Mariano
> > _______________________________________________
> > Pharo-project mailing list
> > [hidden email]
> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
>
> _______________________________________________
> Pharo-project mailing list
> [hidden email]
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project


_______________________________________________
Pharo-project mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project