Where are PR build results stored

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Where are PR build results stored

Stephan Eggermont-3
 
This week I was able to triangulate when the fullscreen bug on OS-X was
introduced, but I was not able to verify whether Pablo’s proposed fix
resolved the problem for me as I don’t have a local VM build set up (and
that would be a customized one anyway) and I don’t know where PR builds are
kept

Stephan



Reply | Threaded
Open this post in threaded view
|

Re: Where are PR build results stored

fniephaus
 
Hi Stephan,
Deployment is disabled for PR builds and feature branches. I admit this would've been useful for you in this particular case, but I think it's reasonable to only build bleeding edge VMs from dev.

Fabio

On Sat, 23 Mar 2019 at 10:59 am, Stephan Eggermont <[hidden email]> wrote:
 
This week I was able to triangulate when the fullscreen bug on OS-X was
introduced, but I was not able to verify whether Pablo’s proposed fix
resolved the problem for me as I don’t have a local VM build set up (and
that would be a customized one anyway) and I don’t know where PR builds are
kept

Stephan



Reply | Threaded
Open this post in threaded view
|

Re: Where are PR build results stored

Stephan Eggermont-3
 
Fabio Niephaus <[hidden email]> wrote:
> Hi Stephan,
> Deployment is disabled for PR builds and feature branches. I admit this
> would've been useful for you in this particular case, but I think it's
> reasonable to only build bleeding edge VMs from dev.

Why? Keeping them long doesn’t make sense, I agree, but just keeping what
was build the last few days would solve this

Stephan

Reply | Threaded
Open this post in threaded view
|

Re: Where are PR build results stored

fniephaus
 
On Sat, Mar 23, 2019 at 11:44 AM Stephan Eggermont <[hidden email]> wrote:

>
>
> Fabio Niephaus <[hidden email]> wrote:
> > Hi Stephan,
> > Deployment is disabled for PR builds and feature branches. I admit this
> > would've been useful for you in this particular case, but I think it's
> > reasonable to only build bleeding edge VMs from dev.
>
> Why? Keeping them long doesn’t make sense, I agree, but just keeping what
> was build the last few days would solve this
>
> Stephan
>

For feature branches, we could enable deployments. But so far, there
was no need for it.
Deploying pull request is quite dangerous actually. Someone could
steal our deployment certificates, API keys etc. by simply opening a
PR against our code base.

Fabio