Why implementors are getting all the text red?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Why implementors are getting all the text red?

stepharo
hi

May be this is a well known bug but now all the implementors are showed in red.
So I cannot film that.

Stef

Reply | Threaded
Open this post in threaded view
|

Re: Why implementors are getting all the text red?

Marcus Denker-4
It is a bug.

The alternative would be to continue to have the build failing on the CI often and the check of new submissions
8 out of 10 times… honestly it was not possible to continue with a broken setup like that.

        https://pharo.fogbugz.com/f/cases/17684/highlighting-broken-in-message-list-senders-off-implementors-of

We need to fix this next.

        Marcus

> On 24 Feb 2016, at 12:12, stepharo <[hidden email]> wrote:
>
> hi
>
> May be this is a well known bug but now all the implementors are showed in red.
> So I cannot film that.
>
> Stef
>
> <edehdbdi..png>


Reply | Threaded
Open this post in threaded view
|

Re: Why implementors are getting all the text red?

CyrilFerlicot
In reply to this post by stepharo
See
https://pharo.fogbugz.com/f/cases/17684/highlighting-broken-in-message-list-senders-off-implementors-of

On 24/02/2016 12:12, stepharo wrote:
> hi
>
> May be this is a well known bug but now all the implementors are showed
> in red.
> So I cannot film that.
>
> Stef
>

--
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France


signature.asc (817 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Why implementors are getting all the text red?

Guillermo Polito
In reply to this post by Marcus Denker-4
I put a slice in the inbox with a patch that seems to solve this. I duplicated some methods, so it should be reviewed/enhanced. But right not I have a meeting and I cannot continue to work on this until tomorrow.

On 02/24/2016 12:20 PM, Marcus Denker wrote:
It is a bug. 

The alternative would be to continue to have the build failing on the CI often and the check of new submissions
8 out of 10 times… honestly it was not possible to continue with a broken setup like that.

	https://pharo.fogbugz.com/f/cases/17684/highlighting-broken-in-message-list-senders-off-implementors-of

We need to fix this next.

	Marcus

On 24 Feb 2016, at 12:12, stepharo [hidden email] wrote:

hi 

May be this is a well known bug but now all the implementors are showed in red. 
So I cannot film that.

Stef

<edehdbdi..png>


Reply | Threaded
Open this post in threaded view
|

Re: Why implementors are getting all the text red?

Marcus Denker-4
In reply to this post by Marcus Denker-4
Ah, of course there is a workaround to get back the old behaviour:


RubShoutStylerDecorator>>style: 

remove the 

aText size < 1000
        ifTrue: [ ^ self styler style: aText ].

after that it again styles everything in the background, which hides the bug.

Marcus

On 24 Feb 2016, at 12:20, Marcus Denker <[hidden email]> wrote:

It is a bug.

The alternative would be to continue to have the build failing on the CI often and the check of new submissions
8 out of 10 times… honestly it was not possible to continue with a broken setup like that.

https://pharo.fogbugz.com/f/cases/17684/highlighting-broken-in-message-list-senders-off-implementors-of

We need to fix this next.

Marcus

On 24 Feb 2016, at 12:12, stepharo <[hidden email]> wrote:

hi

May be this is a well known bug but now all the implementors are showed in red.
So I cannot film that.

Stef

<edehdbdi..png>


Reply | Threaded
Open this post in threaded view
|

Re: Why implementors are getting all the text red?

Marcus Denker-4
In reply to this post by Guillermo Polito
Very nice! I will check.


On 24 Feb 2016, at 12:40, Guille Polito <[hidden email]> wrote:

I put a slice in the inbox with a patch that seems to solve this. I duplicated some methods, so it should be reviewed/enhanced. But right not I have a meeting and I cannot continue to work on this until tomorrow.

On 02/24/2016 12:20 PM, Marcus Denker wrote:
It is a bug. 

The alternative would be to continue to have the build failing on the CI often and the check of new submissions
8 out of 10 times… honestly it was not possible to continue with a broken setup like that.

	https://pharo.fogbugz.com/f/cases/17684/highlighting-broken-in-message-list-senders-off-implementors-of

We need to fix this next.

	Marcus

On 24 Feb 2016, at 12:12, stepharo [hidden email] wrote:

hi 

May be this is a well known bug but now all the implementors are showed in red. 
So I cannot film that.

Stef

<edehdbdi..png>

    


Reply | Threaded
Open this post in threaded view
|

Re: Why implementors are getting all the text red?

stepharo
In reply to this post by Guillermo Polito
Tx guille

Stef


Le 24/2/16 12:40, Guille Polito a écrit :
I put a slice in the inbox with a patch that seems to solve this. I duplicated some methods, so it should be reviewed/enhanced. But right not I have a meeting and I cannot continue to work on this until tomorrow.

On 02/24/2016 12:20 PM, Marcus Denker wrote:
It is a bug. 

The alternative would be to continue to have the build failing on the CI often and the check of new submissions
8 out of 10 times… honestly it was not possible to continue with a broken setup like that.

	https://pharo.fogbugz.com/f/cases/17684/highlighting-broken-in-message-list-senders-off-implementors-of

We need to fix this next.

	Marcus

On 24 Feb 2016, at 12:12, stepharo [hidden email] wrote:

hi 

May be this is a well known bug but now all the implementors are showed in red. 
So I cannot film that.

Stef

<edehdbdi..png>