Writeup: how to contribute to Pharo

Hi,

I am now able to use iceberg on windows, thanks for the help.

But I am still a bit unsure about how the review and contribution workflow should work.

up to pharo 6 I just load a latest image,
- load the slice from a fogbugz number and was able to review the change

- or create a slice and upload it to the inbox

in pharo 7

- what is the equivalent to "getting the latest image" (and being able to load and review a fix),

   up to pharo 6 I just

    - load the latest image in pharolauncher (or from the command line).

    - opened the inbox repository.

    - load and review change/fix

    - throw away this change (close image without save)

    - reopen that image to move on with the next item to review.

    But now, do I have to update my local branch for every new pull request ? And how do I do this ? In other git project I would, I would

    fetch upstream, checkout master, merge with upstream/master, push the master to my fork origin

   How should this be done with my pharo 7 fork ? (And do we only work on the development brach instead of the master)?

 
   And do I this only in the command line or do I manage my fork (and keep it up to date) from within pharo with iceberg ?

   How do I actually access the pull requests from within pharo ? Maybe I am stupid, but I just can not find it.

   I would like do this steps, (as I was used to it from the prior contribution process, by loading code from the inbox)

   - Just look at the changes

   - apply the changes

   - throw away this changes, and move one with the next fix review

And the same for creating a fix / pull request. Do I need to be up to date with my own fork, or only the local copy of the pharo repository ?

Again, for pharo 6 I would just load a latest image, make my changes / code fixes and create a slice. Save to the inbox -> done.

And looking at iceberg, I have really no clue how to upload a fix.

I see that other people are using the new process, and I feel a bit lost and closed out of the pharo 7 development process, as I am at the moment unable to understand how this work.

Are there any other resources I missed ?

2017-08-11 19:30 GMT+02:00 Stephane Ducasse <[hidden email]>:

Nicolai 

I started super simple. I clone and point my fresh dled image to the use the clone.

Then I can do simple PR and review the issues. 

I will do the installation several times to learn (but not clone). 

I'm not sure that it is needed but I have

cd   /Users/ducasse/Library/Preferences/pharo/7.0

 

StartupPreferencesLoader default executeAtomicItems: {

        StartupAction

                name: 'Git Settings'

                code: [

                        FileStream stdout

                                cr; nextPutAll: 'Setting the ssh credentials'; cr.

                        Iceberg enableMetacelloIntegration: true.

                        IceCredentialsProvider useCustomSsh: true.

                        IceCredentialsProvider sshCredentials

                                        username: 'git';

                                        publicKey: '/Users/ducasse/.ssh/id_rsa.pub';

                                        privateKey: '/Users/ducasse/.ssh/id_rsa'.

                        IceCredentialsProvider

                                plaintextCredentials: (IcePlaintextCredentials new username: 'Ducasse'; password: 'xxxx' ; yourself ).

                        FileStream stdout

                                cr; nextPutAll: 'Finished'; cr ].

}.

On Fri, Aug 11, 2017 at 9:46 AM, Guillermo Polito <[hidden email]> wrote:

I extended the document with some windows specific instructions also.

On Fri, Aug 11, 2017 at 9:31 AM, Guillermo Polito <[hidden email]> wrote:

On Fri, Aug 11, 2017 at 12:34 AM, Nicolai Hess <[hidden email]> wrote:

2017-08-10 17:17 GMT+02:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

In option 2, I think this should be "Click on the Edit button",

Thanks, fixed! 

 

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

2017-08-31 20:05 GMT+02:00 Stephane Ducasse <[hidden email]>:

Hi nicolai

here is what I do. 

I always download the latest image via a bash script because updating can fail since loading package without a baseline may break.

After I use the set up described by guille blog post and I reuse my downloaded clone (to avoid to trash my SSD). 

Esteban told me that he will do a video:

- for producing a PR

- for reviewing 

Stef

Thanks, that would be great. looking forward to it, but for now I think I will quit trying this. It is too frustrating. I can not even try to explore icebergs functionality because it is crashing all the time.

 

On Thu, Aug 31, 2017 at 12:06 AM, Nicolai Hess <[hidden email]> wrote:

Hi,

I am now able to use iceberg on windows, thanks for the help.

But I am still a bit unsure about how the review and contribution workflow should work.

up to pharo 6 I just load a latest image,
- load the slice from a fogbugz number and was able to review the change

- or create a slice and upload it to the inbox

in pharo 7

- what is the equivalent to "getting the latest image" (and being able to load and review a fix),

   up to pharo 6 I just

    - load the latest image in pharolauncher (or from the command line).

    - opened the inbox repository.

    - load and review change/fix

    - throw away this change (close image without save)

    - reopen that image to move on with the next item to review.

    But now, do I have to update my local branch for every new pull request ? And how do I do this ? In other git project I would, I would

    fetch upstream, checkout master, merge with upstream/master, push the master to my fork origin

   How should this be done with my pharo 7 fork ? (And do we only work on the development brach instead of the master)?

 
   And do I this only in the command line or do I manage my fork (and keep it up to date) from within pharo with iceberg ?

   How do I actually access the pull requests from within pharo ? Maybe I am stupid, but I just can not find it.

   I would like do this steps, (as I was used to it from the prior contribution process, by loading code from the inbox)

   - Just look at the changes

   - apply the changes

   - throw away this changes, and move one with the next fix review

And the same for creating a fix / pull request. Do I need to be up to date with my own fork, or only the local copy of the pharo repository ?

Again, for pharo 6 I would just load a latest image, make my changes / code fixes and create a slice. Save to the inbox -> done.

And looking at iceberg, I have really no clue how to upload a fix.

I see that other people are using the new process, and I feel a bit lost and closed out of the pharo 7 development process, as I am at the moment unable to understand how this work.

Are there any other resources I missed ?

2017-08-11 19:30 GMT+02:00 Stephane Ducasse <[hidden email]>:

Nicolai 

I started super simple. I clone and point my fresh dled image to the use the clone.

Then I can do simple PR and review the issues. 

I will do the installation several times to learn (but not clone). 

I'm not sure that it is needed but I have

cd   /Users/ducasse/Library/Preferences/pharo/7.0

 

StartupPreferencesLoader default executeAtomicItems: {

        StartupAction

                name: 'Git Settings'

                code: [

                        FileStream stdout

                                cr; nextPutAll: 'Setting the ssh credentials'; cr.

                        Iceberg enableMetacelloIntegration: true.

                        IceCredentialsProvider useCustomSsh: true.

                        IceCredentialsProvider sshCredentials

                                        username: 'git';

                                        publicKey: '/Users/ducasse/.ssh/id_rsa.pub';

                                        privateKey: '/Users/ducasse/.ssh/id_rsa'.

                        IceCredentialsProvider

                                plaintextCredentials: (IcePlaintextCredentials new username: 'Ducasse'; password: 'xxxx' ; yourself ).

                        FileStream stdout

                                cr; nextPutAll: 'Finished'; cr ].

}.

On Fri, Aug 11, 2017 at 9:46 AM, Guillermo Polito <[hidden email]> wrote:

I extended the document with some windows specific instructions also.

On Fri, Aug 11, 2017 at 9:31 AM, Guillermo Polito <[hidden email]> wrote:

On Fri, Aug 11, 2017 at 12:34 AM, Nicolai Hess <[hidden email]> wrote:

2017-08-10 17:17 GMT+02:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

In option 2, I think this should be "Click on the Edit button",

Thanks, fixed! 

 

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: +33 06 52 70 66 13

which Pharo version (and Iceberg version) do you have?

Esteban

On 17 Oct 2017, at 04:36, Hernán Morales Durand <[hidden email]> wrote:

Hi Guille,

In https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

This part is not working for me: "Go back to iceberg, right click on the pharo repository and go to the Pharo entry. You'll see the option Create new branch from Fogbugz issue."

Because there is no such "Pharo" option in the menu. See the attached screenshot.

Did I miss something?

Any suggestion?

2017-08-10 12:17 GMT-03:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: +33 06 52 70 66 13

<Clipboard01.png>

Hi Esteban,

This one:

wget -O- get.pharo.org/70+vm | bash -

2017-10-17 3:36 GMT-03:00 Esteban Lorenzano <[hidden email]>:

which Pharo version (and Iceberg version) do you have?

Esteban

On 17 Oct 2017, at 04:36, Hernán Morales Durand <[hidden email]> wrote:

Hi Guille,

In https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

This part is not working for me: "Go back to iceberg, right click on the pharo repository and go to the Pharo entry. You'll see the option Create new branch from Fogbugz issue."

Because there is no such "Pharo" option in the menu. See the attached screenshot.

Did I miss something?

Any suggestion?

2017-08-10 12:17 GMT-03:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: +33 06 52 70 66 13

<Clipboard01.png>

no is ok.

with the pharo version I know the iceberg version :)

anyway your problem is that the remote for pharo is bad.

you added [hidden email]:pharo/pharo.git and I do not think that exists. 

Correct one is: 

[hidden email]:pharo-project/pharo.git

Esteban

On 17 Oct 2017, at 11:51, Hernán Morales Durand <[hidden email]> wrote:

I don't see any easy way to find the Iceberg version.

Should I update Iceberg using this script also in Pharo 7?

"Restore defaults"
Iceberg enableMetacelloIntegration: false.
MetacelloPharo30Platform select.

"Update metacello"
Metacello new
  baseline: 'Metacello';
  repository: 'github://metacello/metacello:Pharo6.1/repository';
  onConflict: [:e | e useIncoming ];
  get;
  load.

"Update iceberg"
 #(
    'Iceberg-UI'
    'Iceberg-Plugin-GitHub'
    'Iceberg-Plugin'
    'Iceberg-Metacello-Integration'
    'Iceberg-Libgit-Tonel'
    'Iceberg-Libgit-Filetree'
    'Iceberg-Libgit'
    'Iceberg'
    'LibGit-Core')
do: [ :each | (each asPackageIfAbsent: [ nil ]) ifNotNil: #removeFromSystem ].
Metacello new
      baseline: 'Iceberg';
      repository: 'github://pharo-vcs/iceberg:v0.6';
      load.

2017-10-17 6:46 GMT-03:00 Hernán Morales Durand <[hidden email]>:

Hi Esteban,

This one:

wget -O- get.pharo.org/70+vm | bash -

2017-10-17 3:36 GMT-03:00 Esteban Lorenzano <[hidden email]>:

which Pharo version (and Iceberg version) do you have?

Esteban

On 17 Oct 2017, at 04:36, Hernán Morales Durand <[hidden email]> wrote:

Hi Guille,

In https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

This part is not working for me: "Go back to iceberg, right click on the pharo repository and go to the Pharo entry. You'll see the option Create new branch from Fogbugz issue."

Because there is no such "Pharo" option in the menu. See the attached screenshot.

Did I miss something?

Any suggestion?

2017-08-10 12:17 GMT-03:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: +33 06 52 70 66 13

<Clipboard01.png>

no is ok.

with the pharo version I know the iceberg version :)

anyway your problem is that the remote for pharo is bad.

you added [hidden email]:pharo/pharo.git and I do not think that exists. 

Correct one is: 

[hidden email]:pharo-project/pharo.git

Esteban

On 17 Oct 2017, at 11:51, Hernán Morales Durand <[hidden email]> wrote:

I don't see any easy way to find the Iceberg version.

Should I update Iceberg using this script also in Pharo 7?

"Restore defaults"
Iceberg enableMetacelloIntegration: false.
MetacelloPharo30Platform select.

"Update metacello"
Metacello new
  baseline: 'Metacello';
  repository: 'github://metacello/metacello:Pharo6.1/repository';
  onConflict: [:e | e useIncoming ];
  get;
  load.

"Update iceberg"
 #(
    'Iceberg-UI'
    'Iceberg-Plugin-GitHub'
    'Iceberg-Plugin'
    'Iceberg-Metacello-Integration'
    'Iceberg-Libgit-Tonel'
    'Iceberg-Libgit-Filetree'
    'Iceberg-Libgit'
    'Iceberg'
    'LibGit-Core')
do: [ :each | (each asPackageIfAbsent: [ nil ]) ifNotNil: #removeFromSystem ].
Metacello new
      baseline: 'Iceberg';
      repository: 'github://pharo-vcs/iceberg:v0.6';
      load.

2017-10-17 6:46 GMT-03:00 Hernán Morales Durand <[hidden email]>:

Hi Esteban,

This one:

wget -O- get.pharo.org/70+vm | bash -

2017-10-17 3:36 GMT-03:00 Esteban Lorenzano <[hidden email]>:

which Pharo version (and Iceberg version) do you have?

Esteban

On 17 Oct 2017, at 04:36, Hernán Morales Durand <[hidden email]> wrote:

Hi Guille,

In https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

This part is not working for me: "Go back to iceberg, right click on the pharo repository and go to the Pharo entry. You'll see the option Create new branch from Fogbugz issue."

Because there is no such "Pharo" option in the menu. See the attached screenshot.

Did I miss something?

Any suggestion?

2017-08-10 12:17 GMT-03:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

<Clipboard01.png>

On Tue, Oct 17, 2017 at 12:42 PM, Hernán Morales Durand <[hidden email]> wrote:

Thank you Esteban, that was the problem! :)

Maybe guille wants to clarify the correct remote repository in the page: https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo after "You can click on the Add remote option and configure a remote with a name and repository url."

Done that.

Can you check if that's ok?

 

Another thing. I created a PR with a fix for this bug : https://pharo.fogbugz.com/f/cases/17754/CheckBoxModel-RadioButtonModel-ignore-disable following the guide to the Step 3. However I couldn't view any PR in my Github page (see attach).

Do I miss something?

2017-10-17 6:53 GMT-03:00 Esteban Lorenzano <[hidden email]>:

no is ok.

with the pharo version I know the iceberg version :)

anyway your problem is that the remote for pharo is bad.

you added [hidden email]:pharo/pharo.git and I do not think that exists. 

Correct one is: 

[hidden email]:pharo-project/pharo.git

Esteban

On 17 Oct 2017, at 11:51, Hernán Morales Durand <[hidden email]> wrote:

I don't see any easy way to find the Iceberg version.

Should I update Iceberg using this script also in Pharo 7?

"Restore defaults"
Iceberg enableMetacelloIntegration: false.
MetacelloPharo30Platform select.

"Update metacello"
Metacello new
  baseline: 'Metacello';
  repository: 'github://metacello/metacello:Pharo6.1/repository';
  onConflict: [:e | e useIncoming ];
  get;
  load.

"Update iceberg"
 #(
    'Iceberg-UI'
    'Iceberg-Plugin-GitHub'
    'Iceberg-Plugin'
    'Iceberg-Metacello-Integration'
    'Iceberg-Libgit-Tonel'
    'Iceberg-Libgit-Filetree'
    'Iceberg-Libgit'
    'Iceberg'
    'LibGit-Core')
do: [ :each | (each asPackageIfAbsent: [ nil ]) ifNotNil: #removeFromSystem ].
Metacello new
      baseline: 'Iceberg';
      repository: 'github://pharo-vcs/iceberg:v0.6';
      load.

2017-10-17 6:46 GMT-03:00 Hernán Morales Durand <[hidden email]>:

Hi Esteban,

This one:

wget -O- get.pharo.org/70+vm | bash -

2017-10-17 3:36 GMT-03:00 Esteban Lorenzano <[hidden email]>:

which Pharo version (and Iceberg version) do you have?

Esteban

On 17 Oct 2017, at 04:36, Hernán Morales Durand <[hidden email]> wrote:

Hi Guille,

In https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

This part is not working for me: "Go back to iceberg, right click on the pharo repository and go to the Pharo entry. You'll see the option Create new branch from Fogbugz issue."

Because there is no such "Pharo" option in the menu. See the attached screenshot.

Did I miss something?

Any suggestion?

2017-08-10 12:17 GMT-03:00 Guillermo Polito <[hidden email]>:

Hi, 

I've made some write up for the pharo part (not metacello or external projects)

https://github.com/guillep/PharoIntegrationProcess/wiki/Contribute-a-fix-to-Pharo

Of course, expect bugs on it :) Not everything is smooth. If you have comments, they are welcome.

Guille

--

Guille Polito Research Engineer French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: <a href="tel:+33%206%2052%2070%2066%2013" value="+33652706613" target="_blank">+33 06 52 70 66 13

<Clipboard01.png>

--

Guille Polito Research Engineer Centre de Recherche en Informatique, Signal et Automatique de Lille CRIStAL - UMR 9189 French National Center for Scientific Research - http://www.cnrs.fr Web: http://guillep.github.io Phone: +33 06 52 70 66 13