XML Parser bug when doing multibyte parsing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

XML Parser bug when doing multibyte parsing

NorbertHartl
Name: XML-Parser.g-NorbertHartl.118
Author: NorbertHartl
Time: 07/28/2011, 17:45:54
UUID: 8db11b01-2933-4c04-838b-69171e4511ee
Ancestors: XML-Parser.g-NorbertHartl.117

Fixed a multibyte bug in splitQualifiedNameInto:

In CharacterCollection the splitted prefix returned nil and in String it returned ''. In case a String is converted to Double- or QuadByteString _and_ there are nested elements than it breaks on resolving the prefix for the nested closing tag.

Changed the CharacterCollection method to return empty string and removed the impl in String. A test has been added to the Test package

---

Name: XML-Tests-Parser-NorbertHartl.13
Author: NorbertHartl
Time: 07/28/2011, 17:47:20
UUID: bfa97282-a6b0-4619-bc6d-44161fd70925
Ancestors: XML-Tests-Parser-JohanBrichau.12

aded test for splitQualifiedNameInto: bug in multibyte context.

---

FYI,

Norbert

Reply | Threaded
Open this post in threaded view
|

Re: XML Parser bug when doing multibyte parsing

Dale Henrichs
Marvelous! I don't want to discourage bugfixes, but if you could tie your bugfixes to a bugreport (i.e., create one if it doesn't exist) that would help with the book keeping when I start pulling things together for a release ...

I can use the bug reports to find the mcz files with the fixes or use the mcz (with a bug number in the comment) to find the bug report with the discussion and additional info on the bug ...

Thanks,

Dale

----- Original Message -----
| From: "Norbert Hartl" <[hidden email]>
| To: "GemStone Seaside beta discussion" <[hidden email]>
| Sent: Thursday, July 28, 2011 8:49:39 AM
| Subject: [GS/SS Beta] XML Parser bug when doing multibyte parsing
|
| Name: XML-Parser.g-NorbertHartl.118
| Author: NorbertHartl
| Time: 07/28/2011, 17:45:54
| UUID: 8db11b01-2933-4c04-838b-69171e4511ee
| Ancestors: XML-Parser.g-NorbertHartl.117
|
| Fixed a multibyte bug in splitQualifiedNameInto:
|
| In CharacterCollection the splitted prefix returned nil and in String
| it returned ''. In case a String is converted to Double- or
| QuadByteString _and_ there are nested elements than it breaks on
| resolving the prefix for the nested closing tag.
|
| Changed the CharacterCollection method to return empty string and
| removed the impl in String. A test has been added to the Test
| package
|
| ---
|
| Name: XML-Tests-Parser-NorbertHartl.13
| Author: NorbertHartl
| Time: 07/28/2011, 17:47:20
| UUID: bfa97282-a6b0-4619-bc6d-44161fd70925
| Ancestors: XML-Tests-Parser-JohanBrichau.12
|
| aded test for splitQualifiedNameInto: bug in multibyte context.
|
| ---
|
| FYI,
|
| Norbert
|
|
Reply | Threaded
Open this post in threaded view
|

Re: XML Parser bug when doing multibyte parsing

NorbertHartl
You're right. I will do better next time.

Sorry,

Norbert

Am 29.07.2011 um 18:28 schrieb Dale Henrichs:

> Marvelous! I don't want to discourage bugfixes, but if you could tie your bugfixes to a bugreport (i.e., create one if it doesn't exist) that would help with the book keeping when I start pulling things together for a release ...
>
> I can use the bug reports to find the mcz files with the fixes or use the mcz (with a bug number in the comment) to find the bug report with the discussion and additional info on the bug ...
>
> Thanks,
>
> Dale
>
> ----- Original Message -----
> | From: "Norbert Hartl" <[hidden email]>
> | To: "GemStone Seaside beta discussion" <[hidden email]>
> | Sent: Thursday, July 28, 2011 8:49:39 AM
> | Subject: [GS/SS Beta] XML Parser bug when doing multibyte parsing
> |
> | Name: XML-Parser.g-NorbertHartl.118
> | Author: NorbertHartl
> | Time: 07/28/2011, 17:45:54
> | UUID: 8db11b01-2933-4c04-838b-69171e4511ee
> | Ancestors: XML-Parser.g-NorbertHartl.117
> |
> | Fixed a multibyte bug in splitQualifiedNameInto:
> |
> | In CharacterCollection the splitted prefix returned nil and in String
> | it returned ''. In case a String is converted to Double- or
> | QuadByteString _and_ there are nested elements than it breaks on
> | resolving the prefix for the nested closing tag.
> |
> | Changed the CharacterCollection method to return empty string and
> | removed the impl in String. A test has been added to the Test
> | package
> |
> | ---
> |
> | Name: XML-Tests-Parser-NorbertHartl.13
> | Author: NorbertHartl
> | Time: 07/28/2011, 17:47:20
> | UUID: bfa97282-a6b0-4619-bc6d-44161fd70925
> | Ancestors: XML-Tests-Parser-JohanBrichau.12
> |
> | aded test for splitQualifiedNameInto: bug in multibyte context.
> |
> | ---
> |
> | FYI,
> |
> | Norbert
> |
> |

Reply | Threaded
Open this post in threaded view
|

Re: XML Parser bug when doing multibyte parsing

Dale Henrichs
Norbert,

No need to be sorry ... there are no official guidelines, so it's on me not you:).

Dale

----- Original Message -----
| From: "Norbert Hartl" <[hidden email]>
| To: "GemStone Seaside beta discussion" <[hidden email]>
| Sent: Friday, July 29, 2011 10:33:27 AM
| Subject: Re: [GS/SS Beta] XML Parser bug when doing multibyte parsing
|
| You're right. I will do better next time.
|
| Sorry,
|
| Norbert
|
| Am 29.07.2011 um 18:28 schrieb Dale Henrichs:
|
| > Marvelous! I don't want to discourage bugfixes, but if you could
| > tie your bugfixes to a bugreport (i.e., create one if it doesn't
| > exist) that would help with the book keeping when I start pulling
| > things together for a release ...
| >
| > I can use the bug reports to find the mcz files with the fixes or
| > use the mcz (with a bug number in the comment) to find the bug
| > report with the discussion and additional info on the bug ...
| >
| > Thanks,
| >
| > Dale
| >
| > ----- Original Message -----
| > | From: "Norbert Hartl" <[hidden email]>
| > | To: "GemStone Seaside beta discussion"
| > | <[hidden email]>
| > | Sent: Thursday, July 28, 2011 8:49:39 AM
| > | Subject: [GS/SS Beta] XML Parser bug when doing multibyte parsing
| > |
| > | Name: XML-Parser.g-NorbertHartl.118
| > | Author: NorbertHartl
| > | Time: 07/28/2011, 17:45:54
| > | UUID: 8db11b01-2933-4c04-838b-69171e4511ee
| > | Ancestors: XML-Parser.g-NorbertHartl.117
| > |
| > | Fixed a multibyte bug in splitQualifiedNameInto:
| > |
| > | In CharacterCollection the splitted prefix returned nil and in
| > | String
| > | it returned ''. In case a String is converted to Double- or
| > | QuadByteString _and_ there are nested elements than it breaks on
| > | resolving the prefix for the nested closing tag.
| > |
| > | Changed the CharacterCollection method to return empty string and
| > | removed the impl in String. A test has been added to the Test
| > | package
| > |
| > | ---
| > |
| > | Name: XML-Tests-Parser-NorbertHartl.13
| > | Author: NorbertHartl
| > | Time: 07/28/2011, 17:47:20
| > | UUID: bfa97282-a6b0-4619-bc6d-44161fd70925
| > | Ancestors: XML-Tests-Parser-JohanBrichau.12
| > |
| > | aded test for splitQualifiedNameInto: bug in multibyte context.
| > |
| > | ---
| > |
| > | FYI,
| > |
| > | Norbert
| > |
| > |
|
|