XMLObjectSupport

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

XMLObjectSupport

Holger Kleinsorgen-4
Hi,

one constant source of confusion and deployment problems is package
XMLObjectSupport.

It adds some useful extensions to class XML.Node and subclass, like
#addAttribute:. It's tempting to use them, but if a package does not
include XMLObjectSupport as prerequisite, the deployed app will raise a
MNU. Moving these methods to base package XML would be a good thing IMHO.

It also has the nasty habit seen in other "Net"-related packages to
include an extension of VisualWorksSettings, which results in
dependencies from UI/Tools code.

SAXWriter #startElement:localName:qName:attributes: is overriden in
XMLObjectSupport, which is kind of odd. It should be either moved to
package XML or to a new sublass of SAXWriter (which can then be used
instead of SAXWriter at places where the change is required).

Cheers, Holger


Reply | Threaded
Open this post in threaded view
|

RE: XMLObjectSupport

Kogan, Tamara
Thanks for the comments.
Created:
51161: "Some improvements for the XMLObject package extensions"


Tamara Kogan
Smalltalk development,
Cincom Systems

> -----Original Message-----
> From: Holger Kleinsorgen [mailto:[hidden email]]
> Sent: Thursday, August 31, 2006 11:49 AM
> To: vwnc
> Subject: XMLObjectSupport
>
> Hi,
>
> one constant source of confusion and deployment problems is package
> XMLObjectSupport.
>
> It adds some useful extensions to class XML.Node and subclass, like
> #addAttribute:. It's tempting to use them, but if a package does not
> include XMLObjectSupport as prerequisite, the deployed app will raise
a
> MNU. Moving these methods to base package XML would be a good thing
IMHO.

>
> It also has the nasty habit seen in other "Net"-related packages to
> include an extension of VisualWorksSettings, which results in
> dependencies from UI/Tools code.
>
> SAXWriter #startElement:localName:qName:attributes: is overriden in
> XMLObjectSupport, which is kind of odd. It should be either moved to
> package XML or to a new sublass of SAXWriter (which can then be used
> instead of SAXWriter at places where the change is required).
>
> Cheers, Holger
>

Reply | Threaded
Open this post in threaded view
|

Re: XMLObjectSupport

Holger Kleinsorgen-4

> Thanks for the comments.
> Created:
> 51161: "Some improvements for the XMLObject package extensions"

Thanks for the AR! One more issue that I forgot in the last mail:
Element>>addAttribute: does not set the attribute's parent, contrary to
  Element>>addNode:.

Holger