a DNU on SmallInteger>>#add: workaround

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

a DNU on SmallInteger>>#add: workaround

EstebanLM
Hi,

Thanks to Usman, I found a problem in the VM with some kind of assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in

GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser:

you might want to workaround it also. You just need to change:

                                self
                                        renderCustomRow: each
                                        ofPane: aPane
                                        inUI: (pane := GLMMorphic containerMorph)
                                        inBrowser: aBrowser.

for:

                                pane := GLMMorphic containerMorph.
                                self
                                        renderCustomRow: each
                                        ofPane: aPane
                                        inUI: pane
                                        inBrowser: aBrowser.

yes, I know...this whould work, and *will* work, but in the mean time...

cheers,
Esteban
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: a DNU on SmallInteger>>#add: workaround

Tudor Girba-2
Hi Esteban,

Thanks a lot. I committed the fix in Glamour. It is anyway a nicer practice to have the assignment separate.

But, concerning Metacello: Is there anything we should do to benefit from the fixes?

Cheers,
Doru


On Apr 24, 2013, at 6:39 PM, Esteban Lorenzano <[hidden email]> wrote:

> Hi,
>
> Thanks to Usman, I found a problem in the VM with some kind of assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in
>
> GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser:
>
> you might want to workaround it also. You just need to change:
>
> self
> renderCustomRow: each
> ofPane: aPane
> inUI: (pane := GLMMorphic containerMorph)
> inBrowser: aBrowser.
>
> for:
>
> pane := GLMMorphic containerMorph.
> self
> renderCustomRow: each
> ofPane: aPane
> inUI: pane
> inBrowser: aBrowser.
>
> yes, I know...this whould work, and *will* work, but in the mean time...
>
> cheers,
> Esteban
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every thing should have the right to be different."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: a DNU on SmallInteger>>#add: workaround

EstebanLM
the fix will be on latest 3.0 and backported to 2.0, I suppose tomorrow.
you could take the slice and apply it by yourself too if you want.... is 10396, if my memory doesn't betray me :)

Esteban

On Apr 24, 2013, at 9:27 PM, Tudor Girba <[hidden email]> wrote:

> Hi Esteban,
>
> Thanks a lot. I committed the fix in Glamour. It is anyway a nicer practice to have the assignment separate.
>
> But, concerning Metacello: Is there anything we should do to benefit from the fixes?
>
> Cheers,
> Doru
>
>
> On Apr 24, 2013, at 6:39 PM, Esteban Lorenzano <[hidden email]> wrote:
>
>> Hi,
>>
>> Thanks to Usman, I found a problem in the VM with some kind of assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in
>>
>> GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser:
>>
>> you might want to workaround it also. You just need to change:
>>
>> self
>> renderCustomRow: each
>> ofPane: aPane
>> inUI: (pane := GLMMorphic containerMorph)
>> inBrowser: aBrowser.
>>
>> for:
>>
>> pane := GLMMorphic containerMorph.
>> self
>> renderCustomRow: each
>> ofPane: aPane
>> inUI: pane
>> inBrowser: aBrowser.
>>
>> yes, I know...this whould work, and *will* work, but in the mean time...
>>
>> cheers,
>> Esteban
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Every thing should have the right to be different."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: a DNU on SmallInteger>>#add: workaround

Usman Bhatti
tx a lot Esteban for fixing this.


On Wed, Apr 24, 2013 at 10:20 PM, Esteban Lorenzano <[hidden email]> wrote:
the fix will be on latest 3.0 and backported to 2.0, I suppose tomorrow.
you could take the slice and apply it by yourself too if you want.... is 10396, if my memory doesn't betray me :)

Esteban

On Apr 24, 2013, at 9:27 PM, Tudor Girba <[hidden email]> wrote:

> Hi Esteban,
>
> Thanks a lot. I committed the fix in Glamour. It is anyway a nicer practice to have the assignment separate.
>
> But, concerning Metacello: Is there anything we should do to benefit from the fixes?
>
> Cheers,
> Doru
>
>
> On Apr 24, 2013, at 6:39 PM, Esteban Lorenzano <[hidden email]> wrote:
>
>> Hi,
>>
>> Thanks to Usman, I found a problem in the VM with some kind of assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in
>>
>> GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser:
>>
>> you might want to workaround it also. You just need to change:
>>
>>                              self
>>                                      renderCustomRow: each
>>                                      ofPane: aPane
>>                                      inUI: (pane := GLMMorphic containerMorph)
>>                                      inBrowser: aBrowser.
>>
>> for:
>>
>>                              pane := GLMMorphic containerMorph.
>>                              self
>>                                      renderCustomRow: each
>>                                      ofPane: aPane
>>                                      inUI: pane
>>                                      inBrowser: aBrowser.
>>
>> yes, I know...this whould work, and *will* work, but in the mean time...
>>
>> cheers,
>> Esteban
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Every thing should have the right to be different."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: a DNU on SmallInteger>>#add: workaround

Tudor Girba-2
Indeed, thanks a lot.

Regarding the integration, the issue is not pressing us, and once it is backported to 2.0, we should get it in the build given that we use the very latest version of Pharo (both image and vm).

Cheers,
Doru


On Apr 24, 2013, at 11:03 PM, Usman Bhatti <[hidden email]> wrote:

> tx a lot Esteban for fixing this.
>
>
> On Wed, Apr 24, 2013 at 10:20 PM, Esteban Lorenzano <[hidden email]> wrote:
> the fix will be on latest 3.0 and backported to 2.0, I suppose tomorrow.
> you could take the slice and apply it by yourself too if you want.... is 10396, if my memory doesn't betray me :)
>
> Esteban
>
> On Apr 24, 2013, at 9:27 PM, Tudor Girba <[hidden email]> wrote:
>
> > Hi Esteban,
> >
> > Thanks a lot. I committed the fix in Glamour. It is anyway a nicer practice to have the assignment separate.
> >
> > But, concerning Metacello: Is there anything we should do to benefit from the fixes?
> >
> > Cheers,
> > Doru
> >
> >
> > On Apr 24, 2013, at 6:39 PM, Esteban Lorenzano <[hidden email]> wrote:
> >
> >> Hi,
> >>
> >> Thanks to Usman, I found a problem in the VM with some kind of assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in
> >>
> >> GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser:
> >>
> >> you might want to workaround it also. You just need to change:
> >>
> >>                              self
> >>                                      renderCustomRow: each
> >>                                      ofPane: aPane
> >>                                      inUI: (pane := GLMMorphic containerMorph)
> >>                                      inBrowser: aBrowser.
> >>
> >> for:
> >>
> >>                              pane := GLMMorphic containerMorph.
> >>                              self
> >>                                      renderCustomRow: each
> >>                                      ofPane: aPane
> >>                                      inUI: pane
> >>                                      inBrowser: aBrowser.
> >>
> >> yes, I know...this whould work, and *will* work, but in the mean time...
> >>
> >> cheers,
> >> Esteban
> >> _______________________________________________
> >> Moose-dev mailing list
> >> [hidden email]
> >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > --
> > www.tudorgirba.com
> >
> > "Every thing should have the right to be different."
> >
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"The coherence of a trip is given by the clearness of the goal."





_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev