about Grease: Color

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

about Grease: Color

Paolo Bonzini-2
Grease includes tests for a Color class.  In my opinion it should
provide a GRColor class (possibly just by taking Pharo's Color and
renaming it) in addition to this, since the class otherwise is
unprefixed.

The class is unused by Seaside, so maybe it's also possible to drop the test?

Paolo
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Grease: Color

Lukas Renggli
> Grease includes tests for a Color class.  In my opinion it should
> provide a GRColor class (possibly just by taking Pharo's Color and
> renaming it) in addition to this, since the class otherwise is
> unprefixed.
>
> The class is unused by Seaside, so maybe it's also possible to drop the test?

These tests are Pharo specific ('Grease-Tests-Pharo-Core'), so they
are not supposed to be ported.

Yeah, Color is rarely used. The only place I see real use is in some
Javascript functions that expect a color as an argument. In these
cases in Pharo you can just pass your color, but it also works to pass
a string like '#0fab23'.

Lukas

--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Grease: Color

Lukas Renggli
No I see, there is a test in Javascript-Tests-Core that tests a method
from Javascript-Pharo-Core.

I will move that to Javascript-Tests-Pharo-Core.

Is the problem solved like this?

Lukas

On 30 March 2010 08:16, Lukas Renggli <[hidden email]> wrote:

>> Grease includes tests for a Color class.  In my opinion it should
>> provide a GRColor class (possibly just by taking Pharo's Color and
>> renaming it) in addition to this, since the class otherwise is
>> unprefixed.
>>
>> The class is unused by Seaside, so maybe it's also possible to drop the test?
>
> These tests are Pharo specific ('Grease-Tests-Pharo-Core'), so they
> are not supposed to be ported.
>
> Yeah, Color is rarely used. The only place I see real use is in some
> Javascript functions that expect a color as an argument. In these
> cases in Pharo you can just pass your color, but it also works to pass
> a string like '#0fab23'.
>
> Lukas
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>



--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Grease: Color

Paolo Bonzini-3
On Tue, Mar 30, 2010 at 08:19, Lukas Renggli <[hidden email]> wrote:
> No I see, there is a test in Javascript-Tests-Core that tests a method
> from Javascript-Pharo-Core.
>
> I will move that to Javascript-Tests-Pharo-Core.
>
> Is the problem solved like this?

Yes, that's an alternative way.

Paolo
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev