about Rationalizing EntityState and DefaultEntityState (issue 195)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

about Rationalizing EntityState and DefaultEntityState (issue 195)

cdelaunay
Hello,

What I did for the moment:

renamed all the methods from EntityState with the convention of a dictionary (propertyAt: , cacheAt: , 
attributesAt: ). We kept the old ones as deprecated. 

I kept all previous methods as 'deprecated'. So normally, If I did that well, if your code is still using the old entityState API, you should have a 'deprecated' message re-directing you to the new API.

 

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Rationalizing EntityState and DefaultEntityState (issue 195)

Simon Denier-3

On 31 mai 2010, at 12:36, Cyrille Delaunay wrote:

Hello,

What I did for the moment:

renamed all the methods from EntityState with the convention of a dictionary (propertyAt: , cacheAt: , 
attributesAt: ). We kept the old ones as deprecated. 

I kept all previous methods as 'deprecated'. So normally, If I did that well, if your code is still using the old entityState API, you should have a 'deprecated' message re-directing you to the new API.

thanks!

Isn't there some changes in the MooseEntity API also?

--
 Simon




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Rationalizing EntityState and DefaultEntityState (issue 195)

cdelaunay
Yes also, and I just see that I didn't do it in a very safe way ...
I changed MooseEntity >> entityGroups by MooseEntity >> entityCache.
So this change can be the origin of some errors.
should I reimplement MooseEntity >> entityGroups as deprecated ?

2010/5/31 Simon Denier <[hidden email]>

On 31 mai 2010, at 12:36, Cyrille Delaunay wrote:

Hello,

What I did for the moment:

renamed all the methods from EntityState with the convention of a dictionary (propertyAt: , cacheAt: , 
attributesAt: ). We kept the old ones as deprecated. 

I kept all previous methods as 'deprecated'. So normally, If I did that well, if your code is still using the old entityState API, you should have a 'deprecated' message re-directing you to the new API.

thanks!

Isn't there some changes in the MooseEntity API also?

--
 Simon




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Rationalizing EntityState and DefaultEntityState (issue 195)

Simon Denier-3

On 31 mai 2010, at 14:16, Cyrille Delaunay wrote:

Yes also, and I just see that I didn't do it in a very safe way ...
I changed MooseEntity >> entityGroups by MooseEntity >> entityCache.
So this change can be the origin of some errors.
should I reimplement MooseEntity >> entityGroups as deprecated ?

yes please


2010/5/31 Simon Denier <[hidden email]>

On 31 mai 2010, at 12:36, Cyrille Delaunay wrote:

Hello,

What I did for the moment:

renamed all the methods from EntityState with the convention of a dictionary (propertyAt: , cacheAt: , 
attributesAt: ). We kept the old ones as deprecated. 

I kept all previous methods as 'deprecated'. So normally, If I did that well, if your code is still using the old entityState API, you should have a 'deprecated' message re-directing you to the new API.

thanks!

Isn't there some changes in the MooseEntity API also?

--
 Simon




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
 Simon




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: about Rationalizing EntityState and DefaultEntityState (issue 195)

Tudor Girba
Hi Cyrille,

Thanks for the effort. This cleaning was needed since a long time :).

And, yes, please add a deprecated entityGroups for the moment.

Cheers,
Doru

On 31 May 2010, at 16:20, Simon Denier wrote:

>
> On 31 mai 2010, at 14:16, Cyrille Delaunay wrote:
>
>> Yes also, and I just see that I didn't do it in a very safe way ...
>> I changed MooseEntity >> entityGroups by MooseEntity >> entityCache.
>> So this change can be the origin of some errors.
>> should I reimplement MooseEntity >> entityGroups as deprecated ?
>
> yes please
>
>>
>> 2010/5/31 Simon Denier <[hidden email]>
>>
>> On 31 mai 2010, at 12:36, Cyrille Delaunay wrote:
>>
>>> Hello,
>>>
>>> What I did for the moment:
>>>
>>> renamed all the methods from EntityState with the convention of a  
>>> dictionary (propertyAt: , cacheAt: ,
>>> attributesAt: ). We kept the old ones as deprecated.
>>>
>>> I kept all previous methods as 'deprecated'. So normally, If I did  
>>> that well, if your code is still using the old entityState API,  
>>> you should have a 'deprecated' message re-directing you to the new  
>>> API.
>>
>>
>> thanks!
>>
>> Isn't there some changes in the MooseEntity API also?
>>
>> --
>>  Simon
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
>  Simon
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Don't give to get. Just give."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev