about smacc gt extensions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

about smacc gt extensions

Stephane Ducasse-3
hi andrei and doru

I think that we should improve the gt extension of smacc. Right now when I have a token I do not see it when inspecting it in raw. 

The raw view should always show the object implementation.
After we can have other view. Now with the token this is super strange to get a string (or the result of value). because when you are exploring a tree
you want to know if this is a string or a token. 

As in the following attachment: the current situation is confusing. 
in the list I have a list of token and when I look at one, I get a string. 

Stef

Inline image 1

Reply | Threaded
Open this post in threaded view
|

Re: about smacc gt extensions

Tudor Girba-2
Hi Stef,

Indeed, the Raw view should only show the basic structure of the object.

But, the problem seems different in the screenshot you attached. You have an OrderedCollection of Tokens, and selecting one, gets the value of out it. This is an issue with the extension of SequenceableCollection and it affects also other objects that understand value, such as blocks.

I opened an issue:
https://pharo.fogbugz.com/f/cases/19867/GTInspector-extensions-for-items-of-a-SequenceableCollection-sends-an-extra-value

Cheers,
Doru


> On Mar 26, 2017, at 9:54 PM, Stephane Ducasse <[hidden email]> wrote:
>
> hi andrei and doru
>
> I think that we should improve the gt extension of smacc. Right now when I have a token I do not see it when inspecting it in raw.
>
> The raw view should always show the object implementation.
> After we can have other view. Now with the token this is super strange to get a string (or the result of value). because when you are exploring a tree
> you want to know if this is a string or a token.
>
> As in the following attachment: the current situation is confusing.
> in the list I have a list of token and when I look at one, I get a string.
>
> Stef
>
> <Screen Shot 2017-03-26 at 21.51.05.png>
>

--
www.tudorgirba.com
www.feenk.com

"One cannot do more than one can do."





Reply | Threaded
Open this post in threaded view
|

Re: about smacc gt extensions

Tudor Girba-2
I committed a fix upstream. It will appear in the image with the next GT integration.

Doru


> On Mar 27, 2017, at 9:36 AM, Tudor Girba <[hidden email]> wrote:
>
> Hi Stef,
>
> Indeed, the Raw view should only show the basic structure of the object.
>
> But, the problem seems different in the screenshot you attached. You have an OrderedCollection of Tokens, and selecting one, gets the value of out it. This is an issue with the extension of SequenceableCollection and it affects also other objects that understand value, such as blocks.
>
> I opened an issue:
> https://pharo.fogbugz.com/f/cases/19867/GTInspector-extensions-for-items-of-a-SequenceableCollection-sends-an-extra-value
>
> Cheers,
> Doru
>
>
>> On Mar 26, 2017, at 9:54 PM, Stephane Ducasse <[hidden email]> wrote:
>>
>> hi andrei and doru
>>
>> I think that we should improve the gt extension of smacc. Right now when I have a token I do not see it when inspecting it in raw.
>>
>> The raw view should always show the object implementation.
>> After we can have other view. Now with the token this is super strange to get a string (or the result of value). because when you are exploring a tree
>> you want to know if this is a string or a token.
>>
>> As in the following attachment: the current situation is confusing.
>> in the list I have a list of token and when I look at one, I get a string.
>>
>> Stef
>>
>> <Screen Shot 2017-03-26 at 21.51.05.png>
>>
>
> --
> www.tudorgirba.com
> www.feenk.com
>
> "One cannot do more than one can do."
>
>
>
>

--
www.tudorgirba.com
www.feenk.com

"Problem solving efficiency grows with the abstractness level of problem understanding."





Reply | Threaded
Open this post in threaded view
|

Re: about smacc gt extensions

Stephane Ducasse-3
Tx doru 
Yes this is the correct analysis.

On Mon, Mar 27, 2017 at 9:43 AM, Tudor Girba <[hidden email]> wrote:
I committed a fix upstream. It will appear in the image with the next GT integration.

Doru


> On Mar 27, 2017, at 9:36 AM, Tudor Girba <[hidden email]> wrote:
>
> Hi Stef,
>
> Indeed, the Raw view should only show the basic structure of the object.
>
> But, the problem seems different in the screenshot you attached. You have an OrderedCollection of Tokens, and selecting one, gets the value of out it. This is an issue with the extension of SequenceableCollection and it affects also other objects that understand value, such as blocks.
>
> I opened an issue:
> https://pharo.fogbugz.com/f/cases/19867/GTInspector-extensions-for-items-of-a-SequenceableCollection-sends-an-extra-value
>
> Cheers,
> Doru
>
>
>> On Mar 26, 2017, at 9:54 PM, Stephane Ducasse <[hidden email]> wrote:
>>
>> hi andrei and doru
>>
>> I think that we should improve the gt extension of smacc. Right now when I have a token I do not see it when inspecting it in raw.
>>
>> The raw view should always show the object implementation.
>> After we can have other view. Now with the token this is super strange to get a string (or the result of value). because when you are exploring a tree
>> you want to know if this is a string or a token.
>>
>> As in the following attachment: the current situation is confusing.
>> in the list I have a list of token and when I look at one, I get a string.
>>
>> Stef
>>
>> <Screen Shot 2017-03-26 at 21.51.05.png>
>>
>
> --
> www.tudorgirba.com
> www.feenk.com
>
> "One cannot do more than one can do."
>
>
>
>

--
www.tudorgirba.com
www.feenk.com

"Problem solving efficiency grows with the abstractness level of problem understanding."