arki changes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

arki changes

Tudor Girba
Hi Cyrille,

I noticed a recent commit in Arki-Reporter. It would be nice to get  
your efforts in this repository, but in this case, the commit is wrong:
1. you removed REPConcernSpecification class>>open (is this by any  
chance due to the overriding problem?)
2. you removed the error checking of the result computation which can  
easily break the whole report

Could you please take a look?

Cheers,
Doru

--
www.tudorgirba.com

"Yesterday is a fact.
  Tomorrow is a possibility.
  Today is a challenge."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

cdelaunay
Oups, it was a mistake. I shouldn't saved those changes.
Removing the error checking was for debuging  and all other changes are now saved in another package.
So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
Sorry

2010/8/17 Tudor Girba <[hidden email]>
Hi Cyrille,

I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
2. you removed the error checking of the result computation which can easily break the whole report

Could you please take a look?

Cheers,
Doru

--
www.tudorgirba.com

"Yesterday is a fact.
 Tomorrow is a possibility.
 Today is a challenge."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Tudor Girba
No stress, I just wanted to give feedback :).

But, it would make sense to get some of the work you are doing on the  
custom report in Arki. So, if you feel that something needs  
improvement, just raise the point or just commit. One thing I would  
like to make sure is that what you do works out of the box with the  
rest of the system.

Cheers,
Doru


On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:

> Oups, it was a mistake. I shouldn't saved those changes.
> Removing the error checking was for debuging  and all other changes  
> are now saved in another package.
> So don't take into account this commit. Am I able to remove it from  
> squeaksource by myself ?
> Sorry
>
> 2010/8/17 Tudor Girba <[hidden email]>
> Hi Cyrille,
>
> I noticed a recent commit in Arki-Reporter. It would be nice to get  
> your efforts in this repository, but in this case, the commit is  
> wrong:
> 1. you removed REPConcernSpecification class>>open (is this by any  
> chance due to the overriding problem?)
> 2. you removed the error checking of the result computation which  
> can easily break the whole report
>
> Could you please take a look?
>
> Cheers,
> Doru
>
> --
> www.tudorgirba.com
>
> "Yesterday is a fact.
>  Tomorrow is a possibility.
>  Today is a challenge."
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"We are all great at making mistakes."







_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

cdelaunay
I'm know working on a new fresh image to avoid problems :)
But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous). 

2010/8/17 Tudor Girba <[hidden email]>
No stress, I just wanted to give feedback :).

But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.

Cheers,
Doru



On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:

Oups, it was a mistake. I shouldn't saved those changes.
Removing the error checking was for debuging  and all other changes are now saved in another package.
So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
Sorry

2010/8/17 Tudor Girba <[hidden email]>
Hi Cyrille,

I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
2. you removed the error checking of the result computation which can easily break the whole report

Could you please take a look?

Cheers,
Doru

--
www.tudorgirba.com

"Yesterday is a fact.
 Tomorrow is a possibility.
 Today is a challenge."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"We are all great at making mistakes."








_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Tudor Girba
I also noticed a slowdown in the DSM.

What version of Mondrian are you using? I am using Mondrian-tg.540,  
because Mondrian-Alexandre_Bergel.541 has a bug when computing the  
blueprint.

Cheers,
Doru


On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:

> I'm know working on a new fresh image to avoid problems :)
> But I just noticed that opening a distributionMap is very very very  
> long! (whereas in my old image with an old version of moose, with  
> the same model, it was nearly instantaneous).
>
> 2010/8/17 Tudor Girba <[hidden email]>
> No stress, I just wanted to give feedback :).
>
> But, it would make sense to get some of the work you are doing on  
> the custom report in Arki. So, if you feel that something needs  
> improvement, just raise the point or just commit. One thing I would  
> like to make sure is that what you do works out of the box with the  
> rest of the system.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>
> Oups, it was a mistake. I shouldn't saved those changes.
> Removing the error checking was for debuging  and all other changes  
> are now saved in another package.
> So don't take into account this commit. Am I able to remove it from  
> squeaksource by myself ?
> Sorry
>
> 2010/8/17 Tudor Girba <[hidden email]>
> Hi Cyrille,
>
> I noticed a recent commit in Arki-Reporter. It would be nice to get  
> your efforts in this repository, but in this case, the commit is  
> wrong:
> 1. you removed REPConcernSpecification class>>open (is this by any  
> chance due to the overriding problem?)
> 2. you removed the error checking of the result computation which  
> can easily break the whole report
>
> Could you please take a look?
>
> Cheers,
> Doru
>
> --
> www.tudorgirba.com
>
> "Yesterday is a fact.
>  Tomorrow is a possibility.
>  Today is a challenge."
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "We are all great at making mistakes."
>
>
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every now and then stop and ask yourself if the war you're fighting  
is the right one."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

cdelaunay
I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time

2010/8/17 Tudor Girba <[hidden email]>
I also noticed a slowdown in the DSM.

What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.

Cheers,
Doru



On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:

I'm know working on a new fresh image to avoid problems :)
But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).

2010/8/17 Tudor Girba <[hidden email]>
No stress, I just wanted to give feedback :).

But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.

Cheers,
Doru



On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:

Oups, it was a mistake. I shouldn't saved those changes.
Removing the error checking was for debuging  and all other changes are now saved in another package.
So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
Sorry

2010/8/17 Tudor Girba <[hidden email]>
Hi Cyrille,

I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
2. you removed the error checking of the result computation which can easily break the whole report

Could you please take a look?

Cheers,
Doru

--
www.tudorgirba.com

"Yesterday is a fact.
 Tomorrow is a possibility.
 Today is a challenge."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"We are all great at making mistakes."








_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Every now and then stop and ask yourself if the war you're fighting is the right one."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Alexandre Bergel
Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.

Cheers,
Alexandre


On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:

> I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
>
> 2010/8/17 Tudor Girba <[hidden email]>
> I also noticed a slowdown in the DSM.
>
> What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>
> I'm know working on a new fresh image to avoid problems :)
> But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
>
> 2010/8/17 Tudor Girba <[hidden email]>
> No stress, I just wanted to give feedback :).
>
> But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>
> Oups, it was a mistake. I shouldn't saved those changes.
> Removing the error checking was for debuging  and all other changes are now saved in another package.
> So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
> Sorry
>
> 2010/8/17 Tudor Girba <[hidden email]>
> Hi Cyrille,
>
> I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
> 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
> 2. you removed the error checking of the result computation which can easily break the whole report
>
> Could you please take a look?
>
> Cheers,
> Doru
>
> --
> www.tudorgirba.com
>
> "Yesterday is a fact.
>  Tomorrow is a possibility.
>  Today is a challenge."
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "We are all great at making mistakes."
>
>
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Tudor Girba
In reply to this post by cdelaunay
Could you try using some versions back?

What was the version that you used in the previous image?

Cheers,
Doru


On 17 Aug 2010, at 15:31, Cyrille Delaunay wrote:

> I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-
> tg.540 now, it takes the same time
>
> 2010/8/17 Tudor Girba <[hidden email]>
> I also noticed a slowdown in the DSM.
>
> What version of Mondrian are you using? I am using Mondrian-tg.540,  
> because Mondrian-Alexandre_Bergel.541 has a bug when computing the  
> blueprint.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>
> I'm know working on a new fresh image to avoid problems :)
> But I just noticed that opening a distributionMap is very very very  
> long! (whereas in my old image with an old version of moose, with  
> the same model, it was nearly instantaneous).
>
> 2010/8/17 Tudor Girba <[hidden email]>
> No stress, I just wanted to give feedback :).
>
> But, it would make sense to get some of the work you are doing on  
> the custom report in Arki. So, if you feel that something needs  
> improvement, just raise the point or just commit. One thing I would  
> like to make sure is that what you do works out of the box with the  
> rest of the system.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>
> Oups, it was a mistake. I shouldn't saved those changes.
> Removing the error checking was for debuging  and all other changes  
> are now saved in another package.
> So don't take into account this commit. Am I able to remove it from  
> squeaksource by myself ?
> Sorry
>
> 2010/8/17 Tudor Girba <[hidden email]>
> Hi Cyrille,
>
> I noticed a recent commit in Arki-Reporter. It would be nice to get  
> your efforts in this repository, but in this case, the commit is  
> wrong:
> 1. you removed REPConcernSpecification class>>open (is this by any  
> chance due to the overriding problem?)
> 2. you removed the error checking of the result computation which  
> can easily break the whole report
>
> Could you please take a look?
>
> Cheers,
> Doru
>
> --
> www.tudorgirba.com
>
> "Yesterday is a fact.
>  Tomorrow is a possibility.
>  Today is a challenge."
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "We are all great at making mistakes."
>
>
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Every now and then stop and ask yourself if the war you're fighting  
> is the right one."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Beauty is where we see it."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

cdelaunay
In reply to this post by Alexandre Bergel
I used Mondrian-Alexandre_Bergel.531.
It start to take time with Mondrian-Alexandre_Bergel.532.
I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent


2010/8/17 Alexandre Bergel <[hidden email]>
Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.

Cheers,
Alexandre


On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:

> I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
>
> 2010/8/17 Tudor Girba <[hidden email]>
> I also noticed a slowdown in the DSM.
>
> What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>
> I'm know working on a new fresh image to avoid problems :)
> But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
>
> 2010/8/17 Tudor Girba <[hidden email]>
> No stress, I just wanted to give feedback :).
>
> But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
>
> Cheers,
> Doru
>
>
>
> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>
> Oups, it was a mistake. I shouldn't saved those changes.
> Removing the error checking was for debuging  and all other changes are now saved in another package.
> So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
> Sorry
>
> 2010/8/17 Tudor Girba <[hidden email]>
> Hi Cyrille,
>
> I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
> 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
> 2. you removed the error checking of the result computation which can easily break the whole report
>
> Could you please take a look?
>
> Cheers,
> Doru
>
> --
> www.tudorgirba.com
>
> "Yesterday is a fact.
>  Tomorrow is a possibility.
>  Today is a challenge."
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "We are all great at making mistakes."
>
>
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Alexandre Bergel
> I used Mondrian-Alexandre_Bergel.531.
> It start to take time with Mondrian-Alexandre_Bergel.532.
> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent

Ok. So, if I understand correctly, the slowdown you experience stems from Mondrian. There is also a problem with the popup.
I promise to work on this this week end!

Cheers,
Alexandre


>
>
> 2010/8/17 Alexandre Bergel <[hidden email]>
> Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.
>
> Cheers,
> Alexandre
>
>
> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>
> > I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
> >
> > 2010/8/17 Tudor Girba <[hidden email]>
> > I also noticed a slowdown in the DSM.
> >
> > What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
> >
> > Cheers,
> > Doru
> >
> >
> >
> > On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
> >
> > I'm know working on a new fresh image to avoid problems :)
> > But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
> >
> > 2010/8/17 Tudor Girba <[hidden email]>
> > No stress, I just wanted to give feedback :).
> >
> > But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
> >
> > Cheers,
> > Doru
> >
> >
> >
> > On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
> >
> > Oups, it was a mistake. I shouldn't saved those changes.
> > Removing the error checking was for debuging  and all other changes are now saved in another package.
> > So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
> > Sorry
> >
> > 2010/8/17 Tudor Girba <[hidden email]>
> > Hi Cyrille,
> >
> > I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
> > 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
> > 2. you removed the error checking of the result computation which can easily break the whole report
> >
> > Could you please take a look?
> >
> > Cheers,
> > Doru
> >
> > --
> > www.tudorgirba.com
> >
> > "Yesterday is a fact.
> >  Tomorrow is a possibility.
> >  Today is a challenge."
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > --
> > www.tudorgirba.com
> >
> > "We are all great at making mistakes."
> >
> >
> >
> >
> >
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > --
> > www.tudorgirba.com
> >
> > "Every now and then stop and ask yourself if the war you're fighting is the right one."
> >
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Tudor Girba
In reply to this post by cdelaunay
Alex, could you quickly take a look at this? It looks to be related to  
the ChildrenShape refactoring. Given that the DistributionMap is  
heavily using nesting, this is a good testbed.

Cheers,
Doru

On 17 Aug 2010, at 15:50, Cyrille Delaunay wrote:

> I used Mondrian-Alexandre_Bergel.531.
> It start to take time with Mondrian-Alexandre_Bergel.532.
> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent
>
>
> 2010/8/17 Alexandre Bergel <[hidden email]>
> Do you want me to have a look at it?  I do not have much time (I  
> have a major deadline this Friday), but I can give a hand if it is  
> necessary and urgent.
>
> Cheers,
> Alexandre
>
>
> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>
> > I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-
> tg.540 now, it takes the same time
> >
> > 2010/8/17 Tudor Girba <[hidden email]>
> > I also noticed a slowdown in the DSM.
> >
> > What version of Mondrian are you using? I am using Mondrian-tg.
> 540, because Mondrian-Alexandre_Bergel.541 has a bug when computing  
> the blueprint.
> >
> > Cheers,
> > Doru
> >
> >
> >
> > On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
> >
> > I'm know working on a new fresh image to avoid problems :)
> > But I just noticed that opening a distributionMap is very very  
> very long! (whereas in my old image with an old version of moose,  
> with the same model, it was nearly instantaneous).
> >
> > 2010/8/17 Tudor Girba <[hidden email]>
> > No stress, I just wanted to give feedback :).
> >
> > But, it would make sense to get some of the work you are doing on  
> the custom report in Arki. So, if you feel that something needs  
> improvement, just raise the point or just commit. One thing I would  
> like to make sure is that what you do works out of the box with the  
> rest of the system.
> >
> > Cheers,
> > Doru
> >
> >
> >
> > On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
> >
> > Oups, it was a mistake. I shouldn't saved those changes.
> > Removing the error checking was for debuging  and all other  
> changes are now saved in another package.
> > So don't take into account this commit. Am I able to remove it  
> from squeaksource by myself ?
> > Sorry
> >
> > 2010/8/17 Tudor Girba <[hidden email]>
> > Hi Cyrille,
> >
> > I noticed a recent commit in Arki-Reporter. It would be nice to  
> get your efforts in this repository, but in this case, the commit is  
> wrong:
> > 1. you removed REPConcernSpecification class>>open (is this by any  
> chance due to the overriding problem?)
> > 2. you removed the error checking of the result computation which  
> can easily break the whole report
> >
> > Could you please take a look?
> >
> > Cheers,
> > Doru
> >
> > --
> > www.tudorgirba.com
> >
> > "Yesterday is a fact.
> >  Tomorrow is a possibility.
> >  Today is a challenge."
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > --
> > www.tudorgirba.com
> >
> > "We are all great at making mistakes."
> >
> >
> >
> >
> >
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > --
> > www.tudorgirba.com
> >
> > "Every now and then stop and ask yourself if the war you're  
> fighting is the right one."
> >
> >
> >
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
> >
> > _______________________________________________
> > Moose-dev mailing list
> > [hidden email]
> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"There are no old things, there are only old ways of looking at them."



_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Alexandre Bergel
It should now be faster...

Alexandre


On 17 Aug 2010, at 10:00, Tudor Girba wrote:

> Alex, could you quickly take a look at this? It looks to be related to the ChildrenShape refactoring. Given that the DistributionMap is heavily using nesting, this is a good testbed.
>
> Cheers,
> Doru
>
> On 17 Aug 2010, at 15:50, Cyrille Delaunay wrote:
>
>> I used Mondrian-Alexandre_Bergel.531.
>> It start to take time with Mondrian-Alexandre_Bergel.532.
>> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent
>>
>>
>> 2010/8/17 Alexandre Bergel <[hidden email]>
>> Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.
>>
>> Cheers,
>> Alexandre
>>
>>
>> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>>
>> > I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
>> >
>> > 2010/8/17 Tudor Girba <[hidden email]>
>> > I also noticed a slowdown in the DSM.
>> >
>> > What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
>> >
>> > Cheers,
>> > Doru
>> >
>> >
>> >
>> > On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>> >
>> > I'm know working on a new fresh image to avoid problems :)
>> > But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
>> >
>> > 2010/8/17 Tudor Girba <[hidden email]>
>> > No stress, I just wanted to give feedback :).
>> >
>> > But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
>> >
>> > Cheers,
>> > Doru
>> >
>> >
>> >
>> > On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>> >
>> > Oups, it was a mistake. I shouldn't saved those changes.
>> > Removing the error checking was for debuging  and all other changes are now saved in another package.
>> > So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
>> > Sorry
>> >
>> > 2010/8/17 Tudor Girba <[hidden email]>
>> > Hi Cyrille,
>> >
>> > I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
>> > 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
>> > 2. you removed the error checking of the result computation which can easily break the whole report
>> >
>> > Could you please take a look?
>> >
>> > Cheers,
>> > Doru
>> >
>> > --
>> > www.tudorgirba.com
>> >
>> > "Yesterday is a fact.
>> >  Tomorrow is a possibility.
>> >  Today is a challenge."
>> >
>> >
>> >
>> > _______________________________________________
>> > Moose-dev mailing list
>> > [hidden email]
>> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>> >
>> > _______________________________________________
>> > Moose-dev mailing list
>> > [hidden email]
>> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>> >
>> > --
>> > www.tudorgirba.com
>> >
>> > "We are all great at making mistakes."
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> > _______________________________________________
>> > Moose-dev mailing list
>> > [hidden email]
>> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>> >
>> > _______________________________________________
>> > Moose-dev mailing list
>> > [hidden email]
>> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>> >
>> > --
>> > www.tudorgirba.com
>> >
>> > "Every now and then stop and ask yourself if the war you're fighting is the right one."
>> >
>> >
>> >
>> >
>> > _______________________________________________
>> > Moose-dev mailing list
>> > [hidden email]
>> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>> >
>> > _______________________________________________
>> > Moose-dev mailing list
>> > [hidden email]
>> > https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "There are no old things, there are only old ways of looking at them."
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

jannik laval
Hi Alex,
I just come back from vacation.
I just load latest versions of Moose, Mondrian... and all other things.
And I try to do a DSM (with only rectangle shape, not the one with edges) on Moose.
The result is really slow.

Five weeks ago, it take less than 1 second to compute a DSM, now, it takes near 30 seconds.
I build a report with MessageTally, maybe, it can help you to fix the bug.
It is attached to the mail.

The problem is in the method shapeDSMMatrix, it invokes the method new on MORectangleShape, this one is slow.

Thank you for your help.
Cheers,
Jannik




On Aug 23, 2010, at 03:15 , Alexandre Bergel wrote:

> It should now be faster...
>
> Alexandre
>
>
> On 17 Aug 2010, at 10:00, Tudor Girba wrote:
>
>> Alex, could you quickly take a look at this? It looks to be related to the ChildrenShape refactoring. Given that the DistributionMap is heavily using nesting, this is a good testbed.
>>
>> Cheers,
>> Doru
>>
>> On 17 Aug 2010, at 15:50, Cyrille Delaunay wrote:
>>
>>> I used Mondrian-Alexandre_Bergel.531.
>>> It start to take time with Mondrian-Alexandre_Bergel.532.
>>> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent
>>>
>>>
>>> 2010/8/17 Alexandre Bergel <[hidden email]>
>>> Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.
>>>
>>> Cheers,
>>> Alexandre
>>>
>>>
>>> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>>>
>>>> I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
>>>>
>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>> I also noticed a slowdown in the DSM.
>>>>
>>>> What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
>>>>
>>>> Cheers,
>>>> Doru
>>>>
>>>>
>>>>
>>>> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>>>>
>>>> I'm know working on a new fresh image to avoid problems :)
>>>> But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
>>>>
>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>> No stress, I just wanted to give feedback :).
>>>>
>>>> But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
>>>>
>>>> Cheers,
>>>> Doru
>>>>
>>>>
>>>>
>>>> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>>>>
>>>> Oups, it was a mistake. I shouldn't saved those changes.
>>>> Removing the error checking was for debuging  and all other changes are now saved in another package.
>>>> So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
>>>> Sorry
>>>>
>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>> Hi Cyrille,
>>>>
>>>> I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
>>>> 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
>>>> 2. you removed the error checking of the result computation which can easily break the whole report
>>>>
>>>> Could you please take a look?
>>>>
>>>> Cheers,
>>>> Doru
>>>>
>>>> --
>>>> www.tudorgirba.com
>>>>
>>>> "Yesterday is a fact.
>>>> Tomorrow is a possibility.
>>>> Today is a challenge."
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> www.tudorgirba.com
>>>>
>>>> "We are all great at making mistakes."
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> www.tudorgirba.com
>>>>
>>>> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> --
>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>> Alexandre Bergel  http://www.bergel.eu
>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>> www.tudorgirba.com
>>
>> "There are no old things, there are only old ways of looking at them."
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
---
Jannik Laval


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

spyResult.txt (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Laval Jannik-2
I try to comment the first line line of MOShape>>new
Then results is the good one: 819 msec.

===
new
        "self isAbstractClass ifTrue: [ self error: 'An abstract class cannot be instantiated' ]."
        ^ super new
===

Cheers,
Jannik
 
On Aug 23, 2010, at 11:07 , Laval Jannik wrote:

> Hi Alex,
> I just come back from vacation.
> I just load latest versions of Moose, Mondrian... and all other things.
> And I try to do a DSM (with only rectangle shape, not the one with edges) on Moose.
> The result is really slow.
>
> Five weeks ago, it take less than 1 second to compute a DSM, now, it takes near 30 seconds.
> I build a report with MessageTally, maybe, it can help you to fix the bug.
> It is attached to the mail.
>
> The problem is in the method shapeDSMMatrix, it invokes the method new on MORectangleShape, this one is slow.
>
> Thank you for your help.
> Cheers,
> Jannik
>
> <spyResult.txt>
>
> On Aug 23, 2010, at 03:15 , Alexandre Bergel wrote:
>
>> It should now be faster...
>>
>> Alexandre
>>
>>
>> On 17 Aug 2010, at 10:00, Tudor Girba wrote:
>>
>>> Alex, could you quickly take a look at this? It looks to be related to the ChildrenShape refactoring. Given that the DistributionMap is heavily using nesting, this is a good testbed.
>>>
>>> Cheers,
>>> Doru
>>>
>>> On 17 Aug 2010, at 15:50, Cyrille Delaunay wrote:
>>>
>>>> I used Mondrian-Alexandre_Bergel.531.
>>>> It start to take time with Mondrian-Alexandre_Bergel.532.
>>>> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent
>>>>
>>>>
>>>> 2010/8/17 Alexandre Bergel <[hidden email]>
>>>> Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.
>>>>
>>>> Cheers,
>>>> Alexandre
>>>>
>>>>
>>>> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>>>>
>>>>> I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
>>>>>
>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>> I also noticed a slowdown in the DSM.
>>>>>
>>>>> What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
>>>>>
>>>>> Cheers,
>>>>> Doru
>>>>>
>>>>>
>>>>>
>>>>> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>>>>>
>>>>> I'm know working on a new fresh image to avoid problems :)
>>>>> But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
>>>>>
>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>> No stress, I just wanted to give feedback :).
>>>>>
>>>>> But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
>>>>>
>>>>> Cheers,
>>>>> Doru
>>>>>
>>>>>
>>>>>
>>>>> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>>>>>
>>>>> Oups, it was a mistake. I shouldn't saved those changes.
>>>>> Removing the error checking was for debuging  and all other changes are now saved in another package.
>>>>> So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
>>>>> Sorry
>>>>>
>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>> Hi Cyrille,
>>>>>
>>>>> I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
>>>>> 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
>>>>> 2. you removed the error checking of the result computation which can easily break the whole report
>>>>>
>>>>> Could you please take a look?
>>>>>
>>>>> Cheers,
>>>>> Doru
>>>>>
>>>>> --
>>>>> www.tudorgirba.com
>>>>>
>>>>> "Yesterday is a fact.
>>>>> Tomorrow is a possibility.
>>>>> Today is a challenge."
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> --
>>>>> www.tudorgirba.com
>>>>>
>>>>> "We are all great at making mistakes."
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> --
>>>>> www.tudorgirba.com
>>>>>
>>>>> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel  http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> --
>>> www.tudorgirba.com
>>>
>>> "There are no old things, there are only old ways of looking at them."
>>>
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> ---
> Jannik Laval
>

---
Jannik Laval


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Stéphane Ducasse
personnally I do not like this isAbstractClass check.
and scanning all the bytecode of all the methods in a class and probably its superclass at runtime is may be not the
right way.

Stef

On Aug 23, 2010, at 11:14 AM, Laval Jannik wrote:

> I try to comment the first line line of MOShape>>new
> Then results is the good one: 819 msec.
>
> ===
> new
> "self isAbstractClass ifTrue: [ self error: 'An abstract class cannot be instantiated' ]."
> ^ super new
> ===
>
> Cheers,
> Jannik
>
> On Aug 23, 2010, at 11:07 , Laval Jannik wrote:
>
>> Hi Alex,
>> I just come back from vacation.
>> I just load latest versions of Moose, Mondrian... and all other things.
>> And I try to do a DSM (with only rectangle shape, not the one with edges) on Moose.
>> The result is really slow.
>>
>> Five weeks ago, it take less than 1 second to compute a DSM, now, it takes near 30 seconds.
>> I build a report with MessageTally, maybe, it can help you to fix the bug.
>> It is attached to the mail.
>>
>> The problem is in the method shapeDSMMatrix, it invokes the method new on MORectangleShape, this one is slow.
>>
>> Thank you for your help.
>> Cheers,
>> Jannik
>>
>> <spyResult.txt>
>>
>> On Aug 23, 2010, at 03:15 , Alexandre Bergel wrote:
>>
>>> It should now be faster...
>>>
>>> Alexandre
>>>
>>>
>>> On 17 Aug 2010, at 10:00, Tudor Girba wrote:
>>>
>>>> Alex, could you quickly take a look at this? It looks to be related to the ChildrenShape refactoring. Given that the DistributionMap is heavily using nesting, this is a good testbed.
>>>>
>>>> Cheers,
>>>> Doru
>>>>
>>>> On 17 Aug 2010, at 15:50, Cyrille Delaunay wrote:
>>>>
>>>>> I used Mondrian-Alexandre_Bergel.531.
>>>>> It start to take time with Mondrian-Alexandre_Bergel.532.
>>>>> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent
>>>>>
>>>>>
>>>>> 2010/8/17 Alexandre Bergel <[hidden email]>
>>>>> Do you want me to have a look at it?  I do not have much time (I have a major deadline this Friday), but I can give a hand if it is necessary and urgent.
>>>>>
>>>>> Cheers,
>>>>> Alexandre
>>>>>
>>>>>
>>>>> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>>>>>
>>>>>> I was using Mondrian-Alexandre_Bergel.541. But even using Mondrian-tg.540 now, it takes the same time
>>>>>>
>>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>>> I also noticed a slowdown in the DSM.
>>>>>>
>>>>>> What version of Mondrian are you using? I am using Mondrian-tg.540, because Mondrian-Alexandre_Bergel.541 has a bug when computing the blueprint.
>>>>>>
>>>>>> Cheers,
>>>>>> Doru
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>>>>>>
>>>>>> I'm know working on a new fresh image to avoid problems :)
>>>>>> But I just noticed that opening a distributionMap is very very very long! (whereas in my old image with an old version of moose, with the same model, it was nearly instantaneous).
>>>>>>
>>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>>> No stress, I just wanted to give feedback :).
>>>>>>
>>>>>> But, it would make sense to get some of the work you are doing on the custom report in Arki. So, if you feel that something needs improvement, just raise the point or just commit. One thing I would like to make sure is that what you do works out of the box with the rest of the system.
>>>>>>
>>>>>> Cheers,
>>>>>> Doru
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>>>>>>
>>>>>> Oups, it was a mistake. I shouldn't saved those changes.
>>>>>> Removing the error checking was for debuging  and all other changes are now saved in another package.
>>>>>> So don't take into account this commit. Am I able to remove it from squeaksource by myself ?
>>>>>> Sorry
>>>>>>
>>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>>> Hi Cyrille,
>>>>>>
>>>>>> I noticed a recent commit in Arki-Reporter. It would be nice to get your efforts in this repository, but in this case, the commit is wrong:
>>>>>> 1. you removed REPConcernSpecification class>>open (is this by any chance due to the overriding problem?)
>>>>>> 2. you removed the error checking of the result computation which can easily break the whole report
>>>>>>
>>>>>> Could you please take a look?
>>>>>>
>>>>>> Cheers,
>>>>>> Doru
>>>>>>
>>>>>> --
>>>>>> www.tudorgirba.com
>>>>>>
>>>>>> "Yesterday is a fact.
>>>>>> Tomorrow is a possibility.
>>>>>> Today is a challenge."
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> --
>>>>>> www.tudorgirba.com
>>>>>>
>>>>>> "We are all great at making mistakes."
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> --
>>>>>> www.tudorgirba.com
>>>>>>
>>>>>> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> --
>>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>>> Alexandre Bergel  http://www.bergel.eu
>>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> www.tudorgirba.com
>>>>
>>>> "There are no old things, there are only old ways of looking at them."
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> --
>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>> Alexandre Bergel  http://www.bergel.eu
>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> ---
>> Jannik Laval
>>
>
> ---
> Jannik Laval
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: arki changes

Tudor Girba
Indeed. A check like this should not impact performance.

Doru

On 23 Aug 2010, at 12:29, Stéphane Ducasse wrote:

> personnally I do not like this isAbstractClass check.
> and scanning all the bytecode of all the methods in a class and  
> probably its superclass at runtime is may be not the
> right way.
>
> Stef
>
> On Aug 23, 2010, at 11:14 AM, Laval Jannik wrote:
>
>> I try to comment the first line line of MOShape>>new
>> Then results is the good one: 819 msec.
>>
>> ===
>> new
>> "self isAbstractClass ifTrue: [ self error: 'An abstract class  
>> cannot be instantiated' ]."
>> ^ super new
>> ===
>>
>> Cheers,
>> Jannik
>>
>> On Aug 23, 2010, at 11:07 , Laval Jannik wrote:
>>
>>> Hi Alex,
>>> I just come back from vacation.
>>> I just load latest versions of Moose, Mondrian... and all other  
>>> things.
>>> And I try to do a DSM (with only rectangle shape, not the one with  
>>> edges) on Moose.
>>> The result is really slow.
>>>
>>> Five weeks ago, it take less than 1 second to compute a DSM, now,  
>>> it takes near 30 seconds.
>>> I build a report with MessageTally, maybe, it can help you to fix  
>>> the bug.
>>> It is attached to the mail.
>>>
>>> The problem is in the method shapeDSMMatrix, it invokes the method  
>>> new on MORectangleShape, this one is slow.
>>>
>>> Thank you for your help.
>>> Cheers,
>>> Jannik
>>>
>>> <spyResult.txt>
>>>
>>> On Aug 23, 2010, at 03:15 , Alexandre Bergel wrote:
>>>
>>>> It should now be faster...
>>>>
>>>> Alexandre
>>>>
>>>>
>>>> On 17 Aug 2010, at 10:00, Tudor Girba wrote:
>>>>
>>>>> Alex, could you quickly take a look at this? It looks to be  
>>>>> related to the ChildrenShape refactoring. Given that the  
>>>>> DistributionMap is heavily using nesting, this is a good testbed.
>>>>>
>>>>> Cheers,
>>>>> Doru
>>>>>
>>>>> On 17 Aug 2010, at 15:50, Cyrille Delaunay wrote:
>>>>>
>>>>>> I used Mondrian-Alexandre_Bergel.531.
>>>>>> It start to take time with Mondrian-Alexandre_Bergel.532.
>>>>>> I can use Mondrian-Alexandre_Bergel.531 for now, it's not urgent
>>>>>>
>>>>>>
>>>>>> 2010/8/17 Alexandre Bergel <[hidden email]>
>>>>>> Do you want me to have a look at it?  I do not have much time  
>>>>>> (I have a major deadline this Friday), but I can give a hand if  
>>>>>> it is necessary and urgent.
>>>>>>
>>>>>> Cheers,
>>>>>> Alexandre
>>>>>>
>>>>>>
>>>>>> On 17 Aug 2010, at 09:31, Cyrille Delaunay wrote:
>>>>>>
>>>>>>> I was using Mondrian-Alexandre_Bergel.541. But even using  
>>>>>>> Mondrian-tg.540 now, it takes the same time
>>>>>>>
>>>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>>>> I also noticed a slowdown in the DSM.
>>>>>>>
>>>>>>> What version of Mondrian are you using? I am using Mondrian-tg.
>>>>>>> 540, because Mondrian-Alexandre_Bergel.541 has a bug when  
>>>>>>> computing the blueprint.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Doru
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 17 Aug 2010, at 15:18, Cyrille Delaunay wrote:
>>>>>>>
>>>>>>> I'm know working on a new fresh image to avoid problems :)
>>>>>>> But I just noticed that opening a distributionMap is very very  
>>>>>>> very long! (whereas in my old image with an old version of  
>>>>>>> moose, with the same model, it was nearly instantaneous).
>>>>>>>
>>>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>>>> No stress, I just wanted to give feedback :).
>>>>>>>
>>>>>>> But, it would make sense to get some of the work you are doing  
>>>>>>> on the custom report in Arki. So, if you feel that something  
>>>>>>> needs improvement, just raise the point or just commit. One  
>>>>>>> thing I would like to make sure is that what you do works out  
>>>>>>> of the box with the rest of the system.
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Doru
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 17 Aug 2010, at 14:17, Cyrille Delaunay wrote:
>>>>>>>
>>>>>>> Oups, it was a mistake. I shouldn't saved those changes.
>>>>>>> Removing the error checking was for debuging  and all other  
>>>>>>> changes are now saved in another package.
>>>>>>> So don't take into account this commit. Am I able to remove it  
>>>>>>> from squeaksource by myself ?
>>>>>>> Sorry
>>>>>>>
>>>>>>> 2010/8/17 Tudor Girba <[hidden email]>
>>>>>>> Hi Cyrille,
>>>>>>>
>>>>>>> I noticed a recent commit in Arki-Reporter. It would be nice  
>>>>>>> to get your efforts in this repository, but in this case, the  
>>>>>>> commit is wrong:
>>>>>>> 1. you removed REPConcernSpecification class>>open (is this by  
>>>>>>> any chance due to the overriding problem?)
>>>>>>> 2. you removed the error checking of the result computation  
>>>>>>> which can easily break the whole report
>>>>>>>
>>>>>>> Could you please take a look?
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Doru
>>>>>>>
>>>>>>> --
>>>>>>> www.tudorgirba.com
>>>>>>>
>>>>>>> "Yesterday is a fact.
>>>>>>> Tomorrow is a possibility.
>>>>>>> Today is a challenge."
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Moose-dev mailing list
>>>>>>> [hidden email]
>>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Moose-dev mailing list
>>>>>>> [hidden email]
>>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>>
>>>>>>> --
>>>>>>> www.tudorgirba.com
>>>>>>>
>>>>>>> "We are all great at making mistakes."
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Moose-dev mailing list
>>>>>>> [hidden email]
>>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Moose-dev mailing list
>>>>>>> [hidden email]
>>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>>
>>>>>>> --
>>>>>>> www.tudorgirba.com
>>>>>>>
>>>>>>> "Every now and then stop and ask yourself if the war you're  
>>>>>>> fighting is the right one."
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Moose-dev mailing list
>>>>>>> [hidden email]
>>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Moose-dev mailing list
>>>>>>> [hidden email]
>>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> --
>>>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>>>> Alexandre Bergel  http://www.bergel.eu
>>>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> [hidden email]
>>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> --
>>>>> www.tudorgirba.com
>>>>>
>>>>> "There are no old things, there are only old ways of looking at  
>>>>> them."
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> [hidden email]
>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel  http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> [hidden email]
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> ---
>>> Jannik Laval
>>>
>>
>> ---
>> Jannik Laval
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Some battles are better lost than fought."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev