[bug] Array printing aesthetic error

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug] Array printing aesthetic error

mcandre
Issue status update for
http://smalltalk.gnu.org/node/603
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/603

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  mcandre
 Updated by:   mcandre
 Status:       active

Arrays always print an extra space before the final parenthesis:

st> #(1 2 3)
(1 2 3 )

st> #($a $b $c)
($a $b $c )

Extra space is fine but it should be consistent. Either put an
additional extra space after the first parenthesis or remove the extra
space altogether.



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Array printing aesthetic error

Ladislav Marek
Hi,
I have made a patch for this bug (attached).

LM

On Sun, Aug 7, 2011 at 20:11, Andrew Pennebaker
<[hidden email]> wrote:

> Issue status update for http://smalltalk.gnu.org/node/603
> Post a follow up: http://smalltalk.gnu.org/project/comments/add/603
>
> Project:      GNU Smalltalk
> Version:      <none>
> Component:    Base classes
> Category:     bug reports
> Priority:     normal
> Assigned to:  Unassigned
> Reported by:  mcandre
> Updated by:   mcandre
> Status:       active
>
> Arrays always print an extra space before the final parenthesis:
>
> st> #(1 2 3)
> (1 2 3 )
>
> st> #($a $b $c)
> ($a $b $c )
>
> Extra space is fine but it should be consistent. Either put an
> additional extra space after the first parenthesis or remove the extra
> space altogether.
>
>
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

bug603.patch (14K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Array printing aesthetic error

Paolo Bonzini-2
On 08/17/2011 02:54 AM, Ladislav Marek wrote:
> Hi,
> I have made a patch for this bug (attached).

Hi Ladislav,

yes, indeed the only hurdle for the patch was to review testsuite changes.

Would you please adjust the patch to use #do:separatedBy:?

Thanks,

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk