[bug] Debug report wrong line number

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug] Debug report wrong line number

MrGwen
Issue status update for
http://smalltalk.gnu.org/node/770
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/770

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  MrGwen
 Updated by:   MrGwen
 Status:       active

When in a VisualGST workspace I debug '1 printNl'
I step multiple times to : Integer>>#printString:
after two steps it goes to the wrong line number (14)
when it should be 8 or 6.

It seems that
^lineMap at: (aContext ip + 1 max: 1) ifAbsent: [1] fix the problem
in Debugger>>currentLineIn:



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Debug report wrong line number

Holger Hans Peter Freyther-3
Issue status update for
http://smalltalk.gnu.org/project/issue/770
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/770

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  MrGwen
 Updated by:   zecke
 Status:       active

We are playing ping-pong here. The +1 was changed to a -1 in
dd1f241bf27756bfa41057bc6368483dc25c3da7. This change doesn't have a
testcase and I couldn't find the bug description in the mailinglist
archive.

So by changing it back to +1 we will break something. So please create a
new testcase that shows your issue and can be used for regression
testing.



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Debug report wrong line number

Ladislav Marek
It has been reported here
http://lists.gnu.org/archive/html/help-smalltalk/2011-07/msg00035.html
.

On Wed, May 29, 2013 at 10:29 AM, Holger Hans Peter Freyther
<[hidden email]> wrote:

> Issue status update for http://smalltalk.gnu.org/project/issue/770
>
> Post a follow up: http://smalltalk.gnu.org/project/comments/add/770
>
> Project:      GNU Smalltalk
> Version:      <none>
> Component:    Base classes
> Category:     bug reports
> Priority:     normal
> Assigned to:  Unassigned
> Reported by:  MrGwen
> Updated by:   zecke
> Status:       active
>
> We are playing ping-pong here. The +1 was changed to a -1 in
> dd1f241bf27756bfa41057bc6368483dc25c3da7. This change doesn't have a
> testcase and I couldn't find the bug description in the mailinglist
> archive.
>
> So by changing it back to +1 we will break something. So please create a
> new testcase that shows your issue and can be used for regression
> testing.
>
>
>
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Debug report wrong line number

Gwenaël Casaccio
On 29/05/2013 13:37, Ladislav Marek wrote:

> It has been reported here
> http://lists.gnu.org/archive/html/help-smalltalk/2011-07/msg00035.html
> .
>
> On Wed, May 29, 2013 at 10:29 AM, Holger Hans Peter Freyther
> <[hidden email]> wrote:
>> Issue status update for http://smalltalk.gnu.org/project/issue/770
>>
>> Post a follow up: http://smalltalk.gnu.org/project/comments/add/770
>>
>> Project:      GNU Smalltalk
>> Version:      <none>
>> Component:    Base classes
>> Category:     bug reports
>> Priority:     normal
>> Assigned to:  Unassigned
>> Reported by:  MrGwen
>> Updated by:   zecke
>> Status:       active
>>
>> We are playing ping-pong here. The +1 was changed to a -1 in
>> dd1f241bf27756bfa41057bc6368483dc25c3da7. This change doesn't have a
>> testcase and I couldn't find the bug description in the mailinglist
>> archive.
>>
>> So by changing it back to +1 we will break something. So please create a
>> new testcase that shows your issue and can be used for regression
>> testing.
>>
>>
>>
>>
>> _______________________________________________
>> help-smalltalk mailing list
>> [hidden email]
>> https://lists.gnu.org/mailman/listinfo/help-smalltalk
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk

So here is the code:

PackageLoader fileInPackage: 'DebugTools'.

b := [ 1 printString: 10 ].
d := Debugger on: b newProcess.

[d suspendedContext method == b block]
         whileFalse: [d stepBytecode].

5 timesRepeat: [
     d step.
     d suspendedContext method printNl.
     d currentLine printNl ].

and the output:

Integer>>printString:
1
Integer>>printString:
0
Integer>>printString:
6
Integer>>printString:
14
Integer>>printString:
8

there are two errors: line 0 and line 14



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Debug report wrong line number

Gwenaël Casaccio
In reply to this post by Ladislav Marek
On 29/05/2013 13:37, Ladislav Marek wrote:

> It has been reported here
> http://lists.gnu.org/archive/html/help-smalltalk/2011-07/msg00035.html
> .
>
> On Wed, May 29, 2013 at 10:29 AM, Holger Hans Peter Freyther
> <[hidden email]> wrote:
>> Issue status update for http://smalltalk.gnu.org/project/issue/770
>>
>> Post a follow up: http://smalltalk.gnu.org/project/comments/add/770
>>
>> Project:      GNU Smalltalk
>> Version:      <none>
>> Component:    Base classes
>> Category:     bug reports
>> Priority:     normal
>> Assigned to:  Unassigned
>> Reported by:  MrGwen
>> Updated by:   zecke
>> Status:       active
>>
>> We are playing ping-pong here. The +1 was changed to a -1 in
>> dd1f241bf27756bfa41057bc6368483dc25c3da7. This change doesn't have a
>> testcase and I couldn't find the bug description in the mailinglist
>> archive.
>>
>> So by changing it back to +1 we will break something. So please create a
>> new testcase that shows your issue and can be used for regression
>> testing.
>>
>>
>>
>>
>> _______________________________________________
>> help-smalltalk mailing list
>> [hidden email]
>> https://lists.gnu.org/mailman/listinfo/help-smalltalk
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk
Add a test case in debug tool for the line number


_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Add-test-case-for-the-line-number.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [bug] Debug report wrong line number

Gwenaël Casaccio
On 04/06/2013 09:00, Gwenaël Casaccio wrote:

> On 29/05/2013 13:37, Ladislav Marek wrote:
>> It has been reported here
>> http://lists.gnu.org/archive/html/help-smalltalk/2011-07/msg00035.html
>> .
>>
>> On Wed, May 29, 2013 at 10:29 AM, Holger Hans Peter Freyther
>> <[hidden email]> wrote:
>>> Issue status update for http://smalltalk.gnu.org/project/issue/770
>>>
>>> Post a follow up: http://smalltalk.gnu.org/project/comments/add/770
>>>
>>> Project:      GNU Smalltalk
>>> Version:      <none>
>>> Component:    Base classes
>>> Category:     bug reports
>>> Priority:     normal
>>> Assigned to:  Unassigned
>>> Reported by:  MrGwen
>>> Updated by:   zecke
>>> Status:       active
>>>
>>> We are playing ping-pong here. The +1 was changed to a -1 in
>>> dd1f241bf27756bfa41057bc6368483dc25c3da7. This change doesn't have a
>>> testcase and I couldn't find the bug description in the mailinglist
>>> archive.
>>>
>>> So by changing it back to +1 we will break something. So please
>>> create a
>>> new testcase that shows your issue and can be used for regression
>>> testing.
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> help-smalltalk mailing list
>>> [hidden email]
>>> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>> _______________________________________________
>> help-smalltalk mailing list
>> [hidden email]
>> https://lists.gnu.org/mailman/listinfo/help-smalltalk
>
> Add a test case in debug tool for the line number
>
Fix wrong file name in changelog

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Add-test-case-for-the-line-number.patch (1K) Download Attachment