[bug] ROE test fails on Debian unstable/amd64

Issue status update for
http://smalltalk.gnu.org/node/190
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/190

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Testsuite
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  tgg
 Updated by:   tgg
 Status:       active

Hello,

test 117 of GNU Smalltalk 3.0a fails on Debian amd64 sid box. (It also
fails on i386.)

Please find attached the testsuite.log associated with this test. I
seem to recall there was an API change in SQLite3 (we have 3.5.6), it
might be related.

I'll have a look at this if you don't.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Issue status update for
http://smalltalk.gnu.org/project/issue/190
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/190

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Testsuite
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  tgg
 Updated by:   bonzinip
 Status:       active

Interesting, I see it too with 3.5.6 (not with 3.4.2).  This patch fixes
it, I think.  It's a double free or something like that:

diff --git a/packages/dbd-sqlite/sqlite3.c
b/packages/dbd-sqlite/sqlite3.c
index fda8390..55d34ba 100644
--- a/packages/dbd-sqlite/sqlite3.c
+++ b/packages/dbd-sqlite/sqlite3.c
@@ -217,8 +217,11 @@ gst_sqlite3_finalize (OOP self)
   SQLite3StmtHandle h;
 
   h = (SQLite3StmtHandle) OOP_TO_OBJ (self);
-  stmt = (sqlite3_stmt *) vmProxy->OOPToCObject (h->stmt);
+  if (h->stmt == vmProxy->nilOOP)
+    return 0;
 
+  stmt = (sqlite3_stmt *) vmProxy->OOPToCObject (h->stmt);
+  h->stmt = vmProxy->nilOOP;
   return sqlite3_finalize (stmt);
 }





_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Issue status update for
http://smalltalk.gnu.org/project/issue/190
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/190

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Testsuite
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  tgg
 Updated by:   tgg
-Status:       active
+Status:       committed

Hello, your patch fixes the failure here too :-)

Assuming `fixed' status is for bugs fixes that are available in a
release, I'm marking this bug `committed'.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk

Issue status update for
http://smalltalk.gnu.org/project/issue/190
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/190

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Testsuite
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  tgg
 Updated by:   bonzinip
-Status:       committed
+Status:       fixed

Wrong assumption, committed is for fixes that are in someone's git
repository (so that I can just cherrypick them). :-)




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk