[bug] STInST and gst-parse.c are inconsistent on parsing trailing '.'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug] STInST and gst-parse.c are inconsistent on parsing trailing '.'

Holger Hans Peter Freyther-3
Issue status update for
http://smalltalk.gnu.org/node/815
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/815

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    STInST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  zecke
 Updated by:   zecke
 Status:       active

STInST and gst-parse.c are inconsistent about a trailing '.' at the end
of the class definition. E.g. like this:


Object subclass: Test [
].


It has been found while trying to load Cairo with the 'Compiler'
package.



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] STInST and gst-parse.c are inconsistent on parsing trailing '.'

MrGwen
Issue status update for
http://smalltalk.gnu.org/project/issue/815
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/815

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    STInST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  zecke
 Updated by:   MrGwen
 Status:       active

   diff --git a/packages/stinst/parser/GSTParser.st
b/packages/stinst/parser/GSTParser.st
   index 66fedcb..7d934e1 100644
   --- a/packages/stinst/parser/GSTParser.st
   +++ b/packages/stinst/parser/GSTParser.st
   @@ -168,6 +168,7 @@ STInST.STFileInParser subclass: GSTFileInParser [
           addInstVars := self
               parseClassBodyElement: addInstVars
               withinExtend: extend ].
    +        currentToken isSpecial ifTrue: [ self skipToken: $. ].
       taggee := oldTaggee.
    ]

hello, I've fixed the parsing issue
just add currentToken isSpecial ifTrue: [ self skipToken: $. ]. line 171
in gstparse
but cairo package still won't load that's another issue :}
to fix it rename Cairo class as CCairo (because it has the same name as
the namespace)



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] STInST and gst-parse.c are inconsistent on parsing trailing '.'

Gwenaël Casaccio
In reply to this post by Holger Hans Peter Freyther-3
The patch should fix the issue and make STInST consistent (with a test
case).

On 09/09/2013 10:16, Holger Hans Peter Freyther wrote:

> Issue status update for http://smalltalk.gnu.org/node/815
> Post a follow up: http://smalltalk.gnu.org/project/comments/add/815
>
> Project:      GNU Smalltalk
> Version:      <none>
> Component:    STInST
> Category:     bug reports
> Priority:     normal
> Assigned to:  Unassigned
> Reported by:  zecke
> Updated by:   zecke
> Status:       active
>
> STInST and gst-parse.c are inconsistent about a trailing '.' at the end
> of the class definition. E.g. like this:
>
>
> Object subclass: Test [
> ].
>
>
> It has been found while trying to load Cairo with the 'Compiler'
> package.
>
>
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> https://lists.gnu.org/mailman/listinfo/help-smalltalk

_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk

0001-Make-STInST-and-gst-parse.c-consistent-about-a-trail.patch (4K) Download Attachment