[bug] STInST compiler not used for fileins

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug] STInST compiler not used for fileins

S11001001
Issue status update for
http://smalltalk.gnu.org/node/212
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/212

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    STInST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  S11001001
 Updated by:   S11001001
 Status:       committed

c12efdf "VFS rewrite" introduced some specializations of #fileIn on
subclasses of Stream that shadow STInST's version; 45ffb40 on my master
has StartCompiler.st remove those.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] STInST compiler not used for fileins

Paolo Bonzini-3
Issue status update for
http://smalltalk.gnu.org/project/issue/212
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/212

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    STInST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  S11001001
 Updated by:   bonzinip
-Status:       committed
+Status:       active
 Attachment:   http://smalltalk.gnu.org/files/issues/gst-fix-filein-vfs.patch (1.25 KB)

Fixed with the attached alternative patch (committed to master), which
instead overrides the methods in Stream that call the built-in compiler
(#fileIn does not).

However, I see that there are some problems in Compiler with the
implementation of deferred variable bindings, exposed by the following
test:

PackageLoader fileInPackage: 'Compiler'.
PackageLoader fileInPackage: 'SUnit'.
p := (PackageLoader packageAt: 'Complex') test.
p fileIn.
ComplexTest buildSuiteFromSelectors run printNl

Could you take a look?




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] STInST compiler not used for fileins

S11001001
In reply to this post by S11001001
Issue status update for
http://smalltalk.gnu.org/project/issue/212
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/212

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    STInST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  S11001001
 Updated by:   S11001001
-Status:       active
+Status:       committed
 Attachment:   http://smalltalk.gnu.org/files/issues/home-undecl-assocs.patch (1.08 KB)

95d8f67: don't rely on BindingDictionaries to home plain Associations

I suppose at some point in history #add: on BindingDictionaries would
potentially answer a different association than the one given; this
hasn't been the case since at least 3.0a, but I seem to recall it being
so before.  Anyway, this just dupes what's at sym.c:904.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] STInST compiler not used for fileins

Paolo Bonzini-3
In reply to this post by S11001001
Issue status update for
http://smalltalk.gnu.org/project/issue/212
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/212

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    STInST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  S11001001
 Updated by:   bonzinip
-Status:       committed
+Status:       fixed

applied, thanks!




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk