[bug] class deletion

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug] class deletion

James Gardiner-2
Issue status update for
http://smalltalk.gnu.org/node/413
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/413

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    VisualGST
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  jamgard
 Updated by:   jamgard
 Status:       active

Deleting a class that has been created doesn't work. The class remains
in the browser pane and, if clicked on, will launch a debugger window
and send a brief message to the Transcript. (At least better than the
clutter we had before on the Transcript!)




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] class deletion

MrGwen
Issue status update for
http://smalltalk.gnu.org/project/issue/413
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/413

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    VisualGST
 Category:     bug reports
 Priority:     critical
 Assigned to:  MrGwen
 Reported by:  jamgard
 Updated by:   MrGwen
-Status:       active
+Status:       committed

In fact the bug was not in the class deletion but in the class creation
:p
I've forget to add a space at the end of the class name.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] class deletion

Paolo Bonzini-2
> -Status: active
> +Status: committed

What's the reason for this?

-                res = 1 ifTrue: [ self saveImage.
+                res = 1 ifTrue: [ saved ifTrue: [ self saveImage ]
ifFalse: [ self saveImageAs ].

This behavior is different from about every other Smalltalk, AFAICT.
Maybe you wanted this:

saveImage
     "ObjectMemory>>#snapshot breaks hard links due to
      http://bugzilla.kernel.org/show_bug.cgi?id=9138, so we have to
      check the permission of the directory rather than the file."
     File image parent isWriteable ifFalse: [ ^self saveImageAs ].

?

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] class deletion

MrGwen
On Mon, 2009-10-05 at 12:44 +0200, Paolo Bonzini wrote:

> > -Status: active
> > +Status: committed
>
> What's the reason for this?
>
> -                res = 1 ifTrue: [ self saveImage.
> +                res = 1 ifTrue: [ saved ifTrue: [ self saveImage ]
> ifFalse: [ self saveImageAs ].
>
> This behavior is different from about every other Smalltalk, AFAICT.
> Maybe you wanted this:
>
> saveImage
>      "ObjectMemory>>#snapshot breaks hard links due to
>       http://bugzilla.kernel.org/show_bug.cgi?id=9138, so we have to
>       check the permission of the directory rather than the file."
>      File image parent isWriteable ifFalse: [ ^self saveImageAs ].
>
> ?
>
> Paolo

Yes this is what I've wanted (this was a bad quick fix).

Cheers,
Gwen



_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] class deletion

Paolo Bonzini-3
In reply to this post by James Gardiner-2
Issue status update for
http://smalltalk.gnu.org/project/issue/413
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/413

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    VisualGST
 Category:     bug reports
 Priority:     critical
 Assigned to:  MrGwen
 Reported by:  jamgard
 Updated by:   bonzinip
-Status:       committed
+Status:       fixed

pushed to sv.gnu.org, please sync.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk