[bug/fix] PRContext-copy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug/fix] PRContext-copy

keith1y
I discovered that the referential integrity of PRContext <-> PRCommand
gets broken when you assign a user to the context because #user: does a
copy, but the instance of PRCommand's context is still the pre-copy one.

This is fixed by

--
PRContext-postCopy

    self setCommand: command copy.

--
cheers

Keith

 


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: [bug/fix] PRContext-copy

Lukas Renggli-2
> I discovered that the referential integrity of PRContext <-> PRCommand
> gets broken when you assign a user to the context because #user:  
> does a
> copy, but the instance of PRCommand's context is still the pre-copy  
> one.

Nice catch. Thanks for reporting.

This is tested and fixed in:

Name: Pier-All-lr.226
Author: lr
Time: 14 August 2007, 11:53:01 pm
UUID: a1d051f0-d8f0-4ecb-a8b7-3ee3584a13a3
Ancestors: Pier-All-lr.225
Dependencies: Pier-Model-lr.161, Pier-Tests-lr.73, Pier-Seaside-lr.
189, Pier-Security-lr.86, Pier-Blog-lr.57

fixes and tests "I discovered that the referential integrity of  
PRContext <-> PRCommand gets broken when you assign a user to the  
context because #user: does a copy, but the instance of PRCommand's  
context is still the pre-copy one." (Keith Hodges)

--
Lukas Renggli
http://www.lukas-renggli.ch


_______________________________________________
SmallWiki, Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki