bug rendering files in pier3?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug rendering files in pier3?

Tudor Girba-2
Hi,

Images seem to be rendered strangely in Pier 3.

Having +/system/components/logo+ in the code generates the following html:
<img alt="Logo" src="http://www.example.com/system/components/logo">

In Pier 2, this appeared correctly as:
<img alt="Logo" src="http://www.example.com/files/f6/0i0qkomrno1bwqff24ablc8y5dnlln/logo.png">


I did not have time to look too deep into it. Is this a known issue?

Cheers,
Doru

--
www.tudorgirba.com

"No matter how many recipes we know, we still value a chef."







_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: bug rendering files in pier3?

Tudor Girba-2
Hi,

I found the problem in:
PREmbeddedRenderer>>visitFileImage: aStructure
        <internal: 'image/' priority: 0>
       
        html image
                attributes: (self attributesFor: link);
                altText: aStructure title;
                url: aStructure url

It should have been "aStructure file url".

Is there a reason for the change?

Cheers,
Doru



On 20 Nov 2012, at 22:06, Tudor Girba <[hidden email]> wrote:

> Hi,
>
> Images seem to be rendered strangely in Pier 3.
>
> Having +/system/components/logo+ in the code generates the following html:
> <img alt="Logo" src="http://www.example.com/system/components/logo">
>
> In Pier 2, this appeared correctly as:
> <img alt="Logo" src="http://www.example.com/files/f6/0i0qkomrno1bwqff24ablc8y5dnlln/logo.png">
>
>
> I did not have time to look too deep into it. Is this a known issue?
>
> Cheers,
> Doru
>
> --
> www.tudorgirba.com
>
> "No matter how many recipes we know, we still value a chef."
>
>
>
>
>
>

--
www.tudorgirba.com

"When people care, great things can happen."




_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki
Reply | Threaded
Open this post in threaded view
|

Re: bug rendering files in pier3?

Tudor Girba-2
Ok, it is more complicated.

The problem appears only when the baseUrl is not set:

MAExternalFileModel>>urlFromFileStructure: fileStructure
        ^ self baseUrl isNil
                ifTrue: [ super urlFromFileStructure: fileStructure ]
                ifFalse: [ self baseUrl , '/' , (self location reduce: [ :a :b | a , '/' , b ]) , '/' , self filename ]

However, when the baseUrl for files to something like "http://example.com/files" is set and we try to edit the page, the urls of the embedded files look like:
+http://example.com/files/.../logo.png+

instead of:
+logo.png+

Any ideas? And why did the logic changed so dramatically?


Cheers,
Doru


On 20 Nov 2012, at 22:23, Tudor Girba <[hidden email]> wrote:

> Hi,
>
> I found the problem in:
> PREmbeddedRenderer>>visitFileImage: aStructure
> <internal: 'image/' priority: 0>
>
> html image
> attributes: (self attributesFor: link);
> altText: aStructure title;
> url: aStructure url
>
> It should have been "aStructure file url".
>
> Is there a reason for the change?
>
> Cheers,
> Doru
>
>
>
> On 20 Nov 2012, at 22:06, Tudor Girba <[hidden email]> wrote:
>
>> Hi,
>>
>> Images seem to be rendered strangely in Pier 3.
>>
>> Having +/system/components/logo+ in the code generates the following html:
>> <img alt="Logo" src="http://www.example.com/system/components/logo">
>>
>> In Pier 2, this appeared correctly as:
>> <img alt="Logo" src="http://www.example.com/files/f6/0i0qkomrno1bwqff24ablc8y5dnlln/logo.png">
>>
>>
>> I did not have time to look too deep into it. Is this a known issue?
>>
>> Cheers,
>> Doru
>>
>> --
>> www.tudorgirba.com
>>
>> "No matter how many recipes we know, we still value a chef."
>>
>>
>>
>>
>>
>>
>
> --
> www.tudorgirba.com
>
> "When people care, great things can happen."
>
>
>

--
www.tudorgirba.com

"What is more important: To be happy, or to make happy?"


_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki