bug? #setPageSize: called in MorphThreeMorph but not defined

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

bug? #setPageSize: called in MorphThreeMorph but not defined

EstebanLM
Hi,

MorphThreeModel>>#pageSize: and MorphThreeModel>>#chunkSize: both sends #setPageSize:, but that message is not defined there or in parents. Unique definition is on PaginatedMorphThreeModel.

is that a bug?

best,
Esteban
Reply | Threaded
Open this post in threaded view
|

bug? Lazy Class creation via method saving not stored in recent changes log

Max Bareis
Hi,

I have encountered the issue, that the class creation is not stored in recent changes log when I process the following steps (ClassB does not exist):


ClassA>>methodA

        ClassB methodB.

save.

Now a popup appears and offers the creation of the ClassB. After accepting the class is created and visible in the System Browser, but there is no trace of the class creation in recent changes log. The method change is stored in the log. This affects Pharo 1.3 13315 OneClick

Regards

Max

Reply | Threaded
Open this post in threaded view
|

Re: bug? #setPageSize: called in MorphThreeMorph but not defined

Stéphane Ducasse
In reply to this post by EstebanLM

On Feb 13, 2012, at 4:08 PM, Esteban Lorenzano wrote:

> Hi,
>
> MorphThreeModel>>#pageSize: and MorphThreeModel>>#chunkSize: both sends #setPageSize:, but that message is not defined there or in parents. Unique definition is on PaginatedMorphThreeModel.
>
> is that a bug?

probably
>
> best,
> Esteban


Reply | Threaded
Open this post in threaded view
|

Re: bug? Lazy Class creation via method saving not stored in recent changes log

Stéphane Ducasse
In reply to this post by Max Bareis
thanks Max

Yes this is probably a problem with the notification of class definition.
Do you have a step by step reproduce able case for 1.4.

Stef

On Feb 13, 2012, at 4:34 PM, Max Bareis wrote:

> Hi,
>
> I have encountered the issue, that the class creation is not stored in recent changes log when I process the following steps (ClassB does not exist):
>
>
> ClassA>>methodA
>
> ClassB methodB.
>
> save.
>
> Now a popup appears and offers the creation of the ClassB. After accepting the class is created and visible in the System Browser, but there is no trace of the class creation in recent changes log. The method change is stored in the log. This affects Pharo 1.3 13315 OneClick
>
> Regards
>
> Max
>


Reply | Threaded
Open this post in threaded view
|

Re: bug? #setPageSize: called in MorphThreeMorph but not defined

Alain Plantec-3
In reply to this post by Stéphane Ducasse
thanks for reporting.
I will have a look
Cheers
Alain

Le 13/02/2012 17:00, Stéphane Ducasse a écrit :

> On Feb 13, 2012, at 4:08 PM, Esteban Lorenzano wrote:
>
>> Hi,
>>
>> MorphThreeModel>>#pageSize: and MorphThreeModel>>#chunkSize: both sends #setPageSize:, but that message is not defined there or in parents. Unique definition is on PaginatedMorphThreeModel.
>>
>> is that a bug?
> probably
>> best,
>> Esteban
>


Reply | Threaded
Open this post in threaded view
|

Re: bug? Lazy Class creation via method saving not stored in recent changes log

Max Bareis
In reply to this post by Stéphane Ducasse
Hi Stef,

this is also easy to create with the same steps in 1.4a 14329

save your image
create ClassA
create ClassA>>methodA with:
ClassB methodB
save it choose define new class press OK on the Information Required Box and check the recover lost changes.

There should be one entry regarding the method change but no entry for the class creation

Regards

Max

Am 13.02.2012 um 17:02 schrieb Stéphane Ducasse:

> thanks Max
>
> Yes this is probably a problem with the notification of class definition.
> Do you have a step by step reproduce able case for 1.4.
>
> Stef
>
> On Feb 13, 2012, at 4:34 PM, Max Bareis wrote:
>
>> Hi,
>>
>> I have encountered the issue, that the class creation is not stored in recent changes log when I process the following steps (ClassB does not exist):
>>
>>
>> ClassA>>methodA
>>
>> ClassB methodB.
>>
>> save.
>>
>> Now a popup appears and offers the creation of the ClassB. After accepting the class is created and visible in the System Browser, but there is no trace of the class creation in recent changes log. The method change is stored in the log. This affects Pharo 1.3 13315 OneClick
>>
>> Regards
>>
>> Max
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: bug? Lazy Class creation via method saving not stored in recent changes log

Max Bareis
Hi Stef,

additionally Renaming is also stored only partially in changes log.

save your image
rename the ClassB of the former example to ClassC via ctrl-click menu.
check recover lost changes

There you should see the change in the method but not the class rename.

Regards

Max


Am 14.02.2012 um 10:08 schrieb Max Bareis:

> Hi Stef,
>
> this is also easy to create with the same steps in 1.4a 14329
>
> save your image
> create ClassA
> create ClassA>>methodA with:
> ClassB methodB
> save it choose define new class press OK on the Information Required Box and check the recover lost changes.
>
> There should be one entry regarding the method change but no entry for the class creation
>
> Regards
>
> Max
>
> Am 13.02.2012 um 17:02 schrieb Stéphane Ducasse:
>
>> thanks Max
>>
>> Yes this is probably a problem with the notification of class definition.
>> Do you have a step by step reproduce able case for 1.4.
>>
>> Stef
>>
>> On Feb 13, 2012, at 4:34 PM, Max Bareis wrote:
>>
>>> Hi,
>>>
>>> I have encountered the issue, that the class creation is not stored in recent changes log when I process the following steps (ClassB does not exist):
>>>
>>>
>>> ClassA>>methodA
>>>
>>> ClassB methodB.
>>>
>>> save.
>>>
>>> Now a popup appears and offers the creation of the ClassB. After accepting the class is created and visible in the System Browser, but there is no trace of the class creation in recent changes log. The method change is stored in the log. This affects Pharo 1.3 13315 OneClick
>>>
>>> Regards
>>>
>>> Max
>>>
>>
>>
>
>