[bug] smalltalk-mode.el not good with old syntax

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[bug] smalltalk-mode.el not good with old syntax

Jeronimo Pellegrini-5
Issue status update for
http://smalltalk.gnu.org/node/179
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/179

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  jeronimo
 Updated by:   jeronimo
 Status:       active

Hello.

I have some files that I created using the old syntax of GNU Smalltalk.
With GNU Smalltalk 3.0.1, I can't easily edit those files anymore.

The new command, smalltalk-bang, doesn't seem to work with files using
the old syntax.

A silly example:


!Object methodsFor: 'stuff'!

    "Newton method for swuare roots -- this is the iterating part."
    newtonIterate: n | newValue |
    newValue := 0.5 * (n + (self / n)).
    ( (n - newValue) abs < 0.00000001 )
        ifTrue:  [ ^newValue ]
        ifFalse: [ "newValue printNl." ^self newtonIterate: newValue ]
!

    "Newton method for square roots."
    newton
    (self < 0)
        ifTrue:  [ self error: 'Negative numbers have no square root!'
]
        ifFalse: [ ^self newtonIterate: self ] !


If you try hitting ! several times, you will notice that
it will both produce the bang on the text and go,
sometimes to the end of the method, and sometimes somewhere inside a
string (if there is a ! inside the string).

Thank you,
J.

PS: I assigned to component base classes because there is no "Emacs
interactor" option...




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] smalltalk-mode.el not good with old syntax

Paolo Bonzini-3
Issue status update for
http://smalltalk.gnu.org/project/issue/179
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/179

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  jeronimo
 Updated by:   bonzinip
-Status:       active
+Status:       patch
 Attachment:   http://smalltalk.gnu.org/files/issues/gst-179.patch (840 bytes)

Just a thinko -- smalltalk-end-of-defun should not be executed if in
old-syntax mode.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] smalltalk-mode.el not good with old syntax

Paolo Bonzini-3
In reply to this post by Jeronimo Pellegrini-5
Issue status update for
http://smalltalk.gnu.org/project/issue/179
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/179

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  jeronimo
 Updated by:   bonzinip
-Status:       patch
+Status:       fixed

committed to master and stable-3.0.




_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Re: [bug] smalltalk-mode.el not good with old syntax

Jeronimo Pellegrini-5
Hi Paolo!

I suppose it wasn't pushed yet, although I see other
changes from yesterday in the repository.

$ git clone git://git.sv.gnu.org/smalltalk.git
$ cd smalltalk
$ git checkout master
$ patch --dry-run -p1 </home/jeronimo/gst-179.patch
patching file smalltalk-mode.el.in
$ patch --dry-run -p1 </home/jeronimo/gst-180.patch
patching file gst-mode.el.in
$ git checkout stable-3.0
Switched to branch "stable-3.0"
$ patch --dry-run -p1 </home/jeronimo/gst-179.patch
patching file smalltalk-mode.el.in
$ patch --dry-run -p1 </home/jeronimo/gst-180.patch
patching file gst-mode.el.in
$

Did I get the right repository or was it not pushed?

J.

On Tue, Mar 04, 2008 at 05:14:05AM -0700, Paolo Bonzini wrote:

> Issue status update for http://smalltalk.gnu.org/project/issue/179
> Post a follow up: http://smalltalk.gnu.org/project/comments/add/179
>
> Project:      GNU Smalltalk
> Version:      <none>
> Component:    Base classes
> Category:     bug reports
> Priority:     normal
> Assigned to:  Unassigned
> Reported by:  jeronimo
> Updated by:   bonzinip
> -Status:       patch
> +Status:       fixed
>
> committed to master and stable-3.0.
>
> _______________________________________________
> help-smalltalk mailing list
> [hidden email]
> http://lists.gnu.org/mailman/listinfo/help-smalltalk


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Re: [bug] smalltalk-mode.el not good with old syntax

Paolo Bonzini-2

> Did I get the right repository or was it not pushed?

Pushed now.

Paolo


_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: Re: [bug] smalltalk-mode.el not good with old syntax

Jeronimo Pellegrini-5
On Wed, Mar 05, 2008 at 11:49:34AM +0100, Paolo Bonzini wrote:
>
>> Did I get the right repository or was it not pushed?
>
> Pushed now.
>
> Paolo

Thanks for your nice work Paolo!
J.



_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk